We moved our repositories to BitBucket!

If you can't login or you can't register to the forums do not rise an issue, instead please write to support (at) l2jserver.com

Check our wiki!

Report server issues here

Forum has been updated to phpBB 3.2, let's see if this fixes some minor bugs we had.

Thank you for visiting http://www.l2jserver.com/

[FIXED]Incomplete Mentor Skills/Buffs

Move here solved/invalid bug reports.
Please add manual tag [INVALID] to invalid reports, until we add new tag system, thanks.
Post Reply
mattjanes
Posts: 30
Joined: Sun Jan 07, 2007 2:26 am

[FIXED]Incomplete Mentor Skills/Buffs

Post by mattjanes » Mon Jan 26, 2015 10:47 pm

I may be blind and it might be somewhere else, I haven't tested ingame yet, have just been looking at the code, however

Code: Select all

// Skills
	private final static SkillHolder[] MENTEE_BUFFS =
	{
		new SkillHolder(9227, 1), // Mentor's Poem of Horn
		new SkillHolder(9228, 1), // Mentor's Poem of Drum
		new SkillHolder(9229, 1), // Mentor's Poem of Lute
		new SkillHolder(9230, 1), // Mentor's Poem of Organ
		new SkillHolder(9231, 1), // Mentor's Poem of Guitar
		new SkillHolder(9232, 1), // Mentor's Poem of Harp
		new SkillHolder(9233, 1), // Mentor's Guidance
	};
	
	protected static final SkillHolder[] MENTOR_BUFFS =
	{
		new SkillHolder(9256, 1), // Mentee's Appreciation;
	};
	
	private static final SkillHolder MENTEE_MENTOR_SUMMON = new SkillHolder(9379, 1); // Mentee's Mentor Summon
There is 6 missing skills 3 from MENTEE_BUFFS and 3 skills to be applied to mentor.

Code: Select all

// Mentee Buffs (Sonatas)

new SkillHolder(17082, 1), // Mentor's Prevailing Sonata
new SkillHolder(17083, 1), // Mentor's Daring Sonata
new SkillHolder(17084, 1), // Mentor's Refreshing Sonata


// Mentor Skill
//These skills become Permanent at 85+ once you are able to be a Mentor, they can only be applied to your Mentee, you do not require a current mentee to have these skills, however you don't obtain these skills until you get your first mentee, therefor they should be added to a mentor when he gets his first mentor, but never removed.

private static final SkillHolder MENTOR_KNIGHTS_HARMONY = new SkillHolder(9376, 1); // Mentor's Knight's Harmony
private static final SkillHolder MENTOR_WIZARDS_HARMONY = new SkillHolder(9377, 1); // Mentor's Wizard's Harmony
private static final SkillHolder MENTOR_WARRIORS_HARMONY = new SkillHolder(9378, 1); // Mentor's Warrior's Harmony
Combined:

Code: Select all

// Skills
	private final static SkillHolder[] MENTEE_BUFFS =
	{
		new SkillHolder(9227, 1), // Mentor's Poem of Horn
		new SkillHolder(9228, 1), // Mentor's Poem of Drum
		new SkillHolder(9229, 1), // Mentor's Poem of Lute
		new SkillHolder(9230, 1), // Mentor's Poem of Organ
		new SkillHolder(9231, 1), // Mentor's Poem of Guitar
		new SkillHolder(9232, 1), // Mentor's Poem of Harp
		new SkillHolder(17082, 1), // Mentor's Prevailing Sonata
		new SkillHolder(17083, 1), // Mentor's Daring Sonata
		new SkillHolder(17084, 1), // Mentor's Refreshing Sonata
		new SkillHolder(9233, 1), // Mentor's Guidance
	};
	
	protected static final SkillHolder[] MENTOR_BUFFS =
	{
		new SkillHolder(9256, 1), // Mentee's Appreciation;
	};
	
	private static final SkillHolder MENTEE_MENTOR_SUMMON = new SkillHolder(9379, 1); // Mentee's Mentor Summon
	private static final SkillHolder MENTOR_KNIGHTS_HARMONY = new SkillHolder(9376, 1); // Mentor's Knight's Harmony
	private static final SkillHolder MENTOR_WIZARDS_HARMONY = new SkillHolder(9377, 1); // Mentor's Wizard's Harmony
	private static final SkillHolder MENTOR_WARRIORS_HARMONY = new SkillHolder(9378, 1); // Mentor's Warrior's Harmony
Adding skills for Mentor:

Code: Select all

public void onMenteeAdded(OnPlayerMenteeAdd event)
	{
		// Starting buffs for Mentor
		for (SkillHolder sk : MENTOR_BUFFS)
		{
			sk.getSkill().applyEffects(event.getMentor(), event.getMentor());
		}
		
		// Starting buffs for Mentee
		for (SkillHolder sk : MENTEE_BUFFS)
		{
			sk.getSkill().applyEffects(event.getMentee(), event.getMentee());
		}
		
		// Update mentor list
		event.getMentor().sendPacket(new ExMentorList(event.getMentor()));
		
		// Add the mentee skill
		event.getMentee().addSkill(MENTEE_MENTOR_SUMMON.getSkill(), true);
		
		// Add the mentor skills
		event.getMentor().addSkill(MENTOR_KNIGHTS_HARMONY.getSkill(), true);
		event.getMentor().addSkill(MENTOR_WIZARDS_HARMONY.getSkill(), true);
		event.getMentor().addSkill(MENTOR_WARRIORS_HARMONY.getSkill(), true);
		
		// Send mail with the headphone
		sendMail(event.getMentee(), MENTEE_ADDED_TITLE, MENTEE_ADDED_BODY, MENTEE_HEADPHONE, 1);
	}

User avatar
Stooki
Posts: 66
Joined: Mon Jan 16, 2012 4:05 pm

Re: Incomplete Mentor Skills/Buffs

Post by Stooki » Tue Jan 27, 2015 12:54 am

OP Mentees :D
" I asked God for a bike,
But i know God doesen't work that way.
So i stole a bike and i asked for forgiveness "

- Al Pacino

mattjanes
Posts: 30
Joined: Sun Jan 07, 2007 2:26 am

Re: Incomplete Mentor Skills/Buffs

Post by mattjanes » Tue Jan 27, 2015 1:23 am

Stooki wrote:OP Mentees :D
Haha but its is retail like :P

User avatar
Stooki
Posts: 66
Joined: Mon Jan 16, 2012 4:05 pm

Re: Incomplete Mentor Skills/Buffs

Post by Stooki » Tue Jan 27, 2015 2:43 am

As far as i know it's not like that.
And as i know l2j team got characters in official they test stuffs and i think they didn't miss that tho :P
" I asked God for a bike,
But i know God doesen't work that way.
So i stole a bike and i asked for forgiveness "

- Al Pacino

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: Incomplete Mentor Skills/Buffs

Post by UnAfraid » Tue Jan 27, 2015 3:13 am

Oh, i forget to add those harmonies damn! :mrgreen:
Image

mattjanes
Posts: 30
Joined: Sun Jan 07, 2007 2:26 am

Re: Incomplete Mentor Skills/Buffs

Post by mattjanes » Tue Jan 27, 2015 4:20 pm

Stooki wrote:As far as i know it's not like that.
And as i know l2j team got characters in official they test stuffs and i think they didn't miss that tho :P
I have maxed out chars on official I can screen cap when I get of work if I need to :P they never used to have the sonatas but they do since lindvi I think was the first chroni.

User avatar
Sdw
L2j Veteran
L2j Veteran
Posts: 855
Joined: Mon May 03, 2010 8:38 am
Location: France

Re: Incomplete Mentor Skills/Buffs

Post by Sdw » Tue Jan 27, 2015 4:38 pm

Moved the thread in the proper section

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: Incomplete Mentor Skills/Buffs

Post by UnAfraid » Tue Jan 27, 2015 6:29 pm

mattjanes wrote:
Stooki wrote:As far as i know it's not like that.
And as i know l2j team got characters in official they test stuffs and i think they didn't miss that tho :P
I have maxed out chars on official I can screen cap when I get of work if I need to :P they never used to have the sonatas but they do since lindvi I think was the first chroni.
I did this system on awakening and after that i updated it to Ertheia but seems like i forget to add some buffs and some skills.
Image

mattjanes
Posts: 30
Joined: Sun Jan 07, 2007 2:26 am

Re: Incomplete Mentor Skills/Buffs

Post by mattjanes » Tue Jan 27, 2015 6:36 pm

Yea it's all good just thought I'd share what little I can :P

User avatar
Sdw
L2j Veteran
L2j Veteran
Posts: 855
Joined: Mon May 03, 2010 8:38 am
Location: France

Re: Incomplete Mentor Skills/Buffs

Post by Sdw » Tue Jan 27, 2015 6:40 pm

UnAfraid wrote:
mattjanes wrote:
Stooki wrote:As far as i know it's not like that.
And as i know l2j team got characters in official they test stuffs and i think they didn't miss that tho :P
I have maxed out chars on official I can screen cap when I get of work if I need to :P they never used to have the sonatas but they do since lindvi I think was the first chroni.
I did this system on awakening and after that i updated it to Ertheia but seems like i forget to add some buffs and some skills.
Time to update it then, NOW :D

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: Incomplete Mentor Skills/Buffs

Post by UnAfraid » Tue Jan 27, 2015 6:55 pm

Image

User avatar
Sdw
L2j Veteran
L2j Veteran
Posts: 855
Joined: Mon May 03, 2010 8:38 am
Location: France

Re: Incomplete Mentor Skills/Buffs

Post by Sdw » Tue Jan 27, 2015 7:12 pm

Thanks ;)

Post Reply