Contributions offtopic

[jurchiks]

so they can test all on live servers

Reviewers review (and test if they want, but not necassarily), testers test. Separate responsibilities.

The only one who have live server running l2j atm is nBd.

You're talking only about team members, but there are community members too.

Since he started his live server we discovered so many problems that was there and noone else reported them, that's sad..

That's why such groups should be made.
Obviously, you should first create a poll topic in Announcements section asking people if they would be interested in joining any of those groups (possible answer variants: "I'd like to be a tester", "I'd like to be a reviewer", "I'd like to be both", "neither suits me"), because if nobody were to join there'd be no point.
There are only 3 problems with this:
1) you need to find such people
2) you need to know they will "filter out" the bad contributions decently or be able to help them develop into something good
3) you need to actually check/commit the contributions that pass their tests/reviews

But that would be far better than the current situation where someone only reviews/commits a contribution if they're in the mood (except bugfixes).

[Zoey76]

@last jurchiks post, we have Adv. Users for that, creating more hierarchy for that is not required, althogh it could be done.

Fixed my previous post due:

[jurchiks]

Well I don't really see those Advanced Users doing that.

That's not really hierarchy IMO, but w/e.

[xban1x]

I believe you had a chance to become an Adv User jurchiks, and be 1 of those 3 branches but yet you declined. Now you don't receive as much attention as for example i do and that disturbs you. You should read what being an Adv User gets you.

Becoming and Adv. User is the first step to get closer to the team, this gives you a few unofficial perks:
You can talk directly to developers and they will find some time for you.

You see that ? They will find some time for you ? Even as Advanced User you don't get as much time as you would like but more you work more attention you can expect to receive. Except as in your case you keep forcing them to do stuff like they are paid to do it. All devs here are cause they want to help the project. That doesn't mean they are obliged to check everything and commit everything in less then a week. They do it when they have the time. They can't supply info for every contribution that doesn't use retail logic or info. If they were doing that they would never have time to work on their own tasks or tasks given by Zoey. Try get this in your head already jurchiks.

[jurchiks]

I believe you had a chance to become an Adv User jurchiks, and be 1 of those 3 branches but yet you declined.

As far as I remember, I've never received an invite.
But getting the attention of the devs should not require you to become an advanced user, that is flawed logic.

And you're all replying here as if the way stuff currently progresses is completely fine. Can any one of you honestly say you believe that?
@xban1x - your own contributions are ignored even though you're an Advanced User, does that not bother you?

[UnAfraid]

As far as I remember, I've never received an invite.
But getting the attention of the devs should not require you to become an advanced user, that is flawed logic.

Being an Advanced user allows you to be in our private Skype conversation where you can get attentions of all devs.

And you're all replying here as if the way stuff currently progresses is completely fine. Can any one of you honestly say you believe that?

What means fine for you what must change in l2j in order to be 'fine', tell me that please.

@xban1x - your own contributions are ignored even though you're an Advanced User, does that not bother you?

xban1x's contributions are not ignored they are either not finished or there's no feedback.

[Gladicek]

Being an Advanced user allows you to be in our private Skype conversation where you can get attentions of all devs.

I can fap fap only with Zoey on skype, St3eT and malyelfik on ICQ. WTB more contacts

[Zoey76]

Being an Advanced user allows you to be in our private Skype conversation where you can get attentions of all devs.

I can fap fap only with Zoey on skype, St3eT and malyelfik on ICQ. WTB more contacts

Sorry, you what?

[MELERIX]

I can fap fap only with Zoey on skype, St3eT and malyelfik on ICQ. WTB more contacts

[jurchiks]

Being an Advanced user allows you to be in our private Skype conversation where you can get attentions of all devs.

Why would I want the attention of ALL devs? One or two is enough for almost any case, except when discussing changes in policies or some MAJOR reworks (the ones currently being made are not major, they're normal reworks, though for l2j relatively they might seem as such).

What means fine for you what must change in l2j in order to be 'fine', tell me that please.

Like I've written countless times, the attention given to user contributions is not nearly enough for this project to prosper. That is what should be changed, and I've already proposed a solution to that.

xban1x's contributions are not ignored they are either not finished or there's no feedback.

Related to my suggestion - if there were people with roles designated to test/review code, that wouldn't be a problem.
But in any case, he's your teammate, you should at least check his work. I have, and I don't see any problems in the code.


@MELERIX -

[xban1x]

You know why subclass certification isnt commited? Cause you ignorant and disrespectful idiot used it to humiliate me while i have just started with l2j. The request to not be commited came from me since i dont want your name staining my work

[jurchiks]

Bullshit, I never intend to humiliate anyone, it was your imagination that made you think it was humiliating.
I simply showed you how to better write your code and you got all resentful.
It is not my fault if you don't see the value in my suggestions.

[xban1x]

Bullshit, I never intend to humiliate anyone, it was your imagination that made you think it was humiliating.
I simply showed you how to better write your code and you got all resentful.
It is not my fault if you don't see the value in my suggestions.

Showing means that you tell me how to write it better, not that you write it yourself and add your name in author tag. Which imho you don't deserve not even by a mile.

[UnAfraid]

What means fine for you what must change in l2j in order to be 'fine', tell me that please.

Like I've written countless times, the attention given to user contributions is not nearly enough for this project to prosper. That is what should be changed, and I've already proposed a solution to that.

Show me a list of contributions without answer (but contributions that are not just custom stuff or stolen files from another project)

[jurchiks]

I don't mean just any answer, I mean either "fix this/that so it can be committed" or "this won't be committed because ...". Requests for testing and then abandoning the contribution because of no response don't fly, you can assign a team member to check it when someone has the time. Being in the team does not mean you just wait for people to submit perfect contributions, somebody from the team has to check them and give their feedback aswell.

viewtopic.php?f=69&t=27172
The only thing missing from all these patches is the related changes for the quest timer methods in datapack, so that could be skipped for the moment. Everything else is valid (I'd just have to update the patches a bit).
If the dropQuestItems improvements and fix were to be committed, this thread could be locked because it's the same idea:
viewtopic.php?f=69&t=26782

More:
viewtopic.php?f=69&t=27300
viewtopic.php?f=69&t=24288
viewtopic.php?f=69&t=24853
viewtopic.php?f=69&t=25657
viewtopic.php?f=69&t=24481
viewtopic.php?f=69&t=23902
viewtopic.php?f=51&t=22759
viewtopic.php?f=43&t=27382
viewtopic.php?f=43&t=19595
viewtopic.php?f=43&t=19463
viewtopic.php?f=55&t=21759
viewtopic.php?f=55&t=26463
viewtopic.php?f=55&t=26063
viewtopic.php?f=24&t=20861
viewtopic.php?f=24&t=27289 (apparently xban1x has no time for his full saga class rework, this could be committed for now. At least give a final word on it)
viewtopic.php?f=55&t=27052 (yeah I know xban1x said to not commit it, but it is still a valid contribution)
viewtopic.php?f=24&t=27182 (this didn't go well because I posted a modified patch of Citizen's script that was fully retail-like, but then we started arguing about stuff that didn't really matter. Nevertheless, the patch is good)

All of these (and more) have not received any word about what is missing to commit it or if it is not going to be committed.


@xban1x - if you don't take my suggestions into consideration and don't even say why, why should I not post a readable example of what I mean so you understand the benefit of it? You have never ever explained why you consider my suggestions bad (same as everyone else around here).
I added my nickname because of the magnitude of changes I made to your script, though, personally, I'd like to avoid adding the @author tag altogether because of such arguments.