telling same thing to you as I did to afk5min XD Leave him and answer to my PM xDZoey76 wrote:
Don't "dude" me, I just gave you a proper answer from someone that has been doing this for a long time.
Provide a patch that actually proves the code is duplicated/useless and then we can continue talking about it.
Sure, when you are the only developer, you can say thatSpooKNoF wrote:the point for null checks is THE NULL if somehting is null in 1 code how you will bypass it? we using 1 check for all methods
afk5min wrote:Sure, when you are the only developer, you can say thatSpooKNoF wrote:the point for null checks is THE NULL if somehting is null in 1 code how you will bypass it? we using 1 check for all methods
'HO HO HO, merry xmas! this method does not need a null check, because all callers do a null check themselves! I know, because I wrote the code all by myself. Also, noone will ever add any code that violates these conditions, because I AM THE ONLY DEVELOPER'
Honestly, I am tired of your whining, your broken english and the fact that you dismiss everyone who is trying to help you. That's why every time you post a message in this thread, I am going to reply with this:SpooKNoF wrote:1 method call another method to continue the hit so if we will put the check on start so...
Code: Select all
@Override protected void onIntentionAttack(L2Character target) { if (target == null) //First null check... { System.out.println("L2CharacterAi onIntentionAttack System Check null target: " + _actor.getName() + "."); clientActionFailed(); return; } System.out.println("L2CharacterAi onIntentionAttack System Check target: " + _actor.getName() + "." + target.getName());Code: Select all
protected void doAttack(L2Character target) { if (target == null) //second null check { System.out.println("L2Character doAttack System Check null target: " + getName() + "."); return; } if (isAttackingDisabled() || !getEvents().onAttack(target)) { return; } System.out.println("L2Character doAttack System Check target: " + getName() + "." + target.getName());Code: Select all
public void onHitTimer(L2Character target, int damage, boolean crit, boolean miss, boolean soulshot, byte shld) { if (target == null) //third null check { System.out.println("L2Character onHitTimer System Check null target: " + getName() + "."); getAI().notifyEvent(CtrlEvent.EVT_CANCEL); return; } System.out.println("L2Character onHitTimer System Check target: " + getName() + "." + target.getName());Code: Select all
/** * @author lord_rex */public final class PiffPuff{ public static void main(String[] args) { final SpooKNoF player = new SpooKNoF(); startSuffering(player); } static void startSuffering(final SpooKNoF player) { while (!player.hasSufferedEnough()) player.suffer(); } static class SpooKNoF { public void suffer() { System.out.println("SpooKNoF is Suffering!"); } public boolean hasSufferedEnough() { return false; // constant, never returns true } }} lord_rex wrote:just do me a favor and run that:
Code: Select all
/** * @author lord_rex */public final class PiffPuff{ public static void main(String[] args) { final SpooKNoF player = new SpooKNoF(); startSuffering(player); } static void startSuffering(final SpooKNoF player) { while (!player.hasSufferedEnough()) player.suffer(); } static class SpooKNoF { public void suffer() { System.out.println("SpooKNoF is Suffering!"); } public boolean hasSufferedEnough() { return false; // constant, never returns true } }}
everyone telling it to him for a week, but anyway good luck to explain him, but if I were u I woudn't waste my time with him... I just started the time wasting because he was breakin' my precious discussions with his stupid null checksxban1x wrote:null checks are more then usefull. what if that method sometime will be used directly and may be passed a null variable? then you will cry we got Npes.
lord_rex wrote:everyone telling it to him for a week, but anyway good luck to explain him, but if I were u I woudn't waste my time with him... I just started the time wasting because he was breakin' my precious discussions with his stupid null checksxban1x wrote:null checks are more then usefull. what if that method sometime will be used directly and may be passed a null variable? then you will cry we got Npes.
1. saying same as Zoey, don't "dude me"SpooKNoF wrote:lord_rex wrote:everyone telling it to him for a week, but anyway good luck to explain him, but if I were u I woudn't waste my time with him... I just started the time wasting because he was breakin' my precious discussions with his stupid null checksxban1x wrote:null checks are more then usefull. what if that method sometime will be used directly and may be passed a null variable? then you will cry we got Npes.
dude come on you think you are good now because you say null check is usefull there?
its my opinion to say null check is ussules there so what did you try to explain me?