Bypass Handler tweak ;)

[papadkostas]

Hello every body..
Today i realized that on my Service's Npc that is instance of L2VillageMaster,
On clan's warehouse option that i made..when i try to deposit/widthdraw from clan's warehouse..
nothings happens when i press ok..
What i mean?
The windows just dissapears and nothing goes out/in clan's warehouse!
But if i use admin character..it works perfect!
This is the edited bypass handler of ClanWarehouse.java line:46

Code: Select all

 if (!(target instanceof L2WarehouseInstance) && !(target instanceof L2ClanHallManagerInstance) && !(target instanceof L2VillageMasterInstance))            return false; 

And here the bypass handler of ClanWarehouse.java line:46 non edited.

Code: Select all

 if (!(target instanceof L2WarehouseInstance) && !(target instanceof L2ClanHallManagerInstance))            return false; 

I'm pretty sure that i forgot something ..but my knowledge on L2j is just so tiny..
I tryed enough to find it by my self..but after 2 hours of searching i gave up
Thanks for your time

[BiggBoss]

/trunk/L2_GameServer/java/com/l2jserver/gameserver/network/clientpackets/SendWareHouseDepositList.java

Code: Select all

         final L2Npc manager = player.getLastFolkNPC();        if ((manager == null                || !manager.isWarehouse()                || !manager.canInteract(player)) && !player.isGM())            return; 

/trunk/L2_GameServer/java/com/l2jserver/gameserver/network/clientpackets/SendWareHouseWithDrawList.java

Code: Select all

         final L2Npc manager = player.getLastFolkNPC();        if ((manager == null                || !manager.isWarehouse()                || !manager.canInteract(player)) && !player.isGM())            return;  

btw, wrong section

[papadkostas]

yeah boss
i didnt knew where that fit to posted
thank you so much

[papadkostas]

wow..boss,i removed
"&& !player.isGM()"
but again..when i use wh
and select items to deposit or widtdraw
when i press confirm window dissapear and its like nothing hapened

[BiggBoss]

is not to remove the gm condition, but about to increase the scope of

Code: Select all

 !manager.isWarehouse() 

prolly, your npc isnt a warehouse. You may add a || condition to accept also your kind of npc

[papadkostas]

Code: Select all

         final L2Npc manager = player.getLastFolkNPC();if ((manager == null                 || !manager.isWarehouse()                 || !manager.isVillageMaster()                  || !manager.canInteract(player)) && !player.isGM())return; 

hell yeah .. jk this this is wrong..
in L2Npc doesnt exist a public boolean for VillageMaster
..or i'm wrong?

[BiggBoss]

you may use the InstanceType enum check (preferred) or the instanceof check

[JIV]

InstanceType enum check is slower than instanceof

[papadkostas]

Code: Select all

        if ((manager == null                || !manager.isWarehouse()                || !(manager instanceof L2VillageMasterInstance)                || !manager.canInteract(player)) && !player.isGM())            return;

i think this gonna work
going to try

[_DS_]

Code: Select all

@Overridepublic boolean isWarehouse(){return true;} 

Add it to the L2VillageMasterInstance.

[papadkostas]

tested and worked
Spasiba to all
..btw spasiba mean thanks