Question regarding spoil methods

[sahar]

In L2Attackable is there a reason we got this:

Code: Select all

	private boolean _isSpoil = false;
	private int _isSpoiledBy = 0;
	
	public boolean isSpoil()
	{
		return _isSpoil;
	}
	
	public void setSpoil(boolean isSpoil)
	{
		_isSpoil = isSpoil;
	}
	
	public final int getIsSpoiledBy()
	{
		return _isSpoiledBy;
	}
	
	public final void setIsSpoiledBy(int value)
	{
		_isSpoiledBy = value;
	}

Rather than just this:

Code: Select all

	private int _isSpoiledBy = 0;
	
	public boolean isSpoil()
	{
		return _isSpoiledBy > 0;
	}
	
	public final int getIsSpoiledBy()
	{
		return _isSpoiledBy;
	}
	
	public final void setIsSpoiledBy(int value)
	{
		_isSpoiledBy = value;
	}

[jurchiks]

That's called "Advanced coding skills"
Anyway, it should be _spoiledBy, "is" prefix is meant for boolean variables/methods only (like isSpoil()).

[sahar]

Another thing I came accross, if x do y and then do y again anyway...

Code: Select all

if (stackedInfo.getSkill().isAbnormalInstant())
{
	stopSkillEffects(false, skill.getAbnormalType());
}
stopSkillEffects(false, skill.getAbnormalType());

in CharEffectList.java

[Sdw]

Dude you don't know what you just did

[sahar]

Huh? is it bad? ;p