Coding Guidelines

[Evilus]

I must say that most of these guidelines are pretty good. I have seen on svn people remove { }from if statements that just had 1 line, but that is wrong they should be there, there are many more examples. Very nice initiate to post this

[jurchiks]

well, since i have only c5 source atm, i checked that one and it's really tidy imo

[janiii]

the l2j code is really messy, i agree. but it is not that easy. if i change a code, i better do not format it too, because then mostly noone could see the real changes i made. probably only a full format of the code, without any fixes or changes should be done, but sometimes also the code format messes up the code. a proper format setting is needed.

[Vapulabe]

I don't know if it works under Java... But under C, we have the "indent" tool which helps doing massive reformat...

There are few people with SVN Write access, if they agree, they may suspend the changes at some points, have some massive reformatting of the code committed (automatically reformatted + if/for/while braces added) then start again doing changes, based on the new (cleaner) source.

[janiii]

I don't know if it works under Java... But under C, we have the "indent" tool which helps doing massive reformat...

There are few people with SVN Write access, if they agree, they may suspend the changes at some points, have some massive reformatting of the code committed (automatically reformatted + if/for/while braces added) then start again doing changes, based on the new (cleaner) source.

yep, i would agree let's do some mess more

the most problems make arrays. we have own way to format them and every code format just f*cks that up

[Vapulabe]

Well, code cleaning is done in huge projects like Linux... tell me why it shouldn't be possible with L2J ?

[janiii]

Well, code cleaning is done in huge projects like Linux... tell me why it shouldn't be possible with L2J ?

when comparing l2j to other projects.. what about sun java source code? check it.. really messy..

but as i already wrote, i am for cleaning up the code (+1), because i still get mad when i see spaces and tabs mixed up, no spaces in if statements or assignments, etc..