ThePhoenixBird wrote:How to get a Forum Contribution Commited:
- Clean Coding, make it easy to read.
- Do not HARDcode your stuff, while less code you use the better.
Sorry, if I sound like a troll, but this times you are a troll on L2j forum, when you don't comply to devs opinion.
If whole L2j would be clean coded, there wouldn't be bugs like this
viewtopic.php?f=81&t=20154 , that are really easy to fix (or better which should never occur, when you think about thread-safety before commiting smth - btw: This is not the only occurence of non-thread-safe iterating, look at CharEffectList for example). Seriously, a lot of the commits from L2j devs are not even clean coded. Run a code analyzer and you will see about 230 code parts with more than 25 lines, that are just copy & paste. THAT ís definetly no clean coding.
I contribute a lot to open source projects, and i did also a few large things for L2j in the past (friendlist rework for example - look at old forums), but open source development includes the community. In L2j it is like: Devs commit, Community contributes (but noone cares - if someone cares the contrib is slightly rewritten and no credits are given). And no, this is no false allegation, but it happened a few times that code parts where not touched for years, though they didn't work, but short after a contrib the code was rewritten nearly the same was as the contrib was, but there was not even a "thanks for the reminder xyz" or smth like that. Sorry, but that's not the way it should be.
IMHO your attitude and behaviour against other people do the rest. The open letter to non-friendly forks is a joke, but i will not discuss this again. Do you really think it helps when some L2j devs come to IRC channels of forks or other servers just to bitch around? Another thing is the teamwork with the forks - it could be A LOT better, but that's what you don't tell people here on L2j. I know of at least 2 forks (1 for sure) that really tried to work together with L2j, but the basic answer was "you can give us code/information, but you will not get anything from us (before public release). if you aren't ok with this just gtfo". And after that, there came this open letter, which was basically a punch in the face for ALL forks.
But enough for now. It's christmas

This is just my opinion. If you don't like it, delete it (or edit it, like you did with a few of my recent posts - without a note, that it was edited). I know that I'm not alone with that oppinion and if you continue to ignore everything the community says, it'll be the end of L2j (you gave proof for that by yourself, because contrib rate dropped a lot in the last months).
Honestly on some days i think: "When will L2j forum be renamed to L2inc forum and is closed development then?"