Re: Contributions offtopic
Posted: Fri May 10, 2013 11:42 am

viewtopic.php?f=69&t=24288 - Committed different approach also there's dev's comments!jurchiks wrote:I don't mean just any answer, I mean either "fix this/that so it can be committed" or "this won't be committed because ...". Requests for testing and then abandoning the contribution because of no response don't fly, you can assign a team member to check it when someone has the time. Being in the team does not mean you just wait for people to submit perfect contributions, somebody from the team has to check them and give their feedback aswell.
viewtopic.php?f=69&t=27172
The only thing missing from all these patches is the related changes for the quest timer methods in datapack, so that could be skipped for the moment. Everything else is valid (I'd just have to update the patches a bit).
If the dropQuestItems improvements and fix were to be committed, this thread could be locked because it's the same idea:
viewtopic.php?f=69&t=26782
More:
viewtopic.php?f=69&t=27300
viewtopic.php?f=69&t=24288
viewtopic.php?f=69&t=24853
viewtopic.php?f=69&t=25657
viewtopic.php?f=69&t=24481
viewtopic.php?f=69&t=23902
viewtopic.php?f=51&t=22759
viewtopic.php?f=43&t=27382
viewtopic.php?f=43&t=19595
viewtopic.php?f=43&t=19463
viewtopic.php?f=55&t=21759
viewtopic.php?f=55&t=26463
viewtopic.php?f=55&t=26063
viewtopic.php?f=24&t=20861
viewtopic.php?f=24&t=27289 (apparently xban1x has no time for his full saga class rework, this could be committed for now. At least give a final word on it)
viewtopic.php?f=55&t=27052 (yeah I know xban1x said to not commit it, but it is still a valid contribution)
viewtopic.php?f=24&t=27182 (this didn't go well because I posted a modified patch of Citizen's script that was fully retail-like, but then we started arguing about stuff that didn't really matter. Nevertheless, the patch is good)
All of these (and more) have not received any word about what is missing to commit it or if it is not going to be committed.
@xban1x - if you don't take my suggestions into consideration and don't even say why, why should I not post a readable example of what I mean so you understand the benefit of it? You have never ever explained why you consider my suggestions bad (same as everyone else around here).
I added my nickname because of the magnitude of changes I made to your script, though, personally, I'd like to avoid adding the @author tag altogether because of such arguments.
No word about whether or not it was to be committed, and since a different approach was committed it requires moving to Archived.UnAfraid wrote:viewtopic.php?f=69&t=24288 - Committed different approach also there's dev's comments!
That different approach was committed just recently, while this contribution was made more than a year ago and was abandoned. Valid report.UnAfraid wrote:viewtopic.php?f=69&t=24853 - Committed different approach also there's dev's comments!
Just saying it needs the attention. Looks abandoned because no posts since last year.UnAfraid wrote:viewtopic.php?f=69&t=25657 - Still pending also there's dev's comments!
Then why did you not post your opinion in the thread and just abandon it like that? He made it with his best intentions in mind, and you know he's a decent programmer.UnAfraid wrote:viewtopic.php?f=69&t=24481 - Lack of feedback also i am not going to change database impl like that, if we are going to use such approach i would implement hibernate.
Still no reply in the topic. Valid report.UnAfraid wrote:viewtopic.php?f=69&t=23902 - Lack of feedback also that packet needs some more rework.
Ok, then assign it to someone.UnAfraid wrote:viewtopic.php?f=51&t=22759 - There is dev comments DP devs must take care of it, since i am not one of those i can't say what it isn't committed.
It's not related to quests because those are the default htmls, can be committed separately. Smaller commits are easier to manage.UnAfraid wrote:viewtopic.php?f=43&t=27382 - There is dev comments also it is in pending commit with the rest of the freya quests.
Then lock the topic or move to archived, don't leave me hanging like that! It was made in 2010 and ignored up until now even though "a different approach" was not committed! If that's not ignoring then I don't know what it is.UnAfraid wrote:viewtopic.php?f=43&t=19595 - I have patch for all village masters related to first class transfer its still not committed because it needs some more work.
Needs to be moved to Committed then.UnAfraid wrote:viewtopic.php?f=43&t=19463 - Already committed by malyelfik.
Someone should write that in the topic, tell them to merge it into a delusion chambers patch.UnAfraid wrote:viewtopic.php?f=55&t=21759 - We are missing delusion chambers at all, this should be committed with implementation of the delusions itself.
What's wrong with FBIagent's implementation?UnAfraid wrote:viewtopic.php?f=55&t=26463 - Suspicious file, as i said is missing author also pretty much like files from leaked private projects.
Still no response about the script in topic, even though it's one of your team members. Ask someone from the initiates/adv. users to check it maybe?UnAfraid wrote:viewtopic.php?f=55&t=26063 - No feedback, also i reviewed it a couple of times in skype.
Guess he should be reminded of it, it was shared when he wasn't an initiate.UnAfraid wrote:viewtopic.php?f=24&t=20861 - No feedback also the author can commit it when its ready to be committed.
Like i said, this could be committed until a better version comes out. It's nothing serious, but still. Or move it to Archived if you don't want to commit it so badly. Any action is better than none.UnAfraid wrote:viewtopic.php?f=24&t=27289 - Bani is working on it.