Page 1 of 1

Champs who are not champs

Posted: Mon Jul 27, 2009 2:08 pm
by Notorious
Sometimes, if not always, when a champion-mob respawns after its killed, it says it's a champion again, even if it's a normal mob.

Pretty annoying.

How do one go about to fix this?

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 2:23 pm
by janiii
revisions?

is this problem with normal mobs, or RB or minions?

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 4:14 pm
by Notorious
Ok, so you mean nobody else has this problem?
Ok, ok, will test on clean install then... Been like this for very long time for me, you see! :(

Get back to you.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 4:48 pm
by dip_bow
I think the following is aslo: a normal mob dies; if respawn at the next time champion will be, when he dies , his name is (for example) champion keltir instead of keltir (his name change but dead), then when it respawn is a champion, sorry if I was not clear .
I'm using google translator.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 4:50 pm
by Notorious
Clean install:

Core: 3321
DP: 6436

Tested by setting champ-spawnrate to 50%.
Only tested on normal mobs.

I wasn't sure before, but now I am. It goes both ways.
By that I mean that mobs shown as champs are sometimes not champs, and mobs shown as normal are sometimes champs.
The name changes when you hit them the first time, and the correct name is shown.
It's like it's cached and not updated until then...or something...

Seriously, am I the only one who noticed this, or is it a local problem?

If you find that it's my installation that is somehow faulty, even if it's a clean install, have you any idea where to find the problem and fix it?

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 4:57 pm
by janiii
there was such problem long ago and it was fixed. so, i don't understand that it is again bugged..

http://www.l2jserver.com/trac/changeset/2918

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 5:07 pm
by Notorious
Don't think it has to do with that actually. My guess is that that patch is working OK, and minions and RB's never becomes champs.
I think the problem is in AbstractNpcInfo.java, somewhere around here or connected to it:

Code: Select all

    public static class NpcInfo extends AbstractNpcInfo    {    	private L2Npc _npc;     	public NpcInfo(L2Npc cha, L2Character attacker)    	{    		super(cha);    		_npc = cha;    		_idTemplate = cha.getTemplate().idTemplate; // On every subclass    		_rhand = cha.getRightHandItem();  // On every subclass    		_lhand = cha.getLeftHandItem(); // On every subclass            _collisionHeight = cha.getCollisionHeight();// On every subclass            _collisionRadius = cha.getCollisionRadius();// On every subclass            _isAttackable = cha.isAutoAttackable(attacker);            if (cha.getTemplate().serverSideName)            	_name = cha.getTemplate().name;// On every subclass             if(Config.L2JMOD_CHAMPION_ENABLE && cha.isChampion())                _title = (Config.L2JMOD_CHAMP_TITLE); // On every subclass            else if (cha.getTemplate().serverSideTitle)        		_title = cha.getTemplate().title; // On every subclass        	else        		_title = cha.getTitle(); // On every subclass             if (Config.SHOW_NPC_LVL && _npc instanceof L2MonsterInstance)    	    {    			String t = "Lv " + cha.getLevel() + (cha.getAggroRange() > 0 ? "*" : "");    			if (_title != null)    				t += " " + _title;     			_title = t;    	    }    	} 
This is where the title is set. (I think! :) )

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 5:27 pm
by janiii
there was some changeset about it, where setting champ was moved from onSpawn to onDie or the other way, i dont remember anymore.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 5:32 pm
by Notorious
As I said, it's like it remembers the old name of the mob that was killed before, and uses that when the new spawns, but this is not always the correct name, and the correct name is shown after first hit on mob.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 5:58 pm
by toastgodsupreme
While I don't use titles, I use a different method to tag champ mobs. And this problem is not present.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 6:03 pm
by devo
True I had same issue. When champion is dead, and monster respawn, he have title "Champion" when I hit them, Champion title disappear and he is normal monster.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 6:04 pm
by janiii
toastgodsupreme wrote:While I don't use titles, I use a different method to tag champ mobs. And this problem is not present.
try to think how much helpful is your post..

like a kiddo: nyaah nyaaah, i have no problems, but i won't tell you :P i only tell you i am better :PPPPP

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 6:10 pm
by _DS_
Actually answer was given - problem somehow linked with client "remembering" old title.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 6:30 pm
by toastgodsupreme
janiii wrote:
toastgodsupreme wrote:While I don't use titles, I use a different method to tag champ mobs. And this problem is not present.
try to think how much helpful is your post..

like a kiddo: nyaah nyaaah, i have no problems, but i won't tell you :P i only tell you i am better :PPPPP
lol, not exactly. That's not what I was trying to say. I was explaining that I don't have the issue of my tagging method remaining, despite the fact that I don't use champ titles. But I felt that I should at least explain that I don't use the title system since it was relevant.

Thus if the problem IS present, then it is due directly to the fact that it's a title issue and how that's applied.

Re: Champs who are not champs

Posted: Mon Jul 27, 2009 6:36 pm
by janiii
sure.. without showing the title, there is no title problem. somehow logical. so still not helpful to solve problem when showing the title.