Page 1 of 1
Ticket 4120
Posted: Thu Sep 03, 2009 8:21 pm
by Gnacik
http://www.l2jserver.com/trac/ticket/4120
Some retail pictures :
Clan with flag:
Player without clan in range
Player without clan in range with flag
Attack on nonflaged player ofc i must press ctrl key
Re: Ticket 4120
Posted: Fri Sep 04, 2009 4:35 am
by _DS_
Results ? What should be changed ?
Re: Ticket 4120
Posted: Fri Sep 04, 2009 3:45 pm
by Probe
I think what he means is that it should only attack flagged\wartags in the zone area, and leave unflagged players unharmed.
instead, it's attacking all pcs\npcs in range, even if white.
Re: Ticket 4120
Posted: Fri Sep 04, 2009 4:24 pm
by Gnacik
Results ? What should be changed ?
Same situation on l2js - nonflaged player in range:
All Area skills (not only summon skills) but all area skills are giving damage to players non-flaged in range.
Im not sure how it works on official because on my 3 screen from official we can see that player
have a pvp flag but its
not affected by skill.
Re: Ticket 4120
Posted: Fri Sep 04, 2009 7:16 pm
by devo
seems its working in pvp only vs flaged with force skill use.
Re: Ticket 4120
Posted: Sat Sep 12, 2009 9:53 am
by Gnacik
Problem is that we call
Code: Select all
checkPvpSkill(L2Object target, L2Skill skill, boolean srcIsSummon)
with always srcIsSummon=false
Fix :
Code: Select all
Index: java/net/sf/l2j/gameserver/model/actor/L2Summon.java===================================================================--- java/net/sf/l2j/gameserver/model/actor/L2Summon.java (revision 1114)+++ java/net/sf/l2j/gameserver/model/actor/L2Summon.java (working copy)@@ -853,7 +868,7 @@ { final L2PcInstance actingPlayer = getActingPlayer(); - if (!actingPlayer.checkPvpSkill(getTarget(), skill)+ if (!actingPlayer.checkPvpSkill(getTarget(), skill, true) && !actingPlayer.getAccessLevel().allowPeaceAttack()) { // Send a System Message to the L2PcInstanceIndex: java/net/sf/l2j/gameserver/model/L2Skill.java===================================================================--- java/net/sf/l2j/gameserver/model/L2Skill.java (revision 1114)+++ java/net/sf/l2j/gameserver/model/L2Skill.java (working copy)@@ -2152,7 +2159,7 @@ if (player.getClanId() != 0 && player.getClanId() == targetPlayer.getClanId()) return false; - if (!player.checkPvpSkill(targetPlayer, skill))+ if (!player.checkPvpSkill(targetPlayer, skill, (caster instanceof L2Summon))) return false; } }
Re: Ticket 4120
Posted: Sat Sep 12, 2009 10:04 am
by _DS_
Yeah...
Test results ?
Re: Ticket 4120
Posted: Sat Sep 12, 2009 10:47 am
by Gnacik
skill usage working correctly.
without ctrl target_area summon skill attack only mobs, flaged players, war players
with ctrl attack all in range
but there is a little glitch. when i kill mob near some player and next target that player and try to cast skill (with and without ctrl) got "Your target cannot be foud". Its from
Code: Select all
L2Summon.java:688target = skill.getFirstOfTargetList(this);
probably. Im trying debug where problem is.
Re: Ticket 4120
Posted: Sat Sep 12, 2009 11:28 am
by Gnacik
setCurrentPetSkill() is used at end before setIntention(CtrlIntention.AI_INTENTION_CAST) thats why getFirstOfTargetList() is empty. Its called before skill set. Simple solution is move setCurrentPetSkill() to beginning in useMagic() but im not sure if its correct solution because we dont reset currentpetskill after cast.
