Page 1 of 2
kamael soulbreaker sub
Posted: Fri Sep 18, 2009 9:10 am
by janiii
l2guru says, that a male kamael takes a female soulbreaker as sub. female kamael takes male soulbreaker as sub.
http://www.l2guru.com/forum/showpost.ph ... stcount=88
l2j says: //Check sex, male can't subclass female and vice versa
what is the truth about kamael (soulbreaker) subs?
thx.
Re: kamael soulbreaker sub
Posted: Fri Sep 18, 2009 9:23 am
by toastgodsupreme
http://www.l2guru.com/forum/showthread.php?t=124756
I was confused about the same issue not too long ago, heh.
Re: kamael soulbreaker sub
Posted: Fri Sep 18, 2009 9:29 am
by janiii
thx tgs for info
l2j bug: male kamael subclasses male soulbreaker, female kamael subclasses female soulbreaker
fix: male kamael subclasses female sb, female kamael subclasses male sb
pls test. thx.
http://www.pastebin.cz/22956
Code: Select all
Index: java/net/sf/l2j/gameserver/model/base/PlayerClass.java===================================================================--- java/net/sf/l2j/gameserver/model/base/PlayerClass.java (revision 3298)+++ java/net/sf/l2j/gameserver/model/base/PlayerClass.java (working copy)@@ -288,11 +288,11 @@ { subclasses = getSet(Kamael, Third); subclasses.remove(this);- //Check sex, male can't subclass female and vice versa+ //Check sex, male subclasses female and vice versa if (player.getAppearance().getSex())+ subclasses.removeAll(EnumSet.of(femaleSoulbreaker));+ else subclasses.removeAll(EnumSet.of(maleSoulbreaker));- else- subclasses.removeAll(EnumSet.of(femaleSoulbreaker)); if (player.getTotalSubClasses() < 2) subclasses.removeAll(EnumSet.of(inspector)); }
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 1:29 am
by leanndr
hmm, this is the actual code
but when you add a soul breaker with male kamael, the text on the html is "female soulbreaker"
and the base stats, str, dex... are from female
i'm not in the level to fix this xP
well, well, now i've read better janii's post, if youre male, you can get female as sub, and if youre female, male as sub
oO
1 down, now the classmaster judicator :S (can I do it?! dont know)
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 10:03 am
by Edelvez
A male Soulbreaker can not take the subclass of women Soulbreaker ... For virtually the same class, with some changes in status and skills of first change
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 10:06 am
by jurchiks
don't bump a year old topic...
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 10:08 am
by Edelvez
Damn ... I did not realize <.<
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 10:09 am
by jurchiks
not you, the guy before you...
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 1:17 pm
by leanndr
sry for that XD
my fix for inspector/judicator on classmaster:
Code: Select all
### Eclipse Workspace Patch 1.0#P L2_GameServerIndex: java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java===================================================================--- java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java (revision 6)+++ java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java (working copy)@@ -420,7 +420,7 @@ */ private static final boolean validateClassId(ClassId oldCID, ClassId newCID) {- if (newCID == null || newCID.getRace() == null)+ if (newCID == null || newCID.getRace() == null || newCID.getId() == 135) return false; if (oldCID.equals(newCID.getParent()))
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 1:35 pm
by jurchiks
That should work
Thx
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 1:46 pm
by SolidSnake
Nice leanndr, but maybe with a config l2jserver will commit it
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 2:12 pm
by jurchiks
well, class changer is not a subclass manager so there shouldn't be a need for config...
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 2:34 pm
by SolidSnake
_DS_ wrote:Class masters are totally custom and designed for highrate pvp servers. Inspector just another kamael occupation. If you does not want it - correct the code.
So if there is a config maybe they commit it
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 3:56 pm
by leanndr
I think allowing inspector/judicator as main class can bring some bugs, like for olys
Re: kamael soulbreaker sub
Posted: Thu Nov 18, 2010 5:04 pm
by _DS_
Gnacik decided to correct it in the new release. Here is a changeset:
Code: Select all
Index: /trunk/L2J_Server_CT2.5/java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java===================================================================--- /trunk/L2J_Server_CT2.5/java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java (revision 5415)+++ /trunk/L2J_Server_CT2.5/java/com/l2jserver/gameserver/model/actor/instance/L2ClassMasterInstance.java (revision 5987)@@ -235,4 +235,6 @@ for (ClassId cid : ClassId.values()) {+ if (cid == ClassId.inspector && player.getTotalSubClasses() < 2)+ continue; if (validateClassId(currentClassId, cid) && cid.level() == level) {@@ -291,4 +293,6 @@ for (ClassId cid : ClassId.values()) {+ if (cid == ClassId.inspector && player.getTotalSubClasses() < 2)+ continue; if (validateClassId(currentClassId, cid)) {Index: /trunk/L2J_DataPack_CT2.5/sql/updates/20101111update.sql===================================================================--- /trunk/L2J_DataPack_CT2.5/sql/updates/20101111update.sql (revision 5987)+++ /trunk/L2J_DataPack_CT2.5/sql/updates/20101111update.sql (revision 5987)@@ -0,0 +1,1 @@+UPDATE `characters` SET `base_class`='126' WHERE `base_class` in (135,136);