Page 1 of 1

Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 12:21 am
by tropheo

Code: Select all

# Default: FalseAutoLearnSkills = True
If it's true it take the SP for skills?

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 2:11 am
by Pere
no

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 2:24 am
by tropheo
Some one have one patch for it?

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 2:31 am
by Charus
Patch for?

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 2:35 am
by tropheo
For "auto take" the SP of corresponding "auto skill"

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 6:25 am
by janiii
this isnt so easy done, because how should the system decide which skill to learn and which not to learn if player has not enough SP?

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 6:31 am
by Charus

Code: Select all

### Eclipse Workspace Patch 1.0#P L2JServerIndex: java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java===================================================================--- java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java	(revision 3695)+++ java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java	(working copy)@@ -2798,6 +2798,8 @@ 				}  				addSkill(sk, true);+				int spCost = SkillTreeTable.getInstance().getSkillCost(this, sk);+				removeExpAndSp(0, spCost, false); 			}  			// Get new available skills 
Check that, I didnt test it.

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 11:22 am
by _DS_
Useless - maybe player does not have enough SP but skill will be learned anyway.
Due to autolearn called on levelups only - imho removing SP is not possible in normal way. Or You will be forced to call autolearn on enterworld too.

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 11:33 am
by JIV
possible on each sp change, and learn only how much can.

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 12:43 pm
by Pere
but it maybe learns first the skills which the player is not interested in :mrgreen:

Useless and useless.

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 1:44 pm
by JIV
Then its better create skill learn support without npc, so player can learn new skills everywhere.

Re: Config AutoLearnSkills question

Posted: Wed Nov 25, 2009 2:15 pm
by tropheo
The players want auto learn skills for not need to take it manually (click on each skill and the accept)
But I think if auto learn skills not take SP this isn't good :/

Re: Config AutoLearnSkills question

Posted: Sun Nov 29, 2009 12:44 am
by LASF-7
Sounds interesting. These clicking orgies don't happen that often tho.

How about some sort of pre set Skill-Package like in NWN / NWN 2?
Let's say one has to talk to some NPC (that's placed next to the newbie helpers) after char creation and first login.
There the PC can select a skill package and his selection is stored in DB. If the DB contains a list of prioritized skills for each package the SP can be checked every now and then (or check is triggered by some command like //autoskill) and skills will be added according to the selected package while SP are reduced for the correct amount. (Including the factors that SP requirements are multiplied with if it comes to skills from other classes)

2nd option should be to disable the "autoskill" selection.
If skills are acquired manually by visiting a trainer, the prioritized list is not affected. If the PC learns a skill that's not a element of the sel. package and autoskilling wasn't active, then there will be less SP for autoskill feature. If any element of the package is learned before autoskilling took place - irrelevant. Can't be learned twice anyways.

But w/o predefined packages and manual selection of those the PC behaviour must be recorded and skills are added according to probability. I.e. a mage dealing more dam with weapons would be allocated fighter skills. That requires as well that there's a slow change of stats towards those of a fighter. Similar for fighters who decide to be casters.
After the most basic stuff has been learned all further weapon and spell skills should be assigned by taking into account what type of weapon were used (sword/dagger/pole...)or, for spells, what element (air, water, fire, etc. pp.) was the dominant one.

That's some really big pile of tedious work and debugging I think...
So I'll check this topic again in 2 days and get me the working patch for Server and DB. :P :lol:

...

*runs and hides*