Momo's Question Section ^_^

This is not a Support area! Discuss about the Server here. Non-Server related discussion goes in Off-Topic Discussion.
Forum rules
READ NOW: L2j Forums Rules of Conduct
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Momo's Question Section ^_^

Post by momo61 »

l2j Core: 3981
l2j DP: 7143

Very interesting rework. Some questions:

1)Why did you do this ? :)
2)There's no necessary database update for running servers?
3)Can someone do this kind of SQL query for this update >_>: ?

http://www.pastebin.cz/33616
Last edited by momo61 on Wed Mar 17, 2010 2:20 pm, edited 1 time in total.
User avatar
gigiikun
L2j Veteran
L2j Veteran
Posts: 637
Joined: Wed Jan 24, 2007 10:00 am
Location: Hungary

Re: Enchant Skill Tree rework

Post by gigiikun »

Sorry, did not write in commit comment that it REQUIRES DP change!

The only real change is that now enchant skill tree is generated from xml, so no need a huge and redundant enchant_skill_trees table.

It is easy to add this:
- stop server
- apply enchant_skill_groups.sql
- update data/stats/skills/XXXX-XXXX.xml files
- update server jar file
- start server
User avatar
gigiikun
L2j Veteran
L2j Veteran
Posts: 637
Joined: Wed Jan 24, 2007 10:00 am
Location: Hungary

Re: Enchant Skill Tree rework

Post by gigiikun »

3.
Create your own Enchant skill Group and in xml definition change default groups to that.
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Enchant Skill Tree rework

Post by momo61 »

gigiikun wrote:3.
Create your own Enchant skill Group and in xml definition change default groups to that.
why ? ... that means everytime I decide to update the server I need to modify XMLs... it's a pain in the ass ...

isnt there some other way? like simple SQL queries ?
User avatar
gigiikun
L2j Veteran
L2j Veteran
Posts: 637
Joined: Wed Jan 24, 2007 10:00 am
Location: Hungary

Re: Enchant Skill Tree rework

Post by gigiikun »

Than change only group table. We use now 1,2 group id.
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Enchant Skill Tree rework

Post by momo61 »

gigiikun wrote:Than change only group table. We use now 1,2 group id.
guess I need to write new SQL queries for this >_>

we dont need to modify anything on existing character_skills ?
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Enchant Skill Tree rework

Post by momo61 »

I dont want to open a new topic, so I'll post here:

http://www.l2jserver.com/trac/changeset/4007

Pet critical mod. What is it for? I don't really understand it's function
User avatar
Gnacik
L2j Veteran
L2j Veteran
Posts: 925
Joined: Tue Dec 16, 2008 3:49 pm
Location: Wąchock ٩(̾●̮̮̃̾•̃̾)۶ Polska
Contact:

Re: Enchant Skill Tree rework

Post by Gnacik »

Try cast some buffs on pet which are increasing critical rate (focus and similar) without that changeset and you understand ;)
ps. you should rename that topic to 'momo's questions' or smth ;)
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Enchant Skill Tree rework

Post by momo61 »

Gnacik wrote:Try cast some buffs on pet which are increasing critical rate (focus and similar) without that changeset and you understand ;)
ps. you should rename that topic to 'momo's questions' or smth ;)
good idea ^^

let me see what happens if i cast those buffs on my pet.

Edit: Tested it. Seems like the pets don't get any stats change with those buffs..
User avatar
Gnacik
L2j Veteran
L2j Veteran
Posts: 925
Joined: Tue Dec 16, 2008 3:49 pm
Location: Wąchock ٩(̾●̮̮̃̾•̃̾)۶ Polska
Contact:

Re: Momo's Question Section ^_^

Post by Gnacik »

yes. right. and that problem is fixed in JiV's patch. :)
User avatar
Pere
Posts: 400
Joined: Sat Jan 05, 2008 11:09 am
Location: Catalunya, Berguedà

Re: Enchant Skill Tree rework

Post by Pere »

momo61 wrote:isnt there some other way? like simple SQL queries ?
On EnchantSkillGroups.java:

Code: Select all

public L2EnchantSkillGroup getEnchantSkillGroupById(int id){	if (Config.USE_OLD_SKILL_GROUP) //add this line		return _enchantSkillGroups.get(30); //and this ;)	return _enchantSkillGroups.get(id);}
I hope you know how to create configs...
Bones tardes amics meus tots!
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Enchant Skill Tree rework

Post by momo61 »

Migi wrote:
momo61 wrote:isnt there some other way? like simple SQL queries ?
On EnchantSkillGroups.java:

Code: Select all

public L2EnchantSkillGroup getEnchantSkillGroupById(int id){	if (Config.USE_OLD_SKILL_GROUP) //add this line		return _enchantSkillGroups.get(30); //and this ;)	return _enchantSkillGroups.get(id);}
I hope you know how to create configs...
I already did SQL queries
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Momo's Question Section ^_^

Post by momo61 »

http://www.l2jserver.com/trac/changeset/4016

what was wrong with the castle warehouses before that?
lion
L2j Veteran
L2j Veteran
Posts: 967
Joined: Sun Mar 11, 2007 7:49 pm
Location: Ukraine

Re: Momo's Question Section ^_^

Post by lion »

may be they not work? and this patch fix a bug :mrgreen:
User avatar
momo61
Posts: 1648
Joined: Fri Jun 06, 2008 2:05 pm
Location: Europe

Re: Momo's Question Section ^_^

Post by momo61 »

Is there a reason why Doombringers do extreme high crit damage with bows on practically anyone ? They even outdamage archers by 2-3k damage (fully buffed).

what's a way to lower their bow-damage-power?
Post Reply