Page 1 of 1

Inheritance? L2Character?

Posted: Tue Sep 21, 2010 7:56 pm
by Phantom2005
Please take a good look at the inheritance of some actors..
Atm L2Character is a mess inheritance-wise if you ask me.

I'll just give one of the many examples..
So if someone is bored @ l2j team he could do it.

Or just add me on msn and I'll help :mrgreen:

Code: Select all

     //L2Character    public void setIsRunning(boolean value)    {        _isRunning = value;        if (getRunSpeed() != 0)            broadcastPacket(new ChangeMoveType(this));    }     // L2PcInstance    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        this.broadcastUserInfo();    }     // L2Summon    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        this.broadcastStatusUpdate();    }     // L2Npc    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        Collection<L2PcInstance> plrs = getKnownList().getKnownPlayers().values();        //synchronized (character.getKnownList().getKnownPlayers())        {            for (L2PcInstance player : plrs)            {                if (player == null)                    continue;                                if (getRunSpeed() == 0)                    player.sendPacket(new ServerObjectInfo((L2Npc) this, player));                else                    player.sendPacket(new AbstractNpcInfo.NpcInfo((L2Npc) this, player));            }        }    } 

Re: Inheritance? L2Character?

Posted: Tue Sep 21, 2010 8:39 pm
by hope
Just write a fixed patch and upload

Re: Inheritance? L2Character?

Posted: Tue Sep 21, 2010 8:49 pm
by Phantom2005
I doubt it will match with the upcoming new Freya files.

Re: Inheritance? L2Character?

Posted: Tue Sep 21, 2010 10:57 pm
by hope
Then wait for new files and see if they need many work

Re: Inheritance? L2Character?

Posted: Wed Sep 22, 2010 9:45 am
by _DS_
Peoples on forum always cry about features, features and features. So you will get only features. Things like this did only on dev's inspirations and if we have enough time.

Re: Inheritance? L2Character?

Posted: Wed May 15, 2013 9:35 pm
by Zoey76

Re: Inheritance? L2Character?

Posted: Thu May 16, 2013 9:26 am
by Szponiasty
Yeah. Similar with eg isAttackingNow(), that for everything returns true if char is during attack (hit), and for summons/pets it returns isInCombat (stance) :)

Re: Inheritance? L2Character?

Posted: Thu Jun 20, 2013 11:36 pm
by gmexid
seems to be working correctly now