Page 1 of 2
BETA & BoneCP
Posted: Fri Sep 02, 2011 4:55 pm
by momo61
I remember 5 months ago, the inner circle decided to revert the public svn release of the BoneCP change and the removal of c3p0. I talked to a professional java coder who has nothing in common with l2 or l2j or games, and he told me after looking at the l2j source code, that c3p0 should not be used.
Since BETA is used in order to test things, shouldn't bonecp also replace c3p0 for testing, so you can get your much desired results?
+1 to UnAfraid.
Re: BETA & BoneCP
Posted: Fri Sep 02, 2011 4:58 pm
by lion
you can use this changes by self on live server, and after few month give feedback
BETA it's not "commit all to svn", it's only prepare to stable h5
Re: BETA & BoneCP
Posted: Fri Sep 02, 2011 5:24 pm
by momo61
Well some have used it for many months, and they didnt notice any downside to it. Why not committ it to BETA knowing it probably will only benefit, and if you dont like it for some reasons, then you could always revert to the dead c3p0 project
Re: BETA & BoneCP
Posted: Fri Sep 02, 2011 5:45 pm
by JMD
I have seen other forks having both and let the user select wich one they wanna use but its always up to the team, and if the team doesnt want to change it doesnt matter (to me at least).
Re: BETA & BoneCP
Posted: Fri Sep 02, 2011 6:53 pm
by Tryskell
JMD wrote:I have seen other forks having both and let the user select wich one they wanna use but its always up to the team, and if the team doesnt want to change it doesnt matter (to me at least).
The only fork I know giving the choice to user to select between both poolers is L2JFrozen, and their current implementation is a fail (and it's why they let users choose).
So far, the first project implementing it was L2Emu (haven't proofs it's the first). Following L2J manners, it shouldn't even been commited as "you can share only stuff you write", lol... (That was for the fun part.)
Anyway as lion said, it needs time to be tested, and (as always) people testing good things never share their appreciations, you have to test yourself and do your own benchmarks on a populated server.
Re: BETA & BoneCP
Posted: Sun Sep 04, 2011 4:13 pm
by Aikimaniac
momo61 wrote:I remember 5 months ago, the inner circle decided to revert the public svn release of the BoneCP change and the removal of c3p0. I talked to a professional java coder who has nothing in common with l2 or l2j or games, and he told me after looking at the l2j source code, that c3p0 should not be used.
Since BETA is used in order to test things, shouldn't bonecp also replace c3p0 for testing, so you can get your much desired results?
+1 to UnAfraid.
im pretty sure that the part about "professional java coder" who looked into l2j source is just bullshit and lie and if you will use it...do all needed changes by your own.
Re: BETA & BoneCP
Posted: Sun Sep 04, 2011 4:56 pm
by BiggBoss
if such friend of yours is so awesome coder, why dont you ask him to code you a better server? You both could even set up a forum and go there!
Re: BETA & BoneCP
Posted: Mon Sep 05, 2011 9:49 am
by momo61
ohh this hostility. I love it.
Re: BETA & BoneCP
Posted: Fri Sep 09, 2011 8:02 pm
by Tryskell
Question of momo61 is regular and not even offending by any way, what's the point to attack him when you're currently are wrong ? Stop being cocky.
No tests have been made so far (or if they have been made, that's on your private projects), when unAfraid made effectively an error to commit it without benchmarking it, 5 months are gone and you did nothing to answer (publicly) the question.
Is it the fact someone coded before you made you angry and reject it (as my reworked hotsprings IA) ? Sometimes you have to bow down and admit you have to copy paste. L2J is currently glued with that stupid spirit. What do you expect, inventing wheel a second time ? Doing only unique stuff ? That's stupid and make lose a precious time (as you know chronicles go fast to launch).
I'm not L2Emu fan (as I based my own IL pack on L2J IL, and followed L2J Freya then current unstable hi5 to refactor it), but sometimes, you have to stop saying bs and be more friendly.
Even if the "pro java dev" is a lie... That's not the interesting part of the topic. Remove fingers of your cocky ass, and give a decent developer answer "yes it is good because... / no it sux because...".
Re: BETA & BoneCP
Posted: Thu Sep 15, 2011 1:28 pm
by BiggBoss
why do you post something like that w/o knowing what and how things are done here?
Re: BETA & BoneCP
Posted: Mon Sep 19, 2011 2:44 pm
by Tryskell
If by "w/o knowing what and how things are done here", you mean ganking people saying "they're ridiculous/gtfo/do that on your own pack", yeah, I don't get it and I don't want to know it.
Just don't aggress ppl, ffs. Added to that, you got no materials to actually make a fun from momo's ask.
You can be talented, that doesn't mean you have to be cocky (Aikimaniac should take some lessons too).
Just give him a correct answer, or don't answer. That's the point of my message. If it's in test, say it's under test on private trunk. If it's given up, say it, and say why. Simple, no ?
Re: BETA & BoneCP
Posted: Mon Sep 19, 2011 4:51 pm
by mrTJO
Currently, there're no intentions to reimplement bonecp.
If I remember correctly, bonecp where removed because some devs reported issues.
Re: BETA & BoneCP
Posted: Mon Sep 19, 2011 5:41 pm
by momo61
mrTJO wrote:Currently, there're no intentions to reimplement bonecp.
If I remember correctly, bonecp where removed because some devs reported issues.
Alright then. Thanks for the answer.
Re: BETA & BoneCP
Posted: Wed Oct 19, 2011 2:30 pm
by Onepamopa
I've had troubles with bonecp as well and reported them to l2j devs.
I don't exactly know why the problems occured, maybe because my db is HUGE, or maybe due to the bonecp implementation - I cant say for sure. Currently using c3p0 and happy with it.
Maybe devs can give some hints as to why the problems occur.
Re: BETA & BoneCP
Posted: Thu Oct 20, 2011 3:13 pm
by BiggBoss
Tryskell wrote:If by "w/o knowing what and how things are done here", you mean ganking people saying "they're ridiculous/gtfo/do that on your own pack", yeah, I don't get it and I don't want to know it.
Just don't aggress ppl, ffs. Added to that, you got no materials to actually make a fun from momo's ask.
You can be talented, that doesn't mean you have to be cocky (Aikimaniac should take some lessons too).
Just give him a correct answer, or don't answer. That's the point of my message. If it's in test, say it's under test on private trunk. If it's given up, say it, and say why. Simple, no ?
yea, you mainly have no fucking idea about this. bonecp were alredy discussed and refussed, he opened another post for the same reason, without taking any performance feedback, to change it for c3p0.
Maybe is you the one who should take lessons about not talk from what you have no idea

?