Page 1 of 3

Splitting login and game server poll.

Posted: Wed May 16, 2012 10:31 pm
by Zoey76
Post here what do you think about having Login server and Game server in different projects.

Please vote.

Re: Splitting login and game server poll.

Posted: Wed May 16, 2012 10:42 pm
by Konstantinos
i have vote but what is better if we do that. thanks.

Re: Splitting login and game server poll.

Posted: Wed May 16, 2012 11:11 pm
by MELERIX
+10000000000000~
Konstantinos wrote:i have vote but what is better if we do that. thanks.
basically to maintain a order of the projects in their respective locations...

- Login Server.
- Community Server.
- Game Server.

Re: Splitting login and game server poll.

Posted: Thu May 17, 2012 11:55 am
by jurchiks
most advanced l2j forks have had that for a long time, dunno why l2j doesn't...
It should be mentioned though that if you split it, perhaps it would be worth considering consolidating all chronicles in the code, so that changing a single config variable would change the chronicle the loginserver works with. I know people have done this before (and not just l2j), so it's possible and shouldn't be too much hassle.

Re: Splitting login and game server poll.

Posted: Thu May 17, 2012 7:43 pm
by MELERIX
one login to rule them all xD

Re: Splitting login and game server poll.

Posted: Fri May 18, 2012 12:49 pm
by UnAfraid
I've separated login from game server long ago for my live server but here other devs didn't agreed to be committed because you must checkout many projects to setup a server.

Re: Splitting login and game server poll.

Posted: Sat May 19, 2012 7:57 pm
by Zoey76
UnAfraid wrote:I've separated login from game server long ago for my live server but here other devs didn't agreed to be committed because you must checkout many projects to setup a server.
Well is not like you have to checkout Login server every day/week as is with Game server.

I always liked the idea, but wasn't agree at the moment because I didn't have the time to support it.

I have a draft done at the moment, it has been tested locally, if anyone is interested on test it on live let me know.

If it doesn't work you only have to close it and start old implementation (hopefully I'll get some feedback :P ).

Re: Splitting login and game server poll.

Posted: Sun May 20, 2012 2:45 am
by burrito
MELERIX wrote:+10000000000000~
Konstantinos wrote:i have vote but what is better if we do that. thanks.
basically to maintain a order of the projects in their respective locations...

- Login Server.
- Community Server.
- Game Server.
I was wondering if there was anymore benefits to separating them, yes i agree it would be more organized etc, but is there anything else to it then that someone can give their opinion about?

Re: Splitting login and game server poll.

Posted: Sun May 20, 2012 2:46 am
by nonom
Voted, I'm waiting to checkout :D

Re: Splitting login and game server poll.

Posted: Sun May 20, 2012 3:08 am
by Zoey76
Cleaner and improved code, real independence between login and game server, one login for "all chronicles", etc.

Re: Splitting login and game server poll.

Posted: Sun May 20, 2012 3:09 am
by nonom
MELERIX wrote:one login to rule them all xD
Sounds Epic :mrgreen:

Re: Splitting login and game server poll.

Posted: Thu May 24, 2012 2:43 pm
by Battlecruiser
yeah, I expect better maintenance form this

Re: Splitting login and game server poll.

Posted: Sun May 27, 2012 1:02 pm
by JMD
I really dont care about this, as long as it works im good with it. :|

Re: Splitting login and game server poll.

Posted: Mon May 28, 2012 3:53 pm
by Tryskell
If you speak of content of l2jserver.jar, nothing special will go from it, except better organization and size of .jar itself.

Opcodes still need to be changed from one chronicle to another, and there's no performance gain splitting both "projects".

So "okay", do it if you got nothing else to do better :D.

Re: Splitting login and game server poll.

Posted: Mon May 28, 2012 4:04 pm
by jurchiks
@Tryskell - you could just change the LS chronicle via config, all opcodes would be already inside. I see only gain from this; the code wouldn't have to double for every new chronicle/throne branch, instead you would only need one well-maintained loginserver project (well, it should be in the core trunk, not a real branch or a separate project obviously).