Page 1 of 1

Changeset 5512

Posted: Tue Jul 17, 2012 6:01 pm
by antons007
clientpackets/TradeRequest.java

Code: Select all

 -60                     if (target == null || !player.getKnownList().knowsObject(target) || !(target instanceof L2PcInstance)) +61                 if ((target == null) || !player.getKnownList().knowsObject(target) || ((target.getInstanceId() != player.getInstanceId()) && (player.getInstanceId() != -1)))  
point of this (((target.getInstanceId() != player.getInstanceId()) && (player.getInstanceId() != -1))) if its already here?

Code: Select all

 package com.l2jserver.gameserver.model.actor.knownlist; public class ObjectKnownList{    public boolean addKnownObject(L2Object object)    {        // Instance -1 is for GMs that can see everything on all instances        if (getActiveObject().getInstanceId() != -1 && (object.getInstanceId() != getActiveObject().getInstanceId()))            return false;    }} 

Re: Changeset 5512

Posted: Tue Jul 17, 2012 9:25 pm
by Zoey76
It was there already, I just re-wrote it.

At moment seems useless, but if kown list implementation changes, it could be useful.

If you want you can remove it, also you can share the diff.