Better db connection pool?
Forum rules
READ NOW: L2j Forums Rules of Conduct
READ NOW: L2j Forums Rules of Conduct
- jurchiks
- Posts: 6769
- Joined: Sat Sep 19, 2009 4:16 pm
- Location: Eastern Europe
Better db connection pool?
Saw this posted on aCis:
https://github.com/brettwooldridge/HikariCP
Seems like a serious project, in active development, good documentation... Worth a try IMHO.
https://github.com/brettwooldridge/HikariCP
Seems like a serious project, in active development, good documentation... Worth a try IMHO.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
-
- Posts: 279
- Joined: Thu Dec 27, 2012 8:35 am
- Location: Georgia, Tbilisi
Re: Better db connection pool?
Interesting
-
- L2j Veteran
- Posts: 967
- Joined: Sun Mar 11, 2007 7:49 pm
- Location: Ukraine
- Pandragon
- Posts: 704
- Joined: Tue Jul 26, 2005 7:38 pm
Re: Better db connection pool?
The benchmark seems amazing, but will it really make any notable difference?
-
- L2j Veteran
- Posts: 314
- Joined: Mon Mar 11, 2013 4:19 pm
Re: Better db connection pool?
Well i have tested it some months ago it had some bugs so we decided c3p0 is better for now maybe if project matures a bit we can switch.
- Zoey76
- L2j Inner Circle
- Posts: 7005
- Joined: Tue Aug 11, 2009 3:36 am
Re: Better db connection pool?
C3p0 is active and I know some of the developers, it's not bleeding edge tech, but it's very robust, we could make core to accept different pool managers
Powered by Eclipse 4.30 | Eclipse Temurin 21 | MariaDB 11.3.2 | L2J Server 2.6.3.0 - High Five
Join our Discord!
Join our Discord!
- jurchiks
- Posts: 6769
- Joined: Sat Sep 19, 2009 4:16 pm
- Location: Eastern Europe
Re: Better db connection pool?
Well, aside from the bugs in HikariCP (what kind of bugs anyway? maybe they're really minor?), c3p0 can't compare in performance. If we don't use it, adding support for it would be good for those who want to experiment, and for possible future switch.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
-
- L2j Veteran
- Posts: 314
- Joined: Mon Mar 11, 2013 4:19 pm
Re: Better db connection pool?
It had poor error reporting some SQL exceptions were getting hidden(related to connection and retry) also some configs were not doing what they were described to or were half working.jurchiks wrote:Well, aside from the bugs in HikariCP (what kind of bugs anyway? maybe they're really minor?), c3p0 can't compare in performance. If we don't use it, adding support for it would be good for those who want to experiment, and for possible future switch.
- Zoey76
- L2j Inner Circle
- Posts: 7005
- Joined: Tue Aug 11, 2009 3:36 am
Re: Better db connection pool?
Nos wrote:also some configs were not doing what they were described to or were half working.
So like L2j
Powered by Eclipse 4.30 | Eclipse Temurin 21 | MariaDB 11.3.2 | L2J Server 2.6.3.0 - High Five
Join our Discord!
Join our Discord!
- jurchiks
- Posts: 6769
- Joined: Sat Sep 19, 2009 4:16 pm
- Location: Eastern Europe
Re: Better db connection pool?
Aaand that is terrible because? Sounds like minor issues that can be fixed in a jiffy. Contributing config renames is easy, that should be accepted pretty quickly. The error reporting thing also shouldn't be a problem if you can argumentate your reasoning properly.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
- Battlecruiser
- L2j Veteran
- Posts: 332
- Joined: Thu May 01, 2008 9:44 am
Re: Better db connection pool?
especially drop onesZoey76 wrote:Nos wrote:also some configs were not doing what they were described to or were half working.
So like L2j
Git user
-
- Posts: 279
- Joined: Thu Dec 27, 2012 8:35 am
- Location: Georgia, Tbilisi
Re: Better db connection pool?
can anyone make diff patch to test HikariCp ?
- Zoey76
- L2j Inner Circle
- Posts: 7005
- Joined: Tue Aug 11, 2009 3:36 am
Re: Better db connection pool?
Not sure if better, but as promised https://github.com/L2J/L2J_Server/tree/ ... ionFactory
Powered by Eclipse 4.30 | Eclipse Temurin 21 | MariaDB 11.3.2 | L2J Server 2.6.3.0 - High Five
Join our Discord!
Join our Discord!
- St3eT
- Posts: 961
- Joined: Sun Mar 07, 2010 6:50 pm
Re: Better db connection pool?
I like those graphs which every project have almost same just as main actor is their project. Anyway those projects looks nice in testing phase and on live with lot of ppl starting real fun.
- Zoey76
- L2j Inner Circle
- Posts: 7005
- Joined: Tue Aug 11, 2009 3:36 am
Re: Better db connection pool?
Sdw, UnAfraid and you said the same, I guess you didn't used it properly, since I used it on an application that get hit by 500 transactions per second all of them with database access and it performed well after proper configuration.St3eT wrote:I like those graphs which every project have almost same just as main actor is their project. Anyway those projects looks nice in testing phase and on live with lot of ppl starting real fun.
Powered by Eclipse 4.30 | Eclipse Temurin 21 | MariaDB 11.3.2 | L2J Server 2.6.3.0 - High Five
Join our Discord!
Join our Discord!