[L2j] Updating trunk!

[Zoey76]

The trunk has been updated with the latests changes from the past 4 months.

After the hard work of many developers and contributors we have synchronized all the changes in beta branch to the trunk.

[Zoey76]

SPOILER:

r5460 | MELERIX | 2012-06-27 19:10:41

BETA/LIB: ECJ Lib Update.
----------------------------------------------------------------------------
r5459 | MELERIX | 2012-06-27 19:05:32

BETA/COMMUNITY/LIBS: Builders Updates.
----------------------------------------------------------------------------
r5458 | Adry_85 | 2012-06-26 07:29:59

BETA: Fixed sps behaviour when using potions while casting magic skills. Thanks '''MELERIX''' for help.
----------------------------------------------------------------------------
r5457 | Zoey76 | 2012-06-24 20:13:15

BETA: Reusing "Get Heros" SQL related code.
* Some other minor fixes.
----------------------------------------------------------------------------
r5455 | MELERIX | 2012-06-23 23:15:20

BETA: Cleanup.
----------------------------------------------------------------------------
r5454 | Zoey76 | 2012-06-23 22:05:44

BETA: Refactored Quest item get related code to avoid duplicated code.
----------------------------------------------------------------------------
r5453 | Zoey76 | 2012-06-23 21:33:47

BETA: Adding L2Tower abstract class to manage common methods to L2FlameTowerInstance and L2ControlTowerInstance.
* Making the code more abstract reduce the code to maintain and improves the chances of spotting bugs.
* Following change sets will be about this kind of code refactoring (except bug fixes ).
----------------------------------------------------------------------------
r5452 | MELERIX | 2012-06-23 21:26:48

BETA: Sorry I forgot credits for Tryskell in [5451].

now let's split this files too.
----------------------------------------------------------------------------
r5451 | MELERIX | 2012-06-23 21:15:43

BETA: Attacked players in craft/shops stand up.
----------------------------------------------------------------------------
r5450 | Zoey76 | 2012-06-23 20:52:29

BETA: Refactoring SystemMessageId and NpcStringId to reuse parameter related classes:
* Many thanks to MELERIX for testing it in-game.
* Changed Builder from interface to abstract class, so it can contain newBuilder(String) method.
----------------------------------------------------------------------------
r5449 | Zoey76 | 2012-06-22 17:56:14

BETA: Removed some SuppressWarnings annotations that are hiding possible problems:
* Removed some unused variables and methods.
* Added some serialVersionUID.
----------------------------------------------------------------------------
r5448 | MELERIX | 2012-06-22 03:01:56
----------------------------------------------------------------------------
r5447 | MELERIX | 2012-06-22 02:49:39

COMMUNITY/BETA: Changed c3p0 Logging level to WARNING.
----------------------------------------------------------------------------
r5446 | MELERIX | 2012-06-22 02:16:37

COMMUNITY/BETA: C3P0 Lib Update.
----------------------------------------------------------------------------
r5445 | Zoey76 | 2012-06-20 23:34:36

BETA: Fix for Armor Sets and Henna bonuses not working on first player login:
* Thanks FinalDestination and Adry_85 for reports.
* Thanks MELERIX for testing.
* Minor formatting.
----------------------------------------------------------------------------
r5444 | Adry_85 | 2012-06-20 16:59:35

BETA: Fixed NPE for isSpiritShotCharged and isBlessedSpiritshotCharged. Thanks '''MELERIX''' for help.
----------------------------------------------------------------------------
r5443 | MELERIX | 2012-06-20 16:24:03

BETA: Offensive Magic Skills should trigger EVT_ATTACKED_HIT.
----------------------------------------------------------------------------
r5442 | Adry_85 | 2012-06-19 15:53:38

BETA: The rest of [5441] (now for hair accesories).
----------------------------------------------------------------------------
r5441 | Adry_85 | 2012-06-19 10:06:40

BETA: Fixed cloak visualization when you left-click on the item.
----------------------------------------------------------------------------
r5440 | MELERIX | 2012-06-18 21:25:06

BETA/COMMUNITY/LIBS: Minor update for builders.
----------------------------------------------------------------------------
r5439 | Adry_85 | 2012-06-18 18:40:17

BETA: Improved sps/bsps behavior.
- Unhardcoded switch code for soulshot, spiritshot and blessed spiritshot and deleted redundant code.
- Avoiding some "instanceof" where it's possible.

Thanks '''MELERIX''', '''UnAfraid''' and '''Zoey76''' for help.
----------------------------------------------------------------------------
r5438 | Zoey76 | 2012-06-17 19:07:13

BETA: Fix for "oncrit" and "oncast" item skills not performing skill casting checks.
* Now default oncrit_chance and oncast_chance is 100.
* If the parameter is not set in the item, the skill will be called every time there is a critical hit/magic skill usage.
* Chance lesser than or equal to zero will completely prevent the skill call.
* Reworked some weird code.
* Fixes Infinity Rod healing monsters, thanks goncafa and Tavo22 for report.
----------------------------------------------------------------------------
r5437 | Zoey76 | 2012-06-17 15:16:32

BETA: Minor fix in logic at doDie(..):
* Thanks Starter for report and fix.
* This should keep the same logic as it was before [4662].
----------------------------------------------------------------------------
r5436 | MELERIX | 2012-06-16 19:19:34

BETA: Removed '''"passive"''' boolean from passive effects (now it will check if skill is passive), thanks '''Zoey76''' & '''Adry_85''' for help.
----------------------------------------------------------------------------
r5435 | Zoey76 | 2012-06-16 18:22:47

BETA: RequestJoinParty NPE vulnerability fix, thanks Tavo22 for report.
* Fixed typo in JavaDocs, thanks jurchiks for report and proper JavaDoc text.
----------------------------------------------------------------------------
r5434 | Zoey76 | 2012-06-16 16:04:13

BETA: Fix for cubics being removed at olympiad:
* Thanks Endrance and Tavo22 for report.
* Closing #DP5305
* Thanks Tavo22 for testing.

----------------------------------------------------------------------------
r5433 | Zoey76 | 2012-06-16 00:08:54

BETA: Pet food rework:
* RequestPetUseItem cleanup.
* Added method isServitor()
* L2Object cleanup.
* Unhardcoding food Ids at PetDataTable.
* Fixed duplicated consume of food when used from pet's inventory (not auto-feed).
----------------------------------------------------------------------------
r5432 | Zoey76 | 2012-06-15 21:48:12

BETA: Minor cleanup for [5431].
----------------------------------------------------------------------------
r5431 | Zoey76 | 2012-06-15 21:46:24

BETA: Reworked Harvesting skill to use an effect (as it does in retail).
* Fixed few typos in skill parameters.
* Removed skill type.
* Minor rework in the code.
----------------------------------------------------------------------------
r5430 | MELERIX | 2012-06-14 19:47:20

BETA: Typo fix.
----------------------------------------------------------------------------
r5429 | MELERIX | 2012-06-14 14:04:57

BETA: Support for "equip_reuse_delay".
----------------------------------------------------------------------------
r5428 | GodKratos | 2012-06-13 22:53:35

BETA: Fix doors being created dead raised in forum topic viewtopic.php?f=77&t=25566
----------------------------------------------------------------------------
r5427 | Zoey76 | 2012-06-13 22:25:43

BETA: Reworking quest's reentrant lock usage:
* Fixing reload quest (scripts) problem, thanks DareStrike for report.
* Minor improvements in quest timers.

----------------------------------------------------------------------------
r5426 | Zoey76 | 2012-06-13 20:39:47

BETA: Fixing some log typos.
----------------------------------------------------------------------------
r5425 | MELERIX | 2012-06-13 15:29:36

BETA: Removed (setLocz() + 20) because it cause NPCs spawn in wrong places when geodata is enabled (for example Core GrandBoss).
----------------------------------------------------------------------------
r5424 | Zoey76 | 2012-06-12 21:55:26

BETA: Minor typo fix, thanks Tavo22 for report.
----------------------------------------------------------------------------
r5423 | Zoey76 | 2012-06-12 18:53:17

BETA: Fix for "Error in FightModeScheduler":
* Thanks Edoo, _Blade_, u3games, Lupu1, Starter, franpisco for report.
* Thanks atp for testing.
----------------------------------------------------------------------------
r5422 | Zoey76 | 2012-06-12 16:23:20

BETA: Fix for Quests:
* Thanks goncafa, kostantinos and Tavo22 for report.
* Closing #6199
* Thanks FBIagent for fix implementations and comments.
* Thanks jurchiks for the code improvement and code suggestions.
----------------------------------------------------------------------------
r5421 | Zoey76 | 2012-06-12 15:37:27

BETA: Minor fixes and optimizations:
* Duplicated properties.
* Math.ceil(double) for int parameter.
* Replaced String.append(String) with String.append(char) for one lenght strings.
----------------------------------------------------------------------------
r5420 | Zoey76 | 2012-06-10 22:18:44

BETA: Update for core read-me file by FBIagent.
----------------------------------------------------------------------------
r5419 | Zoey76 | 2012-06-10 22:09:50

BETA: Other changes.
----------------------------------------------------------------------------
r5418 | Zoey76 | 2012-06-10 22:00:42

BETA: Other minor changes.
----------------------------------------------------------------------------
r5417 | MELERIX | 2012-06-10 20:10:31

BETA: Minor Fix for [5412], thanks '''Tavo22'''.
----------------------------------------------------------------------------
r5416 | UnAfraid | 2012-06-09 19:09:06

BETA: TerritoryWarManager thread-safe
----------------------------------------------------------------------------
r5415 | UnAfraid | 2012-06-09 19:04:16

BETA: Minor fix for [5392]
----------------------------------------------------------------------------
r5414 | MELERIX | 2012-06-09 18:58:31

BETA: Fix for Ticket #4887.
----------------------------------------------------------------------------
r5413 | Adry_85 | 2012-06-09 10:07:51

BETA: Fixed mReuse and pReuse formulas.
----------------------------------------------------------------------------
r5412 | MELERIX | 2012-06-08 22:12:04

BETA: Unhardcoded and Improved Fishing Monsters by '''nonom'''.
----------------------------------------------------------------------------
r5411 | Adry_85 | 2012-06-07 11:41:25
----------------------------------------------------------------------------
r5410 | Adry_85 | 2012-06-07 11:22:44

BETA: Retail-like Support for Weight Limit and Weight Penalty
* Using Retail-Like formula for max weight limit.
* Added new effect weightPenalty to calculate point at which a weight penalty is applied.
* Updated effect maxLoad now called weightPenalty.
* Removed _LOAD field from char_templates.sql.
* Now each Character will have proper weightLimit depending of CON amount.

Thanks '''MELERIX''', '''UnAfraid''' and '''Zoey76''' for help.
----------------------------------------------------------------------------
r5409 | UnAfraid | 2012-06-07 10:42:56

BETA: Some npe fixes
----------------------------------------------------------------------------
r5408 | UnAfraid | 2012-06-07 10:39:38

BETA: L2TradeList is now thread-safe thanks Tavo22 for report.
----------------------------------------------------------------------------
r5407 | MELERIX | 2012-06-07 10:07:03

BETA: Fixed BeanShellEngine lib.
----------------------------------------------------------------------------
r5404 | UnAfraid | 2012-06-05 21:24:19

[BETA] Little typo fix.
----------------------------------------------------------------------------
r5402 | MELERIX | 2012-06-05 01:14:48

BETA: Re-Added switch part for [5394].
----------------------------------------------------------------------------
r5401 | Zoey76 | 2012-06-04 23:11:51

BETA: .classpath format.

'''Note:''' Do not forget to cleanup your server lib folder!
----------------------------------------------------------------------------
r5400 | Zoey76 | 2012-06-04 23:08:26

BETA: The compiled libraries for core.
----------------------------------------------------------------------------
r5397 | MELERIX | 2012-06-04 13:30:19
----------------------------------------------------------------------------
r5396 | MELERIX | 2012-06-04 13:27:14

BETA: Fix for Ticket #5510.
----------------------------------------------------------------------------
r5395 | MELERIX | 2012-06-04 10:40:59

BETA: Fix for RecipeController.java (with Zoey76's Improvements).
----------------------------------------------------------------------------
r5394 | Adry_85 | 2012-06-03 06:07:08

BETA: Retail-Like isMagic Support
* Using Retail-Like enums for isMagic.
* Now all Magic Skills will consume SPS/BSPS by default.
* Fixed Cast Time bonus for SPS/BSPS.
* Updated isMagic values for all skills (thx '''UnAfraid''').
* Removed isPotion & staticHitTime boolean from skills (skills with isMagic = 2 will have staticReuse & staticHitTime by default).
* Removed isDance boolean from skills (now using isMagic = 3).
* Removed nextDanceCost from Dance/Song skills (now is calculated internally).

Thanks '''MELERIX''' for help.
----------------------------------------------------------------------------
r5393 | Zoey76 | 2012-06-02 14:54:35

BETA: Fix for: Couple actions works fine from player A to B, but when couple finished and player B tries to request couple to player A it says "player is already doing a couple action always", until players A re-login.
* Reported and tested by MELERIX.

The problem:
Player A request player B.
Player B answer, player A's "couple data" is cleaned only if player B cancel.
So when couple action is accepted player A has player B as target of couple action.
The fix:
"Clean" (set to 0) the player A's "couple data" for any answer from player B.
----------------------------------------------------------------------------
r5392 | Nik | 2012-06-02 11:58:12

BETA: The ConnectionCloser threads at L2DatabaseFactory should better be canceled when L2DatabaseFactory.close(con) is called.
----------------------------------------------------------------------------
r5391 | MELERIX | 2012-06-02 09:17:02

BETA: Minor Fix for [5055].
----------------------------------------------------------------------------
r5390 | MELERIX | 2012-06-02 07:00:16

BETA: Small Cleanup for [DP8893].
----------------------------------------------------------------------------
r5389 | GodKratos | 2012-06-01 18:37:38

BETA: Core part for [DP8892]
----------------------------------------------------------------------------
r5388 | MELERIX | 2012-05-31 07:06:22

BETA: If skillType is not present in a skill, it will be DUMMY skillType by default (thanks '''BiggBoss''' for help).
----------------------------------------------------------------------------
r5387 | Zoey76 | 2012-05-30 15:41:47

BETA: Replacing FastList with ArrayList in L2Skill for non-shared maps.
* Thanks Tryskell to bring this to my attention.
* JavaDocs for L2ExtractableSkill.
----------------------------------------------------------------------------
r5386 | Zoey76 | 2012-05-30 15:32:38

BETA: Some changes for [5384]:
* Renamed EnchantGroupsTable to EnchantGroupsData.
* Added JavaDocs.
* Minor change in the order of the methods.
----------------------------------------------------------------------------
r5385 | MELERIX | 2012-05-29 23:30:06

BETA: Some skill defaults.
----------------------------------------------------------------------------
r5384 | UnAfraid | 2012-05-29 22:57:27

[BETA] Reworking SkillGroupsTable to xml thanks Micr0
Also unhardcoded cost multipliers to configs
----------------------------------------------------------------------------
r5383 | Zoey76 | 2012-05-28 21:01:55

BETA: Core cleanup:
* Enabling "Redundant argument type" warning.
* Respective fixes.
----------------------------------------------------------------------------
r5382 | UnAfraid | 2012-05-27 17:34:14

BETA: Broadcast.toSelfAndKnownPlayersInRadius() method rework radius now is no longer ^2
----------------------------------------------------------------------------
r5381 | Zoey76 | 2012-05-26 15:04:58

BETA: Minor typo fix for [5366], thanks digunan for report and MELERIX for confirm it.
----------------------------------------------------------------------------
r5380 | Zoey76 | 2012-05-25 17:54:35

BETA: NPE vulnerability fix by Tryskell.
----------------------------------------------------------------------------
r5379 | Zoey76 | 2012-05-25 17:35:00

BETA: Some useful methods by jurchiks.
----------------------------------------------------------------------------
r5378 | Zoey76 | 2012-05-25 17:20:21

BETA: Changing again, hopefully will be fine now, thanks jurchiks for report.
----------------------------------------------------------------------------
r5377 | Zoey76 | 2012-05-25 16:40:39

BETA: Some fixes for [5360]:
* Shared map is still required since reentrant lock is for the lists.
* Thanks UnAfraid for reporting this.
* Fix for quest not being saved.
* Avoiding using accessors instead of the field (by jurchiks).
* Thanks jurchiks and atp for first implementation but is not required to "save" the status.
* Thanks goncafa for report, and MELERIX for tests.
----------------------------------------------------------------------------
r5376 | MELERIX | 2012-05-25 06:16:51

COMMUNITY/BETA: Few more changes in the builders.
----------------------------------------------------------------------------
r5375 | MELERIX | 2012-05-24 23:59:38

COMMUNITY/BETA: Main jar files don't need to be executables because are executed from batch files with specific parameters.
----------------------------------------------------------------------------
r5374 | Nik | 2012-05-22 15:12:56

BETA: Charges mechanics fix. Charge clear task should be reset every time the charge count is changed. Classes using them will no longer be screwed-up in the middle of a fight by getting their charges cleared.
----------------------------------------------------------------------------
r5373 | UnAfraid | 2012-05-21 18:19:27

BETA: Unhardcoding shot ids from rechargeAutoSoulShot() method.
----------------------------------------------------------------------------
r5372 | UnAfraid | 2012-05-21 18:17:42

BETA: Removing some exp/sp multipliers debugs
----------------------------------------------------------------------------
r5371 | UnAfraid | 2012-05-21 17:21:18

BETA: Inventory Class fixes:
----------------------------------------------------------------------------
r5370 | UnAfraid | 2012-05-20 18:15:05

BETA: Removing "Initializing" logs
----------------------------------------------------------------------------
r5369 | Zoey76 | 2012-05-20 18:00:06

BETA: Removing init() abstract method from L2Script.
----------------------------------------------------------------------------
r5368 | Zoey76 | 2012-05-20 17:13:09

BETA: Unhardcoding Transfer skill checks.
----------------------------------------------------------------------------
r5367 | Zoey76 | 2012-05-20 16:51:36

BETA: Adding RecipeData which extends DocumentParser.
* TODO: Remove checks made by XSD.
----------------------------------------------------------------------------
r5366 | Zoey76 | 2012-05-20 16:33:36

BETA: Reworks:
* EngineInterface cleanup.
* WalkingManager now extends DocumentParser.
* Replaced Javolution where synchronization is not required.
* TODO: Merge with NpcWalkerRoutesData.
* TODO: Remove checks made by XSD.
* Added new method to DocumentParser to parse booleans.
* Separated logic from data loading in RecipeController.
* Data is now loaded in RecipeData which extends DocumentParser.
* TODO: Remove checks made by XSD.
* NpcWalkerRoutesTable renamed to NpcWalkerRoutesData, now extends DocumentParser.
* TODO: Remove checks made by XSD.
----------------------------------------------------------------------------
r5365 | UnAfraid | 2012-05-20 16:27:18

BETA: Minor typo fix pets will no longer receive exp form their master if they are not around him thanks goncafa for the report.
And format of L2PetInstance
----------------------------------------------------------------------------
r5364 | MELERIX | 2012-05-20 16:22:58

BETA: Cleanup for [5362].
----------------------------------------------------------------------------
r5363 | UnAfraid | 2012-05-20 15:43:47

BETA: Minor typo fix related with Shift action now players will be able to target monsters/npcs with Shift.
----------------------------------------------------------------------------
r5362 | MELERIX | 2012-05-20 14:29:27

BETA: Executable L2J_Configurator.jar file.
----------------------------------------------------------------------------
r5361 | GodKratos | 2012-05-19 22:16:16

BETA: Small change to zone checks.
----------------------------------------------------------------------------
r5360 | Zoey76 | 2012-05-19 18:50:34

BETA: Quest and QuestState Javadocs and minor code improvements by jurchiks, thanks:
* Avoiding using Javolution for not shared lists/maps.
* Note that I (Zoey76) removed FastList from timers since we use ReentrantLock for them.
* New methods:
* exitQuest(boolean, boolean)
* Finishes the quest and removes all quest items associated with this quest from the player's inventory. If {@code repeatable} is set to {@code false}, also removes all other quest data associated with this quest.
* startQuest()
* Set condition to 1, state to STARTED and play the "ItemSound.quest_accept". Works only if state is CREATED and the quest is not a custom quest.
* isCond(int)
* Checks if the quest state progress cond is at the specified step.
* setCond(int)
* Sets the quest state progress code cond to the specified step.

Reviewed by UnAfraid and me.
----------------------------------------------------------------------------
r5359 | GodKratos | 2012-05-19 05:15:15

BETA: Convert door data to XML format.

Thanks to JIV for initial design.
----------------------------------------------------------------------------
r5358 | MELERIX | 2012-05-19 03:43:32

COMMUNITY/BETA: C3P0 Lib Update.
----------------------------------------------------------------------------
r5357 | UnAfraid | 2012-05-18 17:52:37

BETA: Fix for #6197
----------------------------------------------------------------------------
r5356 | MELERIX | 2012-05-17 19:03:39

BETA: Steal Divinity is now susceptible to resistance against buff canceling attacks.
----------------------------------------------------------------------------
r5353 | MELERIX | 2012-05-17 02:58:54

COMMUNITY/BETA: Organizing files and updated builder for CommunityServer, also updated telnet settings.
----------------------------------------------------------------------------
r5352 | Zoey76 | 2012-05-16 23:31:01

BETA: Script spelling fixes.
----------------------------------------------------------------------------
r5351 | MELERIX | 2012-05-16 22:41:21

BETA: Moved GM Access/Commands Settings to configs.
----------------------------------------------------------------------------
r5350 | MELERIX | 2012-05-15 22:45:28

BETA: Removed "update" boolean from Ant Zip Task, because it doesn't build the Zip file properly (doesn't remove the old files).
----------------------------------------------------------------------------
r5349 | Zoey76 | 2012-05-15 21:48:30

BETA: Performance fixes:
* Replacing String literal can with character literal.
* Equality test with boolean literal: false
* A class that is not serializable declares a method named serialVersionUID.
* Cannot compare strings using the not equals (!= or ==) operator.
* Long literals should use "L" for a suffix.
* Avoiding extra math at ThreadPoolManager for each task.
* Removed unnecessary casting to super-classes.
* Fixing logic in many equals(Object) methods.
* Removed unnecessary overridden method.
----------------------------------------------------------------------------
r5348 | MELERIX | 2012-05-15 21:20:20

BETA: Organized some files.
----------------------------------------------------------------------------
r5347 | Zoey76 | 2012-05-15 19:14:11

BETA: Issuing Config cleanup:
* DeleteGmSpawnOnCustom should have been removed in [4440].
* CustomArmorSetsTable should have been removed in [5232].
* Closing ticket #6193, thanks for report.
----------------------------------------------------------------------------
r5346 | Zoey76 | 2012-05-15 18:30:50

BETA: Fixes:
* Client and server packet fixes.
* Equality with literal boolean.
* Using charAt(0) rather than startWith(..) for a single character.
* Removing unused import.
* Quest class:
* Comparing strings with equals(String) rather than ==.
* Classes from actor package:
* Setting _firstCommandChannelAttacked as volatile to make double locking check work properly.
* Equality with literal boolean.
* Avoiding "this instanceof", where it's possible.
----------------------------------------------------------------------------
r5345 | Zoey76 | 2012-05-15 18:06:51

BETA: L2PcInstance fixes:
* Explicit boolean comparison, for example, val == true.
* Useless override.
* Using loop to copy an array.
----------------------------------------------------------------------------
r5344 | Zoey76 | 2012-05-15 17:44:11

BETA: Fixes for L2Character:
Flagged bad double comparison, added TODO task.
Math round in maxAngleDiff, while using a double variable.
Avoiding "this instanceof".
Avoiding "instanceof".
Avoiding using a loop to copy an array.
----------------------------------------------------------------------------
r5343 | Zoey76 | 2012-05-15 01:35:09

BETA: (Code Style) final static to static final declaration (unified).
----------------------------------------------------------------------------
r5342 | Zoey76 | 2012-05-15 01:25:14

BETA: Upgrading DocumentParser, implementing getCurrecntDocument():
* JavaDocs for almost all classes that extends DocumentParser.
* Format and cleanup for almost all classes that extends DocumentParser.
* Fixed typos in variable names at FishData.
----------------------------------------------------------------------------
r5341 | Zoey76 | 2012-05-13 13:50:22

BETA: Minor cleanup.
----------------------------------------------------------------------------
r5340 | MELERIX | 2012-05-13 02:48:59

BETA: Now we use -1 for ban, not -100.
----------------------------------------------------------------------------
r5336 | MELERIX | 2012-05-12 00:17:04

BETA: Old bytecode files should be cleaned before compiling, other way it will compile wrong sources.
----------------------------------------------------------------------------
r5335 | MELERIX | 2012-05-11 23:04:55

BETA: I forgot to rename this -.-, thanks Zoey76 for report.
----------------------------------------------------------------------------
r5334 | MELERIX | 2012-05-11 22:32:10
----------------------------------------------------------------------------
r5333 | MELERIX | 2012-05-11 22:22:21

BETA: Builder using "bin" folder (like in Eclipse) instead of "classes".
----------------------------------------------------------------------------
r5332 | MELERIX | 2012-05-11 22:04:52

BETA: Builders Changes.
----------------------------------------------------------------------------
r5331 | Zoey76 | 2012-05-11 22:03:27

BETA: Bug fix for [5020] for potions not allowed if acting character is physically muted.
* Thanks Drumatrix for report and badboy29 for confirm and initial test.
* Fixes Shield Slam and similar skills.
----------------------------------------------------------------------------
r5330 | UnAfraid | 2012-05-11 00:46:12

BETA:
* L2Character rework:
* getSkills() returns Collection<L2Skill> no arrays/nulls anymore
* Many FastList/FastMap to ArrayList/HashMap when synchronizations aren't required.
* Javolution where synchronization is required.
* Added getSkills() into L2CharTemplate to prevent from casting.
* L2ZoneType rework:
* Added new methods getCharacters(), getPlayersInside()
* Many FastList/FastMap to ArrayList/HashMap when synchronizations aren't required.
* Javolution where synchronization is required.

----------------------------------------------------------------------------
r5329 | Zoey76 | 2012-05-10 23:30:57

BETA: Cubic related fixes:
* Moving cubics back to FastMap (reverting that from [4797]).
* Fixed cubics not removed on subclass change, etc (stopCubics() method) by Starter, thanks.
* Cleaned up for useless booleans, etc.
* AttackStanceTaskManager logic fix.
* Avoiding using accessors inside the class where the field is declared.
----------------------------------------------------------------------------
r5328 | UnAfraid | 2012-05-10 23:04:36

BETA: Fix for NPE while restoring clan wars
* Methods that listeners was located in are used only to restore data now they are moved where they belong.
* Moving initial equipment from CharTemplateTable its not required to be there
* Removing 'this' from L2Effect
----------------------------------------------------------------------------
r5327 | Zoey76 | 2012-05-10 21:58:39

BETA: Fixing possible client crash due unbound buy of items (weight and inventory slots not validated).
* Thanks Starter for report and first implementation.
* This generic version implements exchangeItemsById(..) for information refers to its JavaDocs.
* Try to use it instead of destroyItem/addItem methods.
* Cleanup related to this changes.
----------------------------------------------------------------------------
r5326 | Zoey76 | 2012-05-10 21:12:19

BETA: Reverting [5234] due several vulnerability on account name, thanks '''tukune''' for report.
* [viewtopic.php?f=4&t=25367 Code snippet].
----------------------------------------------------------------------------
r5325 | Zoey76 | 2012-05-10 21:01:29

BETA: Condition Player Race shouldn't check player's race if the acting character isn't a player.
* Thanks Tavo22, goncafa for report.
* Thanks MELERIX for first fix implementation and info about the bug.
----------------------------------------------------------------------------
r5324 | Adry_85 | 2012-05-10 17:36:40

BETA: Fix for Geometry in Changeset [5320] (thanks '''MELERIX''' for help).
----------------------------------------------------------------------------
r5323 | MELERIX | 2012-05-09 17:40:52

BETA: Vuln-Prof Fixes...
* Fixed "ValakasVuln/Prof" for the "Valakas Items" to work properly (is based in the existent support, so just some things renamed/changed to use the right values).
* Fixed "DebuffVuln/Prof" for the "Debuff Skills" to work properly (now is based on isDebuff boolean and skillType, so it should solve the issues of some Debuff skills not being resisted properly, like DISARM and some others).

also removed isToggle check from "oncast_skill" condition, because there is no Toggle Magic Skills.
----------------------------------------------------------------------------
r5322 | MELERIX | 2012-05-09 12:44:46

BETA: Fix for "oncast_skill" condition.
----------------------------------------------------------------------------
r5321 | UnAfraid | 2012-05-08 22:30:14

BETA: * ZoneManager rework
* Using DocumentParser
* Using HashMap/ArrayList when synchronization isn't required instead of Javolution
* DocumentParser
* new Method parseDouble (self explaining)
* new method getCurrentFile (returns reference of current processing File)
----------------------------------------------------------------------------
r5320 | GodKratos | 2012-05-08 03:30:35

Reworking zone models.
Tests shows reduction in loading times of up to 80%.
----------------------------------------------------------------------------
r5319 | MELERIX | 2012-05-07 17:30:12

BETA: Few More Typo Fixes for [4845] and code format.
----------------------------------------------------------------------------
r5318 | MELERIX | 2012-05-07 11:08:13

BETA: A Missing SysMsg.
----------------------------------------------------------------------------
r5317 | MELERIX | 2012-05-06 22:29:50

BETA: Minor Typo Fix for [4845].
----------------------------------------------------------------------------
r5316 | MELERIX | 2012-05-05 02:35:17

BETA: Fixed Automatic Doors and Implemented some others missing '''(REQUIRE [DP8810])'''.
----------------------------------------------------------------------------
r5314 | Zoey76 | 2012-05-04 23:35:12

BETA: Typo fix in OldPledgeFilter, thanks tukune for report.
----------------------------------------------------------------------------
r5311 | MELERIX | 2012-05-03 10:17:58

BETA: MySQL Connector/J 5.1.20, Changelog here: http://dev.mysql.com/doc/connector-j/en ... -1-20.html
----------------------------------------------------------------------------
r5310 | Zoey76 | 2012-05-01 20:05:51

BETA: Enforcing load() method for DocumentParser.
* This will:
* Allow easy implementation of reload admin commands.
* Standardize the XML parsers.
----------------------------------------------------------------------------
r5309 | Zoey76 | 2012-05-01 14:36:29

BETA: Misc fixes:
* Addressing the "synthetic access" problem.
* When using nested classes, JVM would create a "synthetic class" (dynamic proxy) with the accessors to access its fields.
* To that add the overhead that suppose using accessors (getters for fields) instead of direct access (pointed out by BiggBoss at forums).
* This can be fixed in different ways, I have chosen to change the visibility of some fields, classes and methods to make them visible from outer classes instead of adding public/protected accesors.
* This should avoid the creation of this synthetic classes and avoid adding accessors to simple holders (DTOs).
* Reverting synchronization overhead at Point3D, since it uses "cheap read-write lock" trick, thanks tukune for report.
* [http://www.ibm.com/developerworks/java/ ... x.html#3.1 The cheap read-write lock trick]
* Revering some minor things in Action packet, no in-game visible changes.
* Fixed typo at FaenorScriptEngine, thanks nonom for report.
* Avoiding FastMap in AbstractRefinePacket where synchronization is not required, using the direct field access instead of the getter for the calls inside the same class.

'''Note:''' For those who get warnings after the eclipse preference changes, use the support area to ask for help fixing them.
----------------------------------------------------------------------------
r5308 | UnAfraid | 2012-04-30 14:57:40

BETA: A minor typo fix for [5292]
----------------------------------------------------------------------------
r5307 | UnAfraid | 2012-04-30 12:04:23

BETA: Targetable by default
----------------------------------------------------------------------------
r5306 | UnAfraid | 2012-04-30 12:03:07

BETA: Implementing the rest of isTargetable thanks VlLight
Also a little bit cleanup.
----------------------------------------------------------------------------
r5305 | Zoey76 | 2012-04-28 16:56:25

BETA: Formatting:
* Server class.
* L2DatabaseFactory formatting and JavaDocs.
----------------------------------------------------------------------------
r5304 | Zoey76 | 2012-04-28 16:35:30

BETA: Formatting:
* Pathfinding related classes.
* Script related classes.
* Scripting related classes.
* Faenor related classes.
* Scriptengine (listeners) related classes.
* Security related classes.
* Game server util related classes.

'''Note:''' As I said in previous commits, think about this formatting like one way ticket, and patches will be more readable and cleaner in future.
----------------------------------------------------------------------------
r5303 | Zoey76 | 2012-04-28 15:57:02

BETA: Misc fixes:
* Minor typo fix from [5284], thanks tukune for report.
* Missing formatting in ConditionTargetWeight, now all conditions are formatted.
* More JavaDocs fixes in Quest related classes by jurchiks!
----------------------------------------------------------------------------
r5302 | UnAfraid | 2012-04-28 13:02:49

BETA: Increasing known list for walker npcs to prevent from seeing them on wrong positions or not seeing them at all.
----------------------------------------------------------------------------
r5301 | MELERIX | 2012-04-28 05:10:24
----------------------------------------------------------------------------
r5300 | MELERIX | 2012-04-28 05:01:56

BETA: Support for Fishing Rods by '''nonom'''
* Reeling and Pumping now get a proper damage per rod type.
* Refactorized a couple of names* and added some javadocs.
* Rewrited the method getFishingRod() thanks Zoey.
* Reviewed the damage formula.
* Improved penalty damage by Expertise skill, now is exactly 5 percent instead a fixed value.

'''REQUIRE: [DP8802].'''


----------------------------------------------------------------------------
r5299 | UnAfraid | 2012-04-28 00:06:40

BETA: Faenor Engine rework (Thanks Tukune)
* Removing zip support
* Source format/cleanup
Note: Requires DP Update
----------------------------------------------------------------------------
r5298 | UnAfraid | 2012-04-28 00:02:23

BETA: AllianceInfoPacket thanks afk5min
----------------------------------------------------------------------------
r5297 | UnAfraid | 2012-04-27 23:04:22

BETA: Updating Party Matching system (Thanks to Tryskell and Gnacik)
Also cleaned Packet handler from packets that should not be there and added some missing ones.
----------------------------------------------------------------------------
r5296 | UnAfraid | 2012-04-27 22:21:00

BETA: Removing uselss data restore during \//reload npcId <id> only Quests are enough
Also more FastList => ArrayList
And log.cfg update for [5291]
----------------------------------------------------------------------------
r5295 | Zoey76 | 2012-04-27 21:56:27

BETA: The rest of [5294].
----------------------------------------------------------------------------
r5294 | Zoey76 | 2012-04-27 21:50:24

BETA: Formatting:
* Login server.
* Status.
* Tools
* Util.

'''Note:''' For those that will get conflicts with this changeset, think about it as one time trouble.
----------------------------------------------------------------------------
r5293 | UnAfraid | 2012-04-27 21:44:20

BETA: Updating unloading method of Quest class
* Now it will unload all quest events from L2NpcTemplate
* Reworked many FastList/FastMap to ArrayList/HashMap where synchronization isn't required.
* Reworked L2NpcTemplate
----------------------------------------------------------------------------
r5292 | UnAfraid | 2012-04-27 21:28:03

BETA: EnchantItemTable rework:
* Renamed to EnchantItemData
* Using DocumentParser
* Using HashMap instead of Troove map
* Simplify loading methods
* Removing double log in EffectHandler
----------------------------------------------------------------------------
r5291 | Zoey76 | 2012-04-27 20:48:16

BETA: Log classes rearranging and formatting.
----------------------------------------------------------------------------
r5290 | Zoey76 | 2012-04-27 20:36:25

BETA: Misc fixes:
* NPE vulnerability:
* ValueSortMap, suppressed for now.
* L2Attackable
* NpcBufferTable
----------------------------------------------------------------------------
r5289 | UnAfraid | 2012-04-27 20:04:11

BETA: Administration rework:
* AdminTable now contains:
* GmListTable
* AdminCommandAccessRights
* AccessLevels
* Moved access_levels and admin_command_access_rights into data/accessLevels.xml, adminCommands.xml
* '''Changed access levels now full root access level is 8 so 127 is no longer valid'''!
* Replacing some FastList/FastMap with ArrayList/HashMap where synchronization isn't required in:
* L2Character
* L2World
'''NOTE: Requires DP Update!'''
----------------------------------------------------------------------------
r5288 | Zoey76 | 2012-04-27 19:30:08

BETA: Misc fixes:
* NPE vulnerability:
* L2FortSiegeGuardAI
* NpcBufferTable
* TerritoryWarManager, not fixed, it should be managed in other way, check TODO task.
* PcStatus, rewrite is probably needed.
* L2Character, _skills should be moved to FastMap probably.
* TvTManager
* PcInventory
* AutoSpawnHandler
* RequestDuelStart
* FloodProtectedListener, formatted.
* SpringUtilities, probably needs rewrite, should be simplified.
* BaseGameServerRegister
* NPE vulnerability fixed using ARM:
* Config
----------------------------------------------------------------------------
r5287 | Zoey76 | 2012-04-27 18:47:35

BETA: Misc fixes:
* Potential NPEs fixed using ARM
* Announcements
* GeoEngine
* CrestCache, Unhardcoded Filters.
* DoorTable
* UITable
* FortSiegeManager
* SiegeManager
* GeoPathFinding
* L2ScriptEngineManager, FileOutputStream creates the file if not present, is not required to check and create.
* JarClassLoader
* L2LoginServer
* GameStatusThread
* LoginStatusThread
* Base64
* Log
* Potential NPEs fixed in other way:
* L2ControllableMobAI
* PostBBSManager
* L2EffectZone
* RequestGMCommand
* BlowFishKey
* DBInstallerConsole
* Avoiding FastList/FastMap where synchronization is not required:
* SkillTreesData
* UITable
* TerritoryWarManager
* L2CastleMagicianInstance
* L2FishermanInstance
* L2FortSupportCaptainInstance
* L2NpcInstance
* L2PcInstance
* L2TrainerHealersInstance
* L2TransformManagerInstance
* L2VillageMasterInstance
* Castle
* Fort
* Simplified code:
* ConditionPlayerCanSweep
* Castle
* DBInstallerConsole
* Base64
* Flagging code that need to be rewritten:
* L2Attackable
----------------------------------------------------------------------------
r5286 | MELERIX | 2012-04-27 05:35:47

BETA/OTHERS: Minor Changes in the Builders for Ant Zip Task.
----------------------------------------------------------------------------
r5285 | Zoey76 | 2012-04-26 23:13:24

BETA: Formatting Multisell related classes and minor changes.
----------------------------------------------------------------------------
r5284 | Zoey76 | 2012-04-26 22:59:16

BETA: Misc fixes:
* L2DatabaseFactory addressing the Double-Checked Locking problem.
* [http://en.wikipedia.org/wiki/Double-che ... ge_in_Java Double-checked locking: Usage in Java]
* [http://www.cs.umd.edu/~pugh/java/memory ... cking.html Double-Checked Locking]
* SevenSigns writing to static field from instanced method.
* SevenSignsFestival unnecessary Math operation, NPE vulnerability.
* Territory writing to static field from instanced method.
* GeoEditorListener writing to static field from instanced method.
* HandysBlockCheckerManager incorrect lazy initialization.
* MercTicketManager incorrect lazy initialization (double check and lock).
* RaidBossSpawnManager NPE vulnerability.
* TerritoryWarManager unnecessary Math operations.
* WalkingManager NPE vulnerability, shouldn't continue if document couldn't be parsed.
* L2Character:
* Addressing the Double-Checked Locking problem.
* _attackByList
* _chanceSkills
* NPE vulnerability.
* L2ClanHallDoormenInstance addressing the Double-Checked Locking problem.
* L2PcInstance:
* Addressing the Double-Checked Locking problem.
* _teleportWatchdog
* _notifyQuestOfDeathList
* NPE vulnerability.
* Unnecessary Math (should have been removed in [5268]).
* L2TamedBeastInstance writing to static field from instanced method.
* Castle NPE vulnerability.
* L2SkillSummon unnecessary Math.
* L2EffectZone addressing the Double-Checked Locking problem.
* _task
* _skills
* CharacterRestore exception not thrown.
* RequestReplySurrenderPledgeWar NPE vulnerability.
* RequestRestartPoint NPE vulnerability.
* TaskManager implements equals(Object) but not hashCode().
* Point3D if set method is synchronized then get method should be synchronized.
* GameServerRegister NPE vulnerability.
* LanguageControl NPE vulnerability, now using ARM.
* LocalizationParser NPE vulnerability.
* Base64 NPE vulnerability.
* BaseRecievePacket NPE vulnerability.
* [http://blogs.atlassian.com/2007/07/date ... d_threads/ DateFormat is not thread-safe]
* ItemAuctionInstance DateFormat shouldn't be static, it's not thread safe.
* FaenorParser DateFormat shouldn't be static, it's not thread safe.
* GMAudit DateFormat shouldn't be static, it's not thread safe.
* '''Note:''' If the performance drops (memory leaks), FastDateFormat from Apache Commons Lang could be used which is thread-safe.
----------------------------------------------------------------------------
r5283 | Nik | 2012-04-25 07:03:57

BETA: I hate when I cant invite invisible GMs/players to a party...
GMs can now invite invisible players to a party.
----------------------------------------------------------------------------
r5282 | UnAfraid | 2012-04-24 22:33:12

BETA: Armorset base stats implementation
- Separated all static func classes from Formulas into own files
- Merged all Henna related func classes in one.
- Removed all uselss func classes.

----------------------------------------------------------------------------
r5281 | UnAfraid | 2012-04-22 22:43:37

BETA: Arcane Shield abnormal effect typo fix
----------------------------------------------------------------------------
r5280 | Zoey76 | 2012-04-22 20:14:48

BETA: Misc fixes:
* Avoiding duplicated code using getActingPlayer(), by Tryskell.
* Avoiding getActiveChar() calls, instead using present reference.
* Using proper logger inheritance from AbstractAI.
----------------------------------------------------------------------------
r5279 | Zoey76 | 2012-04-22 19:49:57

BETA: Core part for [DP8712]:
* Using abnormal time and abnormal count to calculate buff icon display time.
* Fix for #5286
* Thanks JMD for report and test.

'''Note:''' A slightly different approach will be used after skill rework.
----------------------------------------------------------------------------
r5278 | Zoey76 | 2012-04-22 19:12:38

BETA: Reworking GameServerTable.
* Replaced shared FastMap with HashMap, due it's using synchronized blocks already.
* Added all JavaDocs.
* Using proper Singleton pattern.
* Closed XMLStreamReaderImpl, thanks Starter.
* Exceptions are logged, they shoudln't be managed at GUI level (maybe needs more work).
* Using ARM in some places, (should we update Javolution to Java 7?).
* Cleanup and format.
----------------------------------------------------------------------------
r5277 | Zoey76 | 2012-04-22 18:59:22

BETA: Useful wrapper for multiple item quest related checks, by UnAfraid.
----------------------------------------------------------------------------
r5276 | UnAfraid | 2012-04-22 18:04:22

BETA: Typo fix in RegisterGameServer.exe. After last libs update it stopped working thanks Zoey76 for report
----------------------------------------------------------------------------
r5275 | Zoey76 | 2012-04-22 13:17:44

BETA: Config formatting and improvements by jurchiks.
* Removed unnecessary casting, thanks lord_rex.
----------------------------------------------------------------------------
r5274 | Zoey76 | 2012-04-21 18:27:00

BETA: Database connection cleanup:
* Closed unclosed resources.
* Using ARM for ImputStream.
* Cleanup.
----------------------------------------------------------------------------
r5273 | Zoey76 | 2012-04-21 17:03:17

BETA: Cleanup and format:
* BaseGameServerRegister's JavaDocs, cleanup and formatting.
* Action packet cleanup and formatting.
----------------------------------------------------------------------------
r5272 | Zoey76 | 2012-04-21 15:13:40

BETA: Fix for cached HTML not being loaded:
* Thanks '''zatei''' for report, first fix implementation and tests.
* Closed #6162
----------------------------------------------------------------------------
r5271 | GodKratos | 2012-04-21 07:26:34

BETA: Config Typo
----------------------------------------------------------------------------
r5270 | UnAfraid | 2012-04-16 20:20:04

BETA: Fix for servitor instance shared elementals thanks Tavo22.
----------------------------------------------------------------------------
r5269 | UnAfraid | 2012-04-15 08:51:18

BETA: NPE Fixes thanks Starter for report.
----------------------------------------------------------------------------
r5268 | MELERIX | 2012-04-12 20:27:28

BETA: All Fishes are now in XML instead of SQL '''(by nonom)'''.
* The new FishData class is using the Zoey's DocumentParser abstraction.
* New attributes, so now the fishes have the proper data.
* New fishes and categories that actually are missing.
* Renamed all the old attributes matching the retail names, like groups and grades.
* Added javadocs, cleaned and formatted.

'''NOTE: Require DP [DP8783]'''
----------------------------------------------------------------------------
r5267 | Zoey76 | 2012-04-12 14:49:31

BETA: Fix for typo from [5257] by _Blade_
* Closed #6144
----------------------------------------------------------------------------
r5266 | Zoey76 | 2012-04-11 18:52:14

BETA: Refactoring:
* L2PetLevelData refactor and documentation.
* L2PetData minor refactor and documentation.
* PetDataTable refactor and documentation, now extends DocumentParser.
* ArmorSetsTable renamed to ArmorSetsData, minor refactor.
----------------------------------------------------------------------------
r5265 | Zoey76 | 2012-04-10 15:23:55

BETA: Same as [5264], thanks Tavo22 for really fast test and report.
----------------------------------------------------------------------------
r5264 | Zoey76 | 2012-04-10 14:14:38

BETA: Fixing two minor typos.
----------------------------------------------------------------------------
r5263 | Zoey76 | 2012-04-09 23:22:41

BETA: Typo fix from [5261], thanks _Blade_ for report and fix.
* Fixed #6145
* Probably fixed #6144 please confirm in trac.
----------------------------------------------------------------------------
r5262 | Zoey76 | 2012-04-09 23:05:02

BETA: Cleanup and format for tasks related classes.
* Minor refactor of loggers.
----------------------------------------------------------------------------
r5261 | Zoey76 | 2012-04-08 22:34:25

BETA: Misc fixes:
* Added parseDatapackFile(String) to avoid useless imports.
* Instead of using a boolean the getClassCode() method has been split in two different methods.
* InstanceManager now extends DocumentParser.
* MapRegionManager now extends DocumentParser.
* Reverting [5246], using escaped string in proper places.
* Fixing [viewtopic.php?f=81&t=25148 L2VillageMasterInstance], retail has the class names in links hardcoded, we have them partially hardcoded...
* Avoiding Javolution (FastList and FastMap) where synchronization is not required.
----------------------------------------------------------------------------
r5260 | UnAfraid | 2012-04-08 10:42:44

BETA: Reverting some changes from [5249]
----------------------------------------------------------------------------
r5259 | Zoey76 | 2012-04-07 19:12:44

BETA: Id Factory cleanup and format.
----------------------------------------------------------------------------
r5258 | Zoey76 | 2012-04-06 23:58:53

BETA: Minor changes to some listeners based on #6129 report.
----------------------------------------------------------------------------
r5257 | Zoey76 | 2012-04-06 23:29:36

BETA: Henna related fixes:
* Reverting [5254], enhanced loops aren't different than iterators (or index array), [http://docs.oracle.com/javase/1.5.0/doc ... reach.html except that enhanced loops are less prone to errors (typos) and they look better].
* Replacing array with list.
* Let's avoid finalizing methods in finalized classes, since they cannot be overridden anymore.
* Unhardcoded another "is allowed" henna check.
* Fix for #6131
----------------------------------------------------------------------------
r5256 | UnAfraid | 2012-04-04 16:37:47

BETA: Banish have to kick clanless players too.
----------------------------------------------------------------------------
r5255 | UnAfraid | 2012-04-04 16:25:43

BETA: Fix for ticket #6133 thanks Starter for report.
----------------------------------------------------------------------------
r5254 | UnAfraid | 2012-04-03 17:06:24

BETA: GMHennaInfo typo fix thanks Starter
----------------------------------------------------------------------------
r5253 | UnAfraid | 2012-04-02 22:09:04

BETA: L2PcInstance#storeCharBase() isn't necessary to change to main to get lvl, exp, sp
----------------------------------------------------------------------------
r5252 | MELERIX | 2012-04-02 20:53:40

BETA: MySQL Connector/J 5.1.19, Changelog here: http://dev.mysql.com/doc/refman/5.1/en/ ... -1-19.html
----------------------------------------------------------------------------
r5251 | UnAfraid | 2012-04-02 20:45:47
----------------------------------------------------------------------------
r5250 | UnAfraid | 2012-04-02 19:16:08

BETA: Removing backward compatibility for L2Party/L2CommandChannel if you want it skip that changeset thanks Battlecruiser
----------------------------------------------------------------------------
r5249 | UnAfraid | 2012-04-02 18:04:16

BETA: L2Party, L2CommandChannel refactoring by Battlecruiser
More info: viewtopic.php?f=69&t=24878
----------------------------------------------------------------------------
r5248 | UnAfraid | 2012-04-02 16:26:37

BETA: NPE fix for L2ItemInstance#dropMe() thanks Battlecruiser
----------------------------------------------------------------------------
r5247 | UnAfraid | 2012-04-01 11:31:56

BETA: NPE Clan Table restorewars NPE fix thanks Starter for report.
----------------------------------------------------------------------------
r5246 | Nik | 2012-03-30 13:37:39

BETA: String replace bigfix at class master. (by Battlecruiser)
----------------------------------------------------------------------------
r5245 | Zoey76 | 2012-03-29 23:47:25

BETA: Misc fixes:
* SQL query updated missing from [5240], fix for #6128
* Set L2PcTemplate#getClassName() as deprecated.
* Fixed order in imports in ClanWarehouseListener.
----------------------------------------------------------------------------
r5244 | UnAfraid | 2012-03-29 20:51:28

BETA: Reworking a bit StaticObjects now Fortress flags will be loaded from staticObjects.xml instead of fort_staticobjects as before.
----------------------------------------------------------------------------
r5243 | UnAfraid | 2012-03-29 20:43:35

BETA: Zone types cleanup and format
----------------------------------------------------------------------------
r5242 | Zoey76 | 2012-03-29 20:34:39

BETA: Changing a bit DocumentParser, now parseFile(File) calls parseDocument(Document), instead of returning the document.
* Narrowed the scope of some method from public to protected.
----------------------------------------------------------------------------
r5241 | Zoey76 | 2012-03-29 16:44:38

BETA: Standardizing ExperienceTable and HitConditionBonus:
* Added JavaDocs to ExperienceTable.
* Using proper Singleton pattern in HitConditionBonus.
* Added JavaDocs to HitConditionBonus.
* Cleanup and format.
----------------------------------------------------------------------------
r5240 | Zoey76 | 2012-03-29 12:36:00

BETA: Henna, Initial Equipment and Class List rework:
* Using Freya retail Henna data.
* All constrains in [http://www.w3schools.com/schema/default.asp XSD].
* Unhardcoded cancel fee and count.
* Using Freya retail Initial Equipment data.
* Added Event Initial Equipment retail like, for example server opening.
* All constrains in [http://www.w3schools.com/schema/default.asp XSD].
* Unhardcoded equipped condition.
* Added and unhardcoded, ''in beta state'', Class List data.
* This Unhardcodeds all class names (in HTMLs for example) using client info!
* No more sub-class selection list with lower-case names or typos!
* Also unhardcoded Hero class names!
* All constrains in [http://www.w3schools.com/schema/default.asp XSD].
* Removed L2HennaInstance, using L2Henna item, since this are static [http://en.wikipedia.org/wiki/Data_transfer_object DTOs].
* Using proper getters for L2PcTemplate, reworked, added all JavaDocs.
* Packet rework for all henna and character creation client and server packets.
* Client and Server packets Logger cleanup.
* Minor fix in the order in AcquireSkillType.
* Minor improvement in logs for StatsSet.
* Minor fixes to ArmorSetTable.
* Fixed scripting/scriptengine/package-info.java
----------------------------------------------------------------------------
r5239 | UnAfraid | 2012-03-29 00:14:42

BETA: Little update of ArmorSetsTable:
* Enforcing xsd validation.
* Using DocumentParser and removing old implementation of XMLParser
* Only one chest per set is now supported (Since set is binded to it)
----------------------------------------------------------------------------
r5238 | UnAfraid | 2012-03-28 19:00:30

BETA: Code format for [5237]
----------------------------------------------------------------------------
r5237 | UnAfraid | 2012-03-28 18:50:58

BETA: Updating listeners thanks theone and nonom for testing.
* ClanWarehouse moved to it's new location
* All the null checks are in the "fireAction" methods
* Enums are now all capitalized (thx for pointing this out jurchiks)
* Added a listener into RequestRestart packet so that the player despawn events get triggered on restart also.
More info here viewtopic.php?f=70&t=25089
----------------------------------------------------------------------------
r5236 | UnAfraid | 2012-03-28 13:13:15

BETA: Typo fix
----------------------------------------------------------------------------
r5235 | Zoey76 | 2012-03-26 17:53:48

BETA: Reworking Skill Trees:
* Now ready for new structure!
* Created abstract parser DocumentParser.
* XSD validation enforced, all checks are done there!
* Removed checks from core.
* Moved logs to report() method, bit more cleaner now.
* Fixed some JavaDocs.
* Removed iterations in multiple places in order to check for available skills, performance increased and code simplified!
* Using list.isEmpty() instead of list.size() < 1, for safety reasons.
* Using map.containsKey(key) instead of map.get(key) == null, for safety reasons.
* Minor fix for DocumentBase logger.
* Reworked L2SkillLearn:
* Removed useless parsing...
* Bit more OOP.
* Unhardcoded "PreReqSkills", also now is not limited to one skill anymore.
* Unhardcoded ''again'' some race checks.
* Reworked AcquireSkillInfo, some values are still unknown.

'''Note:''' This rework focuses in removing useless/outdated code from core, by moving checks to XSD and removing duplicated code by placing it once in strategic places.
----------------------------------------------------------------------------

[Zoey76]

SPOILER:

r5234 | Nik | 2012-03-26 17:42:21

BETA: Strings should be avoided as key in maps unless you need the key this way. The hash of the string will just do fine, and saves a hell lot of RAM.
----------------------------------------------------------------------------
r5233 | Nik | 2012-03-26 17:03:36

BETA: Memory leak fix. CharEffectList shouldnt keep effects cache upon deletion, this causes references to some effects (thus cant be deleted by GC and keep memory occupied). getEffector() and getEffected() of the effect keep references to L2Characters, those L2Characters cant be deleted from the GC aswell, thus causing 13,731 instances of L2PcInstance on my server, WTF? I just hope that this is the main causer of that, and not something else ^^
----------------------------------------------------------------------------
r5232 | UnAfraid | 2012-03-25 19:05:10

BETA: Core support for [L8744]
----------------------------------------------------------------------------
r5231 | Zoey76 | 2012-03-23 18:33:23

BETA: Misc fixes:
* L2Npc JavaDoc fixes and using direct access to QuestEventType.
* ConditionPlayerTransformationId JavaDoc fixes and minor refactor.
----------------------------------------------------------------------------
r5230 | Zoey76 | 2012-03-23 18:23:05

BETA: HtmCache refactor:
* Unhardcoded HTML filter, accepts .htm and .html files only.
* Class cleanup.
* Using [http://www.oracle.com/technetwork/artic ... 01775.html Automatic Resource Management]
----------------------------------------------------------------------------
r5229 | Zoey76 | 2012-03-23 15:20:29

BETA: Exploit fix related to "Alternate Skill Learning System", thanks u3games for report and test.
----------------------------------------------------------------------------
r5228 | Zoey76 | 2012-03-23 11:11:19

BETA: Continuing with [5214] and [5217] Quest class related documentation and formatting fixes, this time by '''jurchiks'''.
* Reviewed and corrected by me.

'''Note:''' To contributors, checking such long patches take time, and we (developers) are responsible of what gets committed, we cannot and will not commit stuff blindly just because it doesn't change code or it won't break anything. Pushing the development team for commit doesn't help at all, keep that in mind.
----------------------------------------------------------------------------
r5227 | UnAfraid | 2012-03-23 09:50:19

BETA: Removing local logger from all client/server packets they'll be using the parent one.
----------------------------------------------------------------------------
r5226 | UnAfraid | 2012-03-22 21:16:16

BETA: Reverting [4538] Actually there is a limit it may not be 8192 but that doesn't means there isn't at all.
+ L2GameClient/Server Packets loggers update
----------------------------------------------------------------------------
r5225 | Nik | 2012-03-22 17:55:48

BETA: NPC Rush malfunction fixed. Now they move when they cast rush instead of staying on one place.
----------------------------------------------------------------------------
r5224 | UnAfraid | 2012-03-22 15:32:03

BETA: Get rid of Compiled Scripts cache support.
----------------------------------------------------------------------------
r5223 | Zoey76 | 2012-03-22 11:46:19

BETA: Some resource management by Starter.
* ItemAcutionInstance.
* MailSystem.
* Cached comparator and minor changes by me.
----------------------------------------------------------------------------
r5222 | UnAfraid | 2012-03-21 12:52:38

BETA: Castle class some misc fixes && code format
----------------------------------------------------------------------------
r5221 | Zoey76 | 2012-03-21 09:57:32

BETA: Enabling some warnings and documenting few classes.
* Warning: Possible accidental boolean assignment (e.g. 'if (a = b)')
* Warning: Empty statement: When enabled, the compiler will issue an error or a warning whenever it encounters an empty statement (e.g. a superfluous semicolon).
* Config class JavaDoc.
* Minimalist L2DatabaseFactory JavaDoc.
* SkillTreesData JavaDocs.
* L2SkillOpType JavaDocs.
----------------------------------------------------------------------------
r5220 | Nik | 2012-03-21 07:50:15

BETA: isAttackingDisabled@doAttack should be one of the first checks, since its lighter.
----------------------------------------------------------------------------
r5219 | Zoey76 | 2012-03-20 12:54:29

BETA: Enabling Indirect access to static member warning.
* Respective fixes.

'''Note:''' This means that you are calling a ''constant'' defined in a superclass referencing it from a subclass.
----------------------------------------------------------------------------
r5218 | Zoey76 | 2012-03-20 11:06:01

BETA: NpcBufferTable fixes, thanks fakoykas for report and first fix.
----------------------------------------------------------------------------
r5217 | Zoey76 | 2012-03-20 10:40:50

BETA: Continuing with [5214] Quest class related documentation and formatting fixes.

'''Note:''' When using formatting tool, remember it format comments as well, so if they are not in proper format, using break tags, etc, there will be a bigger mess than help, take time to manually fix them.
----------------------------------------------------------------------------
r5216 | Zoey76 | 2012-03-07 23:11:45

BETA: Typo fix in inventory by d!g0:
* Fixes problem with equip reuse delay (Talismans)
* Fixes ticket #6085
----------------------------------------------------------------------------
r5215 | MELERIX | 2012-03-07 04:34:50

BETA: Only etcitem_type "rune" can give passive skills when held in your inventory, not all etcitems.
----------------------------------------------------------------------------
r5214 | Zoey76 | 2012-03-03 16:04:26

BETA: Weekend bug fix madness:
* Addressing the NPE problem at RegionBBSManager, ''bit experimental'', feedback required.
* SkillList server packet cleanup.
* ManagedScript typo in JavaDoc.
* More JavaDoc fixes at L2Character.
* SystemMessageId adding missing messages and fixing typos.
* Quest writing extensive documentation, fixing typos in comments.
* Based in Fulminus original documentation, updated as JavaDocs and completed.
* Typos related to comments fixed.
* More JavaDocs will be added soon...
* QuestState minor cleanup.
* Participant using getters and setters, preventing NPEs. Fixes [viewtopic.php?f=77&t=24871 Olympiad problem]
* Related changes to related classes.
* OlympiadGameNormal cleanup.
* Minor change in L2PcInstance to send skill list with display Id instead of plain skill Id. Fixes [viewtopic.php?f=77&t=24847 Custom skill problem]
* Adding a new map in L2Character to hold information about custom skills in characters. Fixes [viewtopic.php?f=77&t=24847 Custom skill problem]
* Created on character creation.
* Updated when character has a skill removed/added.
* Does not have persistence.
* Small, fast-lookup.
* Support in RequestMagicSkillUse to find a custom skill in the custom skills map if it wasn't found in the character's skills. Fixes [viewtopic.php?f=77&t=24847 Custom skill problem]
* Cleanup for TaskDailySkillReuseClean.
* Adding Wondrous Cubic - 1 time use(22180) skill to daily cleanups.
* Fixed SkillCoolTime typo from [5180], thanks blacksea for report. Fixes [viewtopic.php?f=77&t=24893 Reuse bug] and #6083
----------------------------------------------------------------------------
r5213 | MELERIX | 2012-03-02 18:13:07

ECJ Lib Update for JavaEngine.
----------------------------------------------------------------------------
r5212 | Zoey76 | 2012-03-02 09:04:16

BETA: Skill Trees fixes:
* Fixed race check in auto-get skills.
* Transformations fix, thanks avatar7.
* Fixed Dwarven skill counter.
----------------------------------------------------------------------------
r5211 | UnAfraid | 2012-03-01 05:25:01

BETA: Cleanup
----------------------------------------------------------------------------
r5210 | UnAfraid | 2012-03-01 05:10:46

BETA: More for [DP8704] And fixing mp consume for cross-bow
----------------------------------------------------------------------------
r5209 | UnAfraid | 2012-03-01 04:37:45

BETA: Core support for [DP8704]
----------------------------------------------------------------------------
r5208 | MELERIX | 2012-02-29 12:50:36

Removed [5207], Nightly Builds are working again.
----------------------------------------------------------------------------
r5207 | MELERIX | 2012-02-28 20:07:29

attempting to fix nightly builds with this hack, this changes will be removed later.
----------------------------------------------------------------------------
r5206 | MELERIX | 2012-02-27 06:08:51

BETA: ECJ Lib Update.
----------------------------------------------------------------------------
r5205 | MELERIX | 2012-02-27 05:40:46

BETA: Cleanup due [DP8698].
----------------------------------------------------------------------------
r5204 | Zoey76 | 2012-02-27 05:15:21

BETA: Fixing some typos in SystemMessageId.
----------------------------------------------------------------------------
r5203 | MELERIX | 2012-02-27 00:05:20

BETA: Sysmsg for safe enchants failed, also code format/cleanup, thanks nonom for test.
----------------------------------------------------------------------------
r5202 | Zoey76 | 2012-02-26 23:25:31

BETA: More NPE fixes for [5185], thanks Tavo22 for report and skyshadow for fix.
----------------------------------------------------------------------------
r5201 | MELERIX | 2012-02-26 16:59:27

BETA: Updated Copyright info a bit and code format/cleanup.
----------------------------------------------------------------------------
r5200 | MELERIX | 2012-02-26 16:33:20

BETA: Minor typo fix in '''TownManager.java''', thanks _Blade_.
----------------------------------------------------------------------------
r5199 | Zoey76 | 2012-02-26 02:23:03

BETA: Moving ClanWarehouse to proper package.
----------------------------------------------------------------------------
r5198 | Zoey76 | 2012-02-26 02:15:13

BETA: Listeners fixes:
* NPE Fix for ClanWarehouse, thanks Starter and Tavo22 for report.
* Fix for typo on Item Tracker, thanks Starter for report.
----------------------------------------------------------------------------
r5197 | Nik | 2012-02-25 15:13:57
----------------------------------------------------------------------------
r5196 | Nik | 2012-02-25 15:12:31

BETA: A little more info for the MaxAdena config that some of you asked me for.
----------------------------------------------------------------------------
r5195 | GodKratos | 2012-02-25 05:16:59

BETA: Fix ClassMaster error
----------------------------------------------------------------------------
r5194 | Zoey76 | 2012-02-25 01:18:17

BETA: Improving UseItem's log and avoiding flood in logs.
* Unmanaged Item handler: means there is an item handler defined in XML, but doesn't have a Java counterpart.
* No item handler registered: means the items doesn't have an item handler defined in XML, yet the client request it's use.
----------------------------------------------------------------------------
r5193 | Nik | 2012-02-24 18:03:55

BETA: Adding a config for maximum adena. Better throw all those gold bars to the trash because now you can set values as big as this: '''9 223 372 036 854 775 807 - nine quintillion two hundred twenty three quadrillion three hundred seventy two trillion thirty six billion eight hundred fifty four million seven hundred seventy five thousand eight hundred seven'''.
If your server reach this value, you really have to lower the rates
----------------------------------------------------------------------------
r5192 | Zoey76 | 2012-02-24 07:05:48

BETA: Implementing more skill trees:
* Removed hardcoded GMSkillTable.
* Removed hardcoded HeroSkillTable.
* Removed hardcoded NobleSkillTable.
* Implemented support for XML new skill trees.

This represents a cleanup and unification of core functions.
----------------------------------------------------------------------------
r5191 | Zoey76 | 2012-02-23 15:59:41

BETA: Fix for for Hero diary from [5145], thanks Vulcan and tukune for report.
----------------------------------------------------------------------------
r5190 | Zoey76 | 2012-02-23 03:10:07

BETA: Fixing few methods naming:
* getHasFort() to getFortId()
* getHasCastle() to getCastleId()
* getHasHideout() to getHideoutId()
* setHasFort(..) to setFortId(..)
* setHasCastle(..) to setCastleId(..)
* getHasHideout(..) to setHideoutId(..)
* Fixed JavaDocs related to those methods.
----------------------------------------------------------------------------
r5189 | Zoey76 | 2012-02-23 03:06:45

BETA: NullPointerException fix, thanks tukune for report.
----------------------------------------------------------------------------
r5188 | Zoey76 | 2012-02-22 16:52:10

BETA: Olympiad rework:
* Unnecessary float cast/math round.
* Writing to static field from instanced method.
* Wrong usage of objects and maps, if you get a reference from an object in a map and update it (the object, for example using a method to update a parameter), '''is not required to remove and then put the object again''', __unless you have created a new object instance__, where '''also is not required to remove'''! put(..) ''method will replace/update given the proper key and the old value will be returned, if not existent return null.''
* CompetitionType class formatting.
* Some other minor fixes.

This fixes unexpected endless loops and data inconsistency and improves performance.

'''Note:''' Report bugs at [viewtopic.php?f=69&t=24536 Olympiad rework] topic.
----------------------------------------------------------------------------
r5187 | Zoey76 | 2012-02-22 15:27:06

BETA: [5186] to beta branch and other minor changes.
----------------------------------------------------------------------------
r5185 | UnAfraid | 2012-02-21 15:40:00

BETA: Implementation of Listeners thanks theone
A bit cleaned and tweaked by me and Zoey76.
----------------------------------------------------------------------------
r5184 | Zoey76 | 2012-02-20 21:52:52

BETA: ClassCastException fix for ClanHallSiegeEngine.
----------------------------------------------------------------------------
r5183 | Zoey76 | 2012-02-20 21:48:52

BETA: Generalizing rate configuration for fishes for all extractable skills/items.
----------------------------------------------------------------------------
r5181 | Zoey76 | 2012-02-18 15:54:59

BETA: Moving Extractable skill handler to effects:
* Improved formatter a bit.
* Implemented ConditionTargetInvSize:
* Allows to check inventory size conditions on target.
* Implemented ConditionTargetWeight
* Allows to check weight gauge conditions on target.
* Reworked the way Extractable skills data is parsed.
* Removed old skill types and added RESTORATION_RANDOM effect type.
----------------------------------------------------------------------------
r5180 | Zoey76 | 2012-02-18 15:17:49

BETA: Items reuse implementation:
* Item handlers return true on successful usage, false otherwise.
* Implemented item reuse delay and shared reuse group.
* Implemented database persistence for item reuse time.
* Moved reuse stamps for skills to FastMap as they originally were.
* Reworked TimeStamp class and moved out of L2PcInstance.
* Added proper JavaDocs to L2ItemInstance.
* Unhardcoded Calculator.
----------------------------------------------------------------------------
r5179 | Zoey76 | 2012-02-16 11:12:15

BETA: Addressing the problem of unchecked casting in AugmentationData.
----------------------------------------------------------------------------
r5178 | MELERIX | 2012-02-16 03:04:39

BETA: Fix for Ticket #2844 by anónimo (please next time post the fix in forum, not trac).
----------------------------------------------------------------------------
r5177 | Zoey76 | 2012-02-13 22:42:32

BETA: Misc fixes:
* Typo fixes in comments.
* Deleted useless comments.
* Typo fixes in logs.
* Added missing GPL notice.
* Updated some GPL notices.
* Formatted and cleaned up some classes.
* Moved misplaced author JavaDoc.

'''Note:''' Takes few minutes check misspellings, misplaced comments, GPL notice, JavaDocs, but takes years to get fixed after they get committed, please check before commit
----------------------------------------------------------------------------
r5176 | MELERIX | 2012-02-11 20:12:26

BETA: Reverting [5168] due is not working as should.
----------------------------------------------------------------------------
r5175 | UnAfraid | 2012-02-11 17:59:49

BETA: Moving all util methods from QuestState to Quest class to be usable directly from quests which doesn't really needs to implement QuestState.
Backward compatibility still remains until all quests are re-writen in java.
----------------------------------------------------------------------------
r5174 | UnAfraid | 2012-02-11 14:04:07

BETA: Little more of [5173]
----------------------------------------------------------------------------
r5173 | UnAfraid | 2012-02-11 12:07:14

BETA: Support for setTeam for all L2Character extending classes
----------------------------------------------------------------------------
r5172 | UnAfraid | 2012-02-10 12:31:19

BETA: StatsSet class format
----------------------------------------------------------------------------
r5171 | MELERIX | 2012-02-09 02:37:14

BETA: Re-Added [5167] & [5168] '''please don't remove this! because is used for safe check (for example when character is deleted from outside game, directly in db from a admin website or manually), like we do with others SQL Queries there'''.
----------------------------------------------------------------------------
r5170 | UnAfraid | 2012-02-09 02:07:47

BETA: Handing [5167:5168] where it should be.
----------------------------------------------------------------------------
r5169 | Zoey76 | 2012-02-08 12:58:39

BETA: Avoiding boxing/unboxing of int and boolean.
Continuing with [4451].

'''Note:''' valueOf(..) returns an object, this is useful when using List/Map (not Trove ones), if it's only required an int (or boolean) use parseInt(..) (or parseBoolean(..)).
----------------------------------------------------------------------------
r5168 | MELERIX | 2012-02-08 10:28:28

BETA: Small SQL Query Improvement for [5167].
----------------------------------------------------------------------------
r5167 | MELERIX | 2012-02-08 08:36:17

BETA: Added clean up for invalid Weddings.
----------------------------------------------------------------------------
r5166 | Zoey76 | 2012-02-06 00:33:55

BETA: Simplified support for daily quests by UnAfraid.
Spelling fixes in L2Character comments by me.

'''Usage:''' Exit quests using exitQuest(QuestType.DAILY); the quest will be completed and a penalty will be added, use isNowAvailable() to verify if the quest is available.
----------------------------------------------------------------------------
r5165 | UnAfraid | 2012-01-31 23:41:22

BETA: Warnings cleanup
----------------------------------------------------------------------------
r5164 | UnAfraid | 2012-01-31 23:40:13

BETA: Half-Kill is now possible against monsters in h5.
----------------------------------------------------------------------------
r5163 | Zoey76 | 2012-01-31 14:02:59

BETA: Misc fixes:
* NpcTable logs and iteration changes.
----------------------------------------------------------------------------
r5162 | Nik | 2012-01-30 10:23:54

BETA: Seal of Limit blocks Vampiric Rage effects also. Ruoff confirmed.
----------------------------------------------------------------------------
r5161 | Zoey76 | 2012-01-30 06:12:19

BETA: Fix for disarm weapon logic:
* If there is no weapon to disarm should return true. Typo from [5049].
* Fixes check with mounts.
* Fixes check with Rent Pets.
* Added some comments and fixed some JavaDocs.

Thanks burrito.
----------------------------------------------------------------------------
r5160 | Zoey76 | 2012-01-29 09:03:51

BETA: Fix for Squad skills not available for sub-pledges, skill display require retail confirmation.
----------------------------------------------------------------------------
r5159 | Zoey76 | 2012-01-29 09:00:24

BETA: Partially reverting AccountingFormatter changes from [5057], fall-though case is intended, this will restore player name/IP logging, thanks Vulcan for report.
----------------------------------------------------------------------------
r5158 | Zoey76 | 2012-01-28 10:01:13

BETA: Reverting [5157] and fixing minor typo in [5156].

'''Note:''' Fix typos, don't revert improvements.
----------------------------------------------------------------------------
r5157 | MELERIX | 2012-01-28 02:28:20

BETA: Minor Fix for Util.java, (when date is not null shouldn't return null).
----------------------------------------------------------------------------
r5156 | Zoey76 | 2012-01-27 20:18:01

BETA: Review and minor fixes for recent commits:
* checkSkillCastConditions JavaDoc fixes, comments and use of short circuit logic.
* L2VillageMasterInstance added own logger, cleanup for isValidName(..) method.
* Inventory own logger, JavaDoc fixes, use of ternary operators.
* PcInventory own logger.
* DecayTaskManager removed unnecessary try/catch, remove(..) doesn't throw NoSuchElementException, fixed NPE vulnerability, reused one method.
* gameserver/Util formatted and method formatDate changed, there is no need to instantiate the DateFormat if the date is null.
----------------------------------------------------------------------------
r5155 | UnAfraid | 2012-01-27 19:46:27

BETA: Adding some basic methods like isPlayer, isMonster, etc..
Defined in L2Object and overrided in the necessary classes to avoid castings.
----------------------------------------------------------------------------
r5154 | UnAfraid | 2012-01-26 18:42:57

BETA: Reverting [5144] it can cause inconsistency in db.
----------------------------------------------------------------------------
r5153 | MELERIX | 2012-01-26 05:33:26

BETA: nextActionAttack should also consider that target is Attackable.
----------------------------------------------------------------------------
r5152 | Zoey76 | 2012-01-25 22:24:05

BETA: Core cleanup after [DP8648], if you want to keep backward compatibility skip this change set.
----------------------------------------------------------------------------
r5151 | UnAfraid | 2012-01-25 22:16:05

BETA: One more enchant related config MaxEnchantLevel
It will be used only for default value (When you haven't added maxEnchantLevel="XX") to enchants.

----------------------------------------------------------------------------
r5150 | Zoey76 | 2012-01-25 09:35:20

BETA: Misc fixes for [5146]
* Comments fixes and cleanup in Formulas.
* Fixed logger in Formulas.
* Comments fixes and cleanup in ConditionListener.
* BaseStats shouldn't NPE if statBonus.xml is not valid.
----------------------------------------------------------------------------
r5149 | Zoey76 | 2012-01-25 07:35:07

BETA: Reworks:
* Env OOP rework.
* Conditions cleanup and format.
* Formulas cleanup and format, more to come, lots of unused methods.
* Funcs cleanup and format.
* Deleting more empty folders.

'''Note:''' Apologies to the forks and contributors for huge latest change sets, at some point this changes had to be done.
----------------------------------------------------------------------------
r5148 | UnAfraid | 2012-01-24 13:40:36

BETA: Typo fix after [5146] thanks Battlecruiser
----------------------------------------------------------------------------
r5147 | Zoey76 | 2012-01-24 08:14:57

BETA: More misc changes:
* Using default encode for all files (except shell scripts), requested by MELERIX.
* Deleting empty folders from [5146].
* Renaming hitConditionBonus to HitConditionBonus.
----------------------------------------------------------------------------
r5146 | Zoey76 | 2012-01-24 06:26:19

BETA: Classes rearranging:
* Moving char/npc templates to model/actor/templates.
* Moving skill related classes to model/skills/.
* Moving effect related classes to model/effects/.
* Moving some other related classes to model/items or model/skills.
* Moving conditions to model/conditions (they're not for skills only).
* Moving DocumentBase, DocumentItem, DocumentSkill to engines/.
* Renaming SkillEngine to DocumentEngine (it's not for skills only).
* Renaming L2SummonInstance to L2ServitorInstance, summons are all "summoned" NPCs such as pets and servitors, servitors are those summoned by class skills.
* Added L2SkillOpType enum, contains current operative types and new ones.
* Added EffectState enum.

'''Note:''' Empty folders and minor fixes will be done in following commits, due Trac's limitations.
----------------------------------------------------------------------------
r5145 | Zoey76 | 2012-01-23 18:53:52

BETA: Misc fixes:
* NPE vulnerability for _partys in L2CommandChannel.
* In L2Manor if seeds.xml is not valid it shouldn't NPE.
* NPE vulnerability for clan in Fort.
* Hero rework.
1. Performance fixes, using entries instead iterating over keys and getting the values.
1. Cleanup.
1. Fixed static variables assigned in instanced methods.
* Useless cast to float and then round in Siege.
* In MailSystem if MailList.xml is not valid it shouldn't NPE.
* Reverting [5143], hiding the problem won't fix it.
* Finalizing L2LoginServer class, uses Thread.start() in constructor if it's sub-classed the superclass thread will start before the sub-classed constructor is initialized.
----------------------------------------------------------------------------
r5144 | UnAfraid | 2012-01-20 19:24:29

BETA: Closing the unclosed connections when got catch thanks Sylar88 for report.
----------------------------------------------------------------------------
r5143 | Nik | 2012-01-20 10:51:14

BETA: Do not restore items that already exist in OID map. Now you will have less OID spams in your console
----------------------------------------------------------------------------
r5142 | MELERIX | 2012-01-20 06:13:05

Importing BeanShell Engine (NOTE: This libs require updates for Java 7 also recompile).
----------------------------------------------------------------------------
r5140 | Zoey76 | 2012-01-20 02:22:06

BETA: Getting rid of printStackTrace()
* Continued [4187] and [4184]
----------------------------------------------------------------------------
r5139 | MELERIX | 2012-01-19 22:37:01

BETA: Support for allowStore boolean in zones, thanks Zoey76 for help.
----------------------------------------------------------------------------
r5138 | UnAfraid | 2012-01-18 17:22:06

Support for Custom Items thanks to Gnacik and L2jfree for the idea
This wont let you change the item name or item description but will let you use custom item id but with already existing one in the client so basicly if u create item that you need to looks like adena
just put in it <set name="displayId" val="57" /> and it will be exactly as adena for the client but not for the server ^^
----------------------------------------------------------------------------
r5137 | Zoey76 | 2012-01-16 09:09:34

BETA: Fix for SQL Exceptions after [5098] and [5100], thanks marcose for report.
----------------------------------------------------------------------------
r5136 | MELERIX | 2012-01-16 05:09:19
----------------------------------------------------------------------------

[Zoey76]

SPOILER:

r8950 | MELERIX | 2012-06-27 20:03:13

BETA/COMMUNITY/LIBS: Updated WTP Settings.
----------------------------------------------------------------------------
r8949 | MELERIX | 2012-06-27 19:06:06

BETA/COMMUNITY/LIBS: Builders Updates.
----------------------------------------------------------------------------
r8948 | Adry_85 | 2012-06-26 07:31:12

BETA: DP-Part for ?[L5458].
----------------------------------------------------------------------------
r8947 | MELERIX | 2012-06-26 01:06:04

BETA: DoorId 21160502 should be open by default, thanks '''Tavo22''' for report.
----------------------------------------------------------------------------
r8946 | MELERIX | 2012-06-25 21:01:57

BETA: Updated/Fixed '''Stun Shot''' Skill.
----------------------------------------------------------------------------
r8945 | MELERIX | 2012-06-24 01:22:12
----------------------------------------------------------------------------
r8944 | MELERIX | 2012-06-24 01:20:38

BETA: The Rest of Aerial Cleft Zones.
----------------------------------------------------------------------------
r8943 | MELERIX | 2012-06-23 23:16:58

BETA: Cleanup.
----------------------------------------------------------------------------
r8942 | MELERIX | 2012-06-23 17:15:06

BETA: [7918] to offensive instead of neutral.
----------------------------------------------------------------------------
r8941 | MELERIX | 2012-06-21 02:02:06

BETA: Fix for Ticket #4851.
----------------------------------------------------------------------------
r8940 | MELERIX | 2012-06-20 22:32:42

BETA: Missing Eilhalder Von Hellmann from [8938].
----------------------------------------------------------------------------
r8939 | MELERIX | 2012-06-20 22:01:34

BETA: Fixed GrandBosses respawn times formula.
----------------------------------------------------------------------------
r8938 | MELERIX | 2012-06-20 21:40:26

BETA: Fixed some RaidBosses respawn times.
----------------------------------------------------------------------------
r8937 | MELERIX | 2012-06-19 22:42:19

BETA: Fixed few NPC types.
----------------------------------------------------------------------------
r8936 | MELERIX | 2012-06-19 22:27:07

BETA: Fixed Buffer/Player Spawns for Orbis Arena.
----------------------------------------------------------------------------
r8935 | MELERIX | 2012-06-18 21:25:42

BETA/COMMUNITY/LIBS: Minor update for builders.
----------------------------------------------------------------------------
r8934 | Adry_85 | 2012-06-18 18:42:12

BETA: Datapack part for ?[L5439].
----------------------------------------------------------------------------
r8933 | Zoey76 | 2012-06-17 23:06:06

BETA: Minor skills update:
* Parameter values True/False to true/false.
* Removed invalid condition system message from Sweeper (42) skill.
----------------------------------------------------------------------------
r8932 | Zoey76 | 2012-06-17 21:51:22

BETA: NPE vulnerability fix for find_ip command, thanks Tavo22 for report.
----------------------------------------------------------------------------
r8931 | Zoey76 | 2012-06-17 19:09:17

BETA: Datapack part for [L5438]:
* Removed/fixed non-required chance parameters.
* Removed invalid system message for Infinity Rod trigger skill.
----------------------------------------------------------------------------
r8930 | MELERIX | 2012-06-16 19:21:20

BETA: DP-Part for [L5436].
----------------------------------------------------------------------------
r8929 | Zoey76 | 2012-06-16 15:46:59

BETA: Fix for NoSuchElementException in reload command, thanks DareStrike for report.
----------------------------------------------------------------------------
r8928 | Nik | 2012-06-16 11:40:17

BETA: 10282_ToTheSeedOfAnnihilation typo fix. Now players with lvl 84 or above will be able to take the quest (previously only lower levels could take it... lol)
----------------------------------------------------------------------------
r8927 | Zoey76 | 2012-06-16 00:09:29

BETA: Datapack part for [L5433]:
* Reworked PetFood item handler.
----------------------------------------------------------------------------
r8926 | Zoey76 | 2012-06-15 21:46:11

BETA: Reworked Harvesting skill to use an effect (as it does in retail).
* Fixed few typos in skill parameters.
* Removed skill type.
* Minor rework in the code.
----------------------------------------------------------------------------
r8925 | MELERIX | 2012-06-15 16:10:39

BETA: Updated some Boss Spawns.
----------------------------------------------------------------------------
r8924 | MELERIX | 2012-06-15 12:50:43

BETA: Servitor Summon Skills casting time is decreased from 15 seconds to 6 seconds in H5.
----------------------------------------------------------------------------
r8923 | Adry_85 | 2012-06-15 07:16:32

BETA: Updated to H5 '''Summon Feline King''', '''Summon Magnus the Unicorn''' and '''Summon Spectral Lord''' skills.
----------------------------------------------------------------------------
r8922 | MELERIX | 2012-06-14 16:59:32

BETA: Missing H5 Doors from 8851.
----------------------------------------------------------------------------
r8921 | MELERIX | 2012-06-14 14:06:56

BETA: DP-Part for [L5429].
----------------------------------------------------------------------------
r8920 | Zoey76 | 2012-06-13 22:31:14

BETA: Datapack part for [L5427].
----------------------------------------------------------------------------
r8919 | MELERIX | 2012-06-13 11:32:15

BETA: Fixed Spawn for NPC 32010.
----------------------------------------------------------------------------
r8918 | MELERIX | 2012-06-12 20:46:24

BETA: Added Some FIXME messages in skills.
----------------------------------------------------------------------------
r8917 | MELERIX | 2012-06-12 20:11:20

BETA: Fix for Ticket #5317.
----------------------------------------------------------------------------
r8916 | Zoey76 | 2012-06-12 16:23:04

BETA: Fix for Quests:
* Thanks goncafa, kostantinos and Tavo22 for report.
* Closing #6199
* Thanks FBIagent for fix implementations and comments.
* Thanks jurchiks for the code improvement and code suggestions.
----------------------------------------------------------------------------
r8915 | MELERIX | 2012-06-12 14:17:55

BETA: Few typo fixes in skills.
----------------------------------------------------------------------------
r8914 | MELERIX | 2012-06-12 14:10:22

BETA: Updated/Fixed Spoil & Spoil Festival Skills.
----------------------------------------------------------------------------
r8913 | MELERIX | 2012-06-11 22:48:07

BETA: Updated Enchant Skill Chances.
----------------------------------------------------------------------------
r8912 | MELERIX | 2012-06-11 21:51:50

BETA: SP required for acquiring some of the skills of the Third Class is reduced in H5.
----------------------------------------------------------------------------
r8911 | Zoey76 | 2012-06-10 22:27:27

BETA: Admin Siege command handler rework:
* Added Javadocs.
* Replaced if/else statement with ternary operations.
* Replaced if/else if statements for string comparison with switch statement.
* Replaced try/catch statement for numbers with Util.isDigit(String).
* Fixed faulty logic that, which was flagged with possible null pointer access.
* Fixed other redundant pieces of code.
----------------------------------------------------------------------------
r8910 | MELERIX | 2012-06-10 10:24:07

BETA: Minor update for pcBaseStats.xml.
----------------------------------------------------------------------------
r8909 | MELERIX | 2012-06-08 22:14:27

BETA: DP-Part for [L5412].
----------------------------------------------------------------------------
r8908 | Zoey76 | 2012-06-08 22:08:15

BETA: Typo fix for Skill transfer validator, thanks d!g0.
----------------------------------------------------------------------------
r8907 | MELERIX | 2012-06-08 16:59:31

BETA: Updated Spawn Position for NPC 32568 to H5, thanks Katako.
----------------------------------------------------------------------------
r8906 | MELERIX | 2012-06-07 12:06:05
----------------------------------------------------------------------------
r8905 | MELERIX | 2012-06-07 12:02:57

BETA: Minor change for database_installers and few skill fixes.
----------------------------------------------------------------------------
r8904 | Adry_85 | 2012-06-07 11:24:04

BETA: DP-Part for ??[L5410].
----------------------------------------------------------------------------
r8903 | MELERIX | 2012-06-05 14:52:56

BETA: Minor fix for Skill 1542, thanks '''Tavo22''' for report.
----------------------------------------------------------------------------
r8902 | MELERIX | 2012-06-05 02:24:30

BETA: Missing from [8896].
----------------------------------------------------------------------------
r8901 | MELERIX | 2012-06-05 01:40:43

BETA: Updated Bluff Skill.
----------------------------------------------------------------------------
r8900 | Zoey76 | 2012-06-04 23:11:42

BETA: .classpath format.

'''Note:''' Do not forget to cleanup your server lib folder!
----------------------------------------------------------------------------
r8899 | Zoey76 | 2012-06-04 23:08:03

BETA: The compiled libraries for core.
----------------------------------------------------------------------------
r8898 | MELERIX | 2012-06-03 11:48:16

BETA: Minor Cleanup for [L4509].
----------------------------------------------------------------------------
r8897 | Adry_85 | 2012-06-03 09:25:17

BETA: Cleanup for [L5394].
----------------------------------------------------------------------------
r8896 | Adry_85 | 2012-06-03 06:10:31

BETA: DP-Part for ?[L5394].
----------------------------------------------------------------------------
r8895 | MELERIX | 2012-06-02 21:26:28

BETA: Fix for Ticket #4802.
----------------------------------------------------------------------------
r8894 | MELERIX | 2012-06-02 07:37:45

BETA: Fixed two warnings.
----------------------------------------------------------------------------
r8893 | MELERIX | 2012-06-02 06:51:43

BETA: Removed skillTypes BUFF/PASSIVE from passive skills.
----------------------------------------------------------------------------
r8892 | GodKratos | 2012-06-01 18:36:26

BETA: Output location message for undefined regions. Requires [L5389]
----------------------------------------------------------------------------
r8891 | MELERIX | 2012-05-31 08:52:12

BETA: Fixing some triggered skills due it require support for conditions in effects (added TODO notes).
----------------------------------------------------------------------------
r8890 | MELERIX | 2012-05-31 07:08:37

BETA: DP-Part for [L5388].
----------------------------------------------------------------------------
r8889 | MELERIX | 2012-05-30 19:02:56

BETA: Fixing 511_AwlUnderFoot NPCs htmls, thanks digunan for report and Arantir for the fix.
----------------------------------------------------------------------------
r8888 | Zoey76 | 2012-05-30 15:19:22

BETA: Minor cleanup for [8866].
----------------------------------------------------------------------------
r8887 | Zoey76 | 2012-05-30 14:46:26

BETA: Using same warning settings than core and fixed some related warnings.
* Other warnings will be fixed later.
----------------------------------------------------------------------------
r8886 | MELERIX | 2012-05-30 05:30:16

BETA: Reverted [8885] (except skill fixes).
----------------------------------------------------------------------------
r8885 | MELERIX | 2012-05-30 04:07:47

BETA: The rest of [8883] and some skill fixes.
----------------------------------------------------------------------------
r8884 | MELERIX | 2012-05-29 23:53:10

BETA: Updated XSD for [8881].
----------------------------------------------------------------------------
r8883 | MELERIX | 2012-05-29 23:31:08

BETA: Cleanup for [L5385] (DUMMY skillTypes will be removed later after review skills).
----------------------------------------------------------------------------
r8882 | MELERIX | 2012-05-29 23:13:04

BETA: Changed some "triggered/OverTime" effects to skilltype BUFF, otherwise they can't be stolen/dispelled/shared with summon.
----------------------------------------------------------------------------
r8881 | UnAfraid | 2012-05-29 22:58:44

BETA: DP-Part for [L5384]
----------------------------------------------------------------------------
r8880 | MELERIX | 2012-05-29 01:44:42

BETA: Fixed Spawn for NPC 31653, also updated warning settings for [8878].
----------------------------------------------------------------------------
r8879 | Zoey76 | 2012-05-28 18:15:21

BETA: Minor typo fix for [8840], thanks FullMetal for report.
* Closing #5304
----------------------------------------------------------------------------
r8878 | Zoey76 | 2012-05-28 17:35:04

BETA: Datapack fixes:
* Avoiding synthetic access.
* Avoiding potential NPEs.
* Minor JavaDocs fixes.
* Added some TODO tasks.
----------------------------------------------------------------------------
r8877 | MELERIX | 2012-05-28 13:29:07

BETA: Missing abnormalVisualEffect in some disarm effects.
----------------------------------------------------------------------------
r8876 | UnAfraid | 2012-05-27 20:12:18

BETA: Fixing Frintezza instance bug when a monster self-destruct should trigger onKill thanks '''tukune'''
----------------------------------------------------------------------------
r8875 | UnAfraid | 2012-05-27 17:34:44

BETA: DP-Part for [L5382]
----------------------------------------------------------------------------
r8874 | MELERIX | 2012-05-27 03:08:13

BETA: Updated most of the triggered skills to use effects.
----------------------------------------------------------------------------
r8873 | Zoey76 | 2012-05-26 15:36:52

BETA: Territory War code improvements by jurchiks.
----------------------------------------------------------------------------
r8872 | Zoey76 | 2012-05-26 15:28:37

BETA: Fixes for No Secrets (251) by jurchiks.
----------------------------------------------------------------------------
r8871 | MELERIX | 2012-05-26 03:49:59

BETA: Small Improvement for [8870].
----------------------------------------------------------------------------
r8870 | MELERIX | 2012-05-26 03:41:11

BETA: Moved part of 20110831update.sql to 20110831maintenance.sql because should be executed only one time (manually by server admins and only updating from a L2J Server before 2011/08/31) not in every update or it will screw the date in "createDate" column at character table.
----------------------------------------------------------------------------
r8869 | MELERIX | 2012-05-25 19:53:27

BETA: Fix for Ticket #L6203.
----------------------------------------------------------------------------
r8868 | Adry_85 | 2012-05-22 07:10:01

BETA: Only "Expand Dwarven Craft" is exclusive for Dwarves.
----------------------------------------------------------------------------
r8867 | UnAfraid | 2012-05-21 20:28:49

BETA: Cleanup
----------------------------------------------------------------------------
r8866 | UnAfraid | 2012-05-21 20:25:02

BETA: Porting 9000_clan and 9001_alliance to java
----------------------------------------------------------------------------
r8865 | UnAfraid | 2012-05-21 19:28:39

BETA: Item Handlers rework:
* Unhardcoding most of skill ids
* Fixed some typos
* Added missing system messages
* Added some TODO: comments
* Decreasing range of shot skill broadcasts
----------------------------------------------------------------------------
r8864 | UnAfraid | 2012-05-21 18:19:43

BETA: DP-Part for [L5373]
----------------------------------------------------------------------------
r8863 | MELERIX | 2012-05-21 04:25:51

BETA: Changed some Skills with IncreaseCharges effect to DUMMY.
----------------------------------------------------------------------------
r8862 | MELERIX | 2012-05-21 04:20:05

BETA: Changed some NEGATE Skills to DUMMY.
----------------------------------------------------------------------------
r8861 | Zoey76 | 2012-05-20 18:09:33

BETA: Removing init() abstract method from L2Script.
----------------------------------------------------------------------------
r8860 | Zoey76 | 2012-05-20 17:16:17

BETA: Implementing Listeners for Skill Transfer's Holy Pomander reward.
Thanks Battlecruiser for first implementation.
----------------------------------------------------------------------------
r8859 | Zoey76 | 2012-05-20 16:37:43

BETA: Datapack for [L5366].
----------------------------------------------------------------------------
r8858 | MELERIX | 2012-05-20 15:33:13

BETA: Minor width fix for doorinfo.htm.
----------------------------------------------------------------------------
r8857 | UnAfraid | 2012-05-20 15:16:48

BETA: Visual glitch fix for pet owners that appeared to be healed when its pets received a heal.
* ExRegMax packet was sent to the Owner of a pet/servitor when it get healed by overtime effect but it shouldn't.
----------------------------------------------------------------------------
r8856 | MELERIX | 2012-05-20 14:38:18

BETA: Extra info for [8855] to avoid confusion.
----------------------------------------------------------------------------
r8855 | MELERIX | 2012-05-20 00:42:06

BETA: Minor fix for L2DoorInstanceActionShift to show min/max XYZ properly.
----------------------------------------------------------------------------
r8854 | MELERIX | 2012-05-19 20:23:23

BETA: Changed StealBuff.java to read MaxNegated instead of power.
----------------------------------------------------------------------------
r8853 | MELERIX | 2012-05-19 19:45:11

BETA: The service fee required for exchanging regular Pet equipment for higher-level equipment has been reduced by 50%.
----------------------------------------------------------------------------
r8852 | MELERIX | 2012-05-19 18:49:34

BETA: The price of Pet equipment has been reduced by 50%.
----------------------------------------------------------------------------
r8851 | GodKratos | 2012-05-19 05:16:23

BETA: DP-Part for ?[L5359]
----------------------------------------------------------------------------
r8850 | MELERIX | 2012-05-19 02:44:12

BETA: PARTY/CLAN healing Skills can be DUMMY already too (few others skills fixes included).
----------------------------------------------------------------------------
r8849 | MELERIX | 2012-05-18 20:08:49

BETA: Self healing Skills can be DUMMY already.
----------------------------------------------------------------------------
r8848 | MELERIX | 2012-05-18 15:53:20

BETA: Few typo fixes for [8845], thanks UnAfraid for report.
----------------------------------------------------------------------------
r8847 | Adry_85 | 2012-05-18 05:39:39

BETA: Added missing cleft peace zones.
----------------------------------------------------------------------------
r8846 | MELERIX | 2012-05-17 18:41:02

BETA: The casting time of Flame Armor Skill is decreased in H5.
----------------------------------------------------------------------------
r8845 | MELERIX | 2012-05-17 18:20:06

BETA: Possible fix for Ticket #4906.
----------------------------------------------------------------------------
r8844 | Adry_85 | 2012-05-17 16:17:11

BETA: Fixed Cancel effects to land in monsters too.
----------------------------------------------------------------------------
r8843 | MELERIX | 2012-05-16 22:41:30

BETA: Moved GM Access/Commands Settings to configs.
----------------------------------------------------------------------------
r8842 | MELERIX | 2012-05-16 20:03:43

BETA: Minor fix for skill 3592.
----------------------------------------------------------------------------
r8841 | MELERIX | 2012-05-15 22:47:03

BETA: Removed "update" boolean from Ant Zip Task, because it doesn't build the Zip file properly (doesn't remove the old files), and few other changes included for database_installers.
----------------------------------------------------------------------------
r8840 | Zoey76 | 2012-05-15 19:46:02

BETA: Fix for NumberFormatException in AdminAnnouncements, FullMetal for report and first implementation.
* Even when try-catch may be faster, we need our users to know where they mistaken sending a message with some info.
* Closing #6176
----------------------------------------------------------------------------
r8839 | MELERIX | 2012-05-14 23:09:54

BETA: Unseal Zaken/Frintezza/Freya Cloaks, thanks blacksea.

----------------------------------------------------------------------------
r8838 | MELERIX | 2012-05-13 22:31:17

BETA: Updated Exp Reward of 3rd Class Transfer Quest.
----------------------------------------------------------------------------
r8837 | MELERIX | 2012-05-13 22:15:59

BETA: Updated Exp/Sp/Adena Reward of 2nd Class Transfer Quests.
----------------------------------------------------------------------------
r8836 | MELERIX | 2012-05-13 17:25:37

BETA: Updated Adena Reward (where is not updated or missing) of 1st Class Transfer Quests.
----------------------------------------------------------------------------
r8835 | MELERIX | 2012-05-13 03:36:51

BETA: Added reuseDelay for Mana Potions Skills.
----------------------------------------------------------------------------
r8834 | MELERIX | 2012-05-13 01:28:51

BETA: Minor Fix for skill 914 (thanks badboy29 for report and test).
----------------------------------------------------------------------------
r8833 | MELERIX | 2012-05-12 01:55:52

BETA: Minor Update for AdminBan.java (-1 for ban, not -100).
----------------------------------------------------------------------------
r8832 | MELERIX | 2012-05-11 23:05:14

BETA: I forgot to rename this -.-, thanks Zoey76 for report.
----------------------------------------------------------------------------
r8831 | Zoey76 | 2012-05-11 22:08:25

BETA: Fixing some error in logic for item skill's handler.
----------------------------------------------------------------------------
r8830 | MELERIX | 2012-05-11 22:05:01

BETA: Builders Changes.
----------------------------------------------------------------------------
r8829 | Adry_85 | 2012-05-11 11:50:32

BETA: Deleted Trader Zenith spawn, it was removed since Freya chronicle.
----------------------------------------------------------------------------
r8828 | UnAfraid | 2012-05-11 00:46:30

BETA: DP-Part for [L5330]
----------------------------------------------------------------------------
r8827 | UnAfraid | 2012-05-10 22:13:51

BETA: Sharing hero buffs with Servitors
----------------------------------------------------------------------------
r8826 | Zoey76 | 2012-05-10 22:07:30

BETA: Datapack part for [L5327]:
* Fixing some voiced commands and implementing missing actions.
* StatsVCmd fix by brutus, thanks.
----------------------------------------------------------------------------
r8825 | MELERIX | 2012-05-10 20:02:49

BETA: Reverted [8824] it should be fixed in a different way.
----------------------------------------------------------------------------
r8824 | MELERIX | 2012-05-10 14:58:44

BETA: Even the buffs that can't be stolen are shared with Servitors (thanks badboy29 for testing).
----------------------------------------------------------------------------
r8823 | MELERIX | 2012-05-10 14:42:38

BETA: Chest Caught Quests from Jython to Java by '''nonom''' (thanks '''Adry_85''' for testing).
----------------------------------------------------------------------------
r8822 | MELERIX | 2012-05-10 14:25:44

BETA: Remove old Fear hardcoded restrictions (used due patchnotes before IL/CT1), thanks Copyleft.
----------------------------------------------------------------------------
r8821 | Adry_85 | 2012-05-10 11:43:41

BETA: Fixing duplicated adena in some multisells.
----------------------------------------------------------------------------
r8820 | MELERIX | 2012-05-09 17:41:18

BETA: DP-Part for [L5323].
----------------------------------------------------------------------------
r8819 | Zoey76 | 2012-05-09 15:21:14

BETA: Minor fix in ItemSkillTemplate, for items used by pets.
* Thanks for report and tests:
* DareStrike
* thecast
* MELERIX
* Closed #5251
----------------------------------------------------------------------------
r8818 | Zoey76 | 2012-05-09 15:07:32

BETA: Minor fix for Polymorph admin command by jurchiks.
----------------------------------------------------------------------------
r8817 | UnAfraid | 2012-05-08 22:50:32

BETA: More for [8816]
* Validating target not gm it's self
* Cleanup
----------------------------------------------------------------------------
r8816 | UnAfraid | 2012-05-08 22:39:16

BETA: Restrictions added in [8814] must apply only for admin_transform command
----------------------------------------------------------------------------
r8815 | Adry_85 | 2012-05-08 11:14:03

BETA: Fixing "Lanosco's Special Bait" quest.
----------------------------------------------------------------------------
r8814 | MELERIX | 2012-05-07 11:08:55

BETA: Missing SysMsgs for restrictions.
----------------------------------------------------------------------------
r8813 | MELERIX | 2012-05-06 15:40:03

BETA: Fix for Ticket #L5486, and some others small changes.
----------------------------------------------------------------------------
r8812 | Zoey76 | 2012-05-05 18:53:59

BETA: Quest improvements by jurchiks:
* No Secrets??(251)
* How to Oppose Evil(692)
* Light Fragment(10272)
----------------------------------------------------------------------------
r8811 | MELERIX | 2012-05-05 17:36:03

BETA: Fixes for Infinity Weapons being triggered twice (also updated & verified passive skills).
----------------------------------------------------------------------------
r8810 | MELERIX | 2012-05-05 02:35:42

BETA: DP-Part for [L5316].
----------------------------------------------------------------------------
r8809 | MELERIX | 2012-05-04 23:10:10
----------------------------------------------------------------------------
r8808 | MELERIX | 2012-05-04 23:07:18

BETA: Updated some Doors parameters (unlockable, start_opened, targetable), also added some missing Doors.
----------------------------------------------------------------------------
r8807 | Nik | 2012-05-02 17:40:48

BETA: Rare NPE fix.
----------------------------------------------------------------------------
r8806 | Nik | 2012-05-02 17:35:25

BETA: Class cast exception error fix. The return in the switch doesnt always return empty target list, and since there is no break in the case, it falls down and causes the error.
----------------------------------------------------------------------------
r8805 | Zoey76 | 2012-05-01 20:08:23

BETA: Datapack part for [L5310].
----------------------------------------------------------------------------
r8804 | UnAfraid | 2012-04-30 14:58:05

BETA: DP-Part for [L5308]
----------------------------------------------------------------------------
r8803 | MELERIX | 2012-04-30 12:38:49

BETA: Improvements for "database_installer.sh" (thanks nonom for testing), also some updates for "database_installer.bat".
----------------------------------------------------------------------------
r8802 | MELERIX | 2012-04-28 05:03:42

BETA: DP-Part for [L5300].
----------------------------------------------------------------------------
r8801 | MELERIX | 2012-04-28 03:56:51

BETA: Color for Master Access Level is 00CCFF.
----------------------------------------------------------------------------
r8800 | MELERIX | 2012-04-28 02:52:07

BETA: Replaced negateId with negateAbnormals in skills to match retail, and some more XSDs fixes.
----------------------------------------------------------------------------
r8799 | MELERIX | 2012-04-28 01:18:27

BETA: Fixed XSDs from [8795] & [8798].
----------------------------------------------------------------------------
r8798 | UnAfraid | 2012-04-28 00:07:03

BETA: DP-Part for [L5299]
----------------------------------------------------------------------------
r8797 | MELERIX | 2012-04-27 22:23:19

BETA: Moved 20120428 SQL Update to maintenance, because should be executed only one time manually by server admins, not in every update or it will screw all GM Access Levels.
----------------------------------------------------------------------------
r8796 | UnAfraid | 2012-04-27 21:45:14

BETA: DP-Part for [L5293]
Also Added new command script_unload //id / script name
----------------------------------------------------------------------------
r8795 | UnAfraid | 2012-04-27 20:04:44

BETA: DP-Part for [L5289]
----------------------------------------------------------------------------
r8794 | Zoey76 | 2012-04-27 19:13:49

BETA: Datapack part for [L5287].
----------------------------------------------------------------------------
r8793 | MELERIX | 2012-04-27 05:36:02

BETA/OTHERS: Minor Changes in the Builders for Ant Zip Task.
----------------------------------------------------------------------------
r8792 | MELERIX | 2012-04-27 05:04:31

BETA: Enchant Routes for "Resist Earth" skill (thanks '''Battlecruiser'''), also fixed operateType.
----------------------------------------------------------------------------
r8791 | MELERIX | 2012-04-24 23:03:27

BETA: DP-Part for [L5282].
----------------------------------------------------------------------------
r8790 | Zoey76 | 2012-04-22 19:21:36

BETA: Cleanup related to [L5278]:
* Moved servername.xml and servername.xsd to login/data.
* Is not used by game server, server name is sent by login server.
* misc folder will be removed in next commit.
* Updated build.xml.
----------------------------------------------------------------------------
r8789 | Zoey76 | 2012-04-22 13:36:59

BETA: Standardizing daily quests by nonom.
* Rumble in the Base (461)
* I Must Be a Genius (463)
* Olympiad Starter (551)
* Olympiad Veteran (552)
* Olympiad Undefeated (553)
----------------------------------------------------------------------------
r8788 | Zoey76 | 2012-04-21 23:49:13

BETA: Minor update for instance.xsd schema by Copyleft.
----------------------------------------------------------------------------
r8787 | MELERIX | 2012-04-21 20:52:06

BETA: Updated some RaidBoss positions and deleted an old RaidBoss (Necrosentinel Royal Guard) that is not Spawned anymore in H5, also updated NpcId of Dr Chaos AI.
----------------------------------------------------------------------------
r8786 | Zoey76 | 2012-04-21 14:57:32

BETA: Datapack typo fixes by Tavo22:
* Armor Sets: Wrong skill Id. (The Note was fine, but the Id was wrong).
* Skill Trees: Wrong level. (Confirmed at PowerWiki).
----------------------------------------------------------------------------
r8785 | MELERIX | 2012-04-15 19:57:52

BETA: Start Points Data for future usage.
----------------------------------------------------------------------------
r8784 | UnAfraid | 2012-04-15 08:51:20

BETA: NPE Fixes thanks Starter for report.
----------------------------------------------------------------------------
r8783 | MELERIX | 2012-04-12 20:29:48

BETA: DP-Part for [L5268].
----------------------------------------------------------------------------
r8782 | MELERIX | 2012-04-12 02:04:52

BETA: Fishing Rods Data for future usage.
----------------------------------------------------------------------------
r8781 | MELERIX | 2012-04-11 21:56:30

BETA: Fixed PVP Armor Sets triggered skills.
----------------------------------------------------------------------------
r8780 | Zoey76 | 2012-04-11 18:53:45

BETA: Datapack part for [L5266].
----------------------------------------------------------------------------
r8779 | UnAfraid | 2012-04-11 13:26:44

BETA: Little typo in quest Rumble In The Base
Note: Keep in mind when you set some variable to quest state it get's wiped out on quest complete so you must set it after exitQuest()
----------------------------------------------------------------------------
r8778 | Zoey76 | 2012-04-08 22:42:22

BETA: Datapack part for [L5261].
----------------------------------------------------------------------------
r8777 | Zoey76 | 2012-04-07 00:00:17

BETA: Minor datapack part for [L5258].
----------------------------------------------------------------------------
r8776 | MELERIX | 2012-04-06 15:10:40

BETA: Few missing XML enconding info.
----------------------------------------------------------------------------
r8775 | MELERIX | 2012-04-06 14:57:01

BETA: Fixed some XSD References and some more for [8774].
----------------------------------------------------------------------------
r8774 | UnAfraid | 2012-04-06 07:02:03

BETA: Multisells update removing extra tags if applyTaxes="true" is defined isTaxIngredient="true" is not required since it applies for all the multisells inside that list.
----------------------------------------------------------------------------
r8773 | UnAfraid | 2012-04-04 21:17:38

BETA: Minor typo fix in Quest '''Exploration of the Giants Cave Part 2'''
----------------------------------------------------------------------------
r8772 | MELERIX | 2012-04-03 20:18:26

BETA: Minor Fix for Initial Equipment, thanks Starter.
----------------------------------------------------------------------------
r8771 | UnAfraid | 2012-04-02 22:10:32

BETA: Simplify some checks in Recipes item handler.
----------------------------------------------------------------------------
r8770 | MELERIX | 2012-04-02 21:13:28

BETA: Removed two unnecessary semicolons.
----------------------------------------------------------------------------
r8769 | UnAfraid | 2012-04-02 19:19:17

BETA: Removing backward compatibility for L2Party/L2CommandChannel if you want it skip that changeset thanks Battlecruiser
----------------------------------------------------------------------------
r8768 | MELERIX | 2012-04-01 05:59:40

BETA: Updating Flagpoles' positions.
----------------------------------------------------------------------------
r8767 | MELERIX | 2012-04-01 05:14:16

BETA: Removed custom wyvern summon_item, and updated proper description.
----------------------------------------------------------------------------
r8766 | MELERIX | 2012-03-30 06:35:38

BETA: Standardizing few XSD files.
----------------------------------------------------------------------------
r8765 | UnAfraid | 2012-03-29 20:51:56

BETA: DP-Part for [L5244]
----------------------------------------------------------------------------
r8764 | MELERIX | 2012-03-29 17:18:13

BETA: A single SQL Query to rule all them!, thanks UnAfraid for the idea.
----------------------------------------------------------------------------
r8763 | Zoey76 | 2012-03-29 12:55:48

BETA: Update in the name of the update SQL queries, to avoid confusions.
----------------------------------------------------------------------------
r8762 | Zoey76 | 2012-03-29 12:51:24

BETA: Datapack part for [L5240]:
* Removed SQL tables:
* char_creation_items
* class_list
* henna
* henna_trees
* Added retail like XMLs:
* classList.xml
* hennaList.xml
* initialEquipment.xml
* initialEquipmentEvent.xml
* Unhardcoded more player class names in datapack scripts.
* Simplified bypasses.
----------------------------------------------------------------------------
r8761 | UnAfraid | 2012-03-28 23:01:38

BETA: Unifying Magic Level table name
----------------------------------------------------------------------------
r8760 | UnAfraid | 2012-03-28 22:57:59
----------------------------------------------------------------------------
r8759 | MELERIX | 2012-03-28 21:26:20

BETA: Some Missing SQL Updates for Admin Command Handlers, and cleanup.
----------------------------------------------------------------------------
r8758 | MELERIX | 2012-03-28 19:48:24

same for armor sets...
----------------------------------------------------------------------------
r8757 | MELERIX | 2012-03-28 19:33:59

BETA: Zones file names more small (requested by UnAfraid).
----------------------------------------------------------------------------
r8756 | UnAfraid | 2012-03-28 18:51:02

BETA: Updating listeners thanks theone and nonom for testing.
* ClanWarehouse moved to it's new location
* All the null checks are in the "fireAction" methods
* Enums are now all capitalized (thx for pointing this out jurchiks)
* Added a listener into RequestRestart packet so that the player despawn events get triggered on restart also.
More info here viewtopic.php?f=70&t=25089
----------------------------------------------------------------------------
r8755 | MELERIX | 2012-03-26 18:25:40

BETA: Cleanup for [8753].
----------------------------------------------------------------------------
r8754 | Zoey76 | 2012-03-26 18:03:35

BETA: Datapack part for [L5235]:
* No more Skill Tree XML files looking like CSV files.
* Documentation updated.
* Skill Id and level have been split to avoid useless parsing, and improve readability.
* Now list of attributes are now placed as sub-elements of the current skill and not in comma-separated attributes.
* The races are read from its text representation instead of the numeric Id, more user friendly!
* Social classes are read from its text representation too, more user friendly!
* All constraints are in the XSD file.
* They are stricter now.
----------------------------------------------------------------------------
r8753 | UnAfraid | 2012-03-26 15:04:29

BETA: Quests from Jython to Java by nonom:
* 50_LanoscosSpecialBait
* 51_OFullesSpecialBait
* 52_WilliesSpecialBait
* 53_LinnaeusSpecialBait
----------------------------------------------------------------------------
r8752 | MELERIX | 2012-03-25 19:12:37

BETA: Cleanup due [L5232].
----------------------------------------------------------------------------
r8751 | MELERIX | 2012-03-25 18:55:09

BETA: Added Item/Skills descriptions in comments for Armor Sets, thanks '''Unafraid'''.
----------------------------------------------------------------------------
r8750 | MELERIX | 2012-03-25 16:48:16

more
----------------------------------------------------------------------------
r8749 | MELERIX | 2012-03-25 16:14:23

this ones too xD
----------------------------------------------------------------------------
r8748 | MELERIX | 2012-03-25 14:51:25

BETA: Following Armor Sets are not used in Game yet (just reserved slots) so now are commented.
----------------------------------------------------------------------------
r8747 | UnAfraid | 2012-03-25 14:02:28
----------------------------------------------------------------------------
r8746 | UnAfraid | 2012-03-25 13:32:27

BETA: Typo fix for [8745] thanks jurchiks for report.
----------------------------------------------------------------------------
r8745 | MELERIX | 2012-03-24 23:49:41
----------------------------------------------------------------------------
r8744 | MELERIX | 2012-03-24 23:13:39

BETA: Some Fixes...
* Added Armor Sets in XML for future usage (core part will be committed later).
* Added XSD for Armor Sets in XML.
* Fixed Apella Armor Sets Skills.
* Fixed Incorrect Skill For Native Transform Special Set.
----------------------------------------------------------------------------
r8743 | Nik | 2012-03-22 15:50:07

BETA: Fixing the following malfunctioning seeds:
* Twin Coba Seed (Oren)
* Seed: Alternative Twin Coba (Oren)
* Red Coba Seed (Schuttgart)
* Seed: Alternative Red Coba (Schuttgart)
* Golden Coba Seed (Schuttgart)
* Seed: Alternative Golden Coba (Schuttgart)
----------------------------------------------------------------------------
r8742 | Nik | 2012-03-21 07:29:55

BETA: Adding notification when a script is successfuly loaded through //script_load
----------------------------------------------------------------------------
r8741 | Nik | 2012-03-21 07:21:13

BETA: Warp can be used even when movement is disabled (check this to see it yourself: http://bit.ly/GG5EKw&#41;
----------------------------------------------------------------------------
r8740 | MELERIX | 2012-03-20 08:07:07
----------------------------------------------------------------------------
r8739 | MELERIX | 2012-03-20 06:31:04

BETA: Cleanup/Reorganization in some Admin Teleports.
----------------------------------------------------------------------------
r8738 | MELERIX | 2012-03-20 04:50:17

BETA: Fix for Ticket #L6107.
----------------------------------------------------------------------------
r8737 | Zoey76 | 2012-03-19 04:22:00

BETA: Quest fixes:
* Html naming/typo fixes at For A Good Cause(309).
* Html naming fix at Exploration of the Giants' Cave - Part 1(376), thanks Tavo22 for report.
----------------------------------------------------------------------------
r8736 | MELERIX | 2012-03-17 22:05:19

BETA: Updated hp of Fort Doors.
----------------------------------------------------------------------------
r8735 | MELERIX | 2012-03-17 21:47:18

BETA: Updated hp, pDef, mDef of Castle Doors.
----------------------------------------------------------------------------
r8734 | MELERIX | 2012-03-17 18:35:08

BETA: Disabled "castle" attribute from MapRegions that have not dependency of Castles.
----------------------------------------------------------------------------
r8733 | MELERIX | 2012-03-17 16:10:33

BETA: Updated instancenames.xml & systemmsg.txt to H5, thanks '''Starter'''.
----------------------------------------------------------------------------
r8732 | Zoey76 | 2012-03-17 13:00:00

BETA: Quest improvements and fixes:
* By jurchiks:
* PrisonGuards cleanup and improvements.
* BanditStronghold html fixes.
* Improvements:
* CharacterBirthday
* HeavyMedal
* TheValentineEvent
* 215_TrialOfPilgrim
* 218_TestimonyOfLife
* 60_GoodWorkReward
* Q10267_JourneyToGracia
* Q10269_ToTheSeedOfDestruction
* Q10271_TheEnvelopingDarkness
* Q10275_ContainingTheAttributePower
* Q10290_LandDragonConqueror
* Q10291_FireDragonDestroyer
* Q132_MatrasCuriosity
* Q18_MeetingWithTheGoldenRam
* Q19_GoToThePastureland
* Q249_PoisonedPlainsOfTheLizardmen
* Q250_WatchWhatYouEat
* Q309_ForAGoodCause
*By me:
* Q458_PerfectForm html fixes.
* Q461_RumbleInTheBase html fixes.
* BanditStronghold html fixes.
----------------------------------------------------------------------------
r8731 | MELERIX | 2012-03-16 23:55:16

BETA: Some improvements for Q309 by '''nonom'''.
----------------------------------------------------------------------------
r8730 | MELERIX | 2012-03-16 22:38:18

BETA: Format/Cleanup in few Java Quests by '''nonom'''.
----------------------------------------------------------------------------
r8729 | Zoey76 | 2012-03-14 19:05:24

BETA: Quest fixes:
* By VlLight:
* NPE vulnerability fix for Light Fragment(10272).
* Unhardcoding ExShowScreenMessage in Grave Robber Rescue(450).
* By me:
* Unhardcoding NpcSay in Grave Robber Rescue(450).
* Unhardcoding ExShowScreenMessage in Resurrection of an Old Manager(114).
* Unhardcoding NpcSay in Resurrection of an Old Manager(114).
----------------------------------------------------------------------------
r8728 | UnAfraid | 2012-03-11 13:25:07

BETA: Missing check for quest 511 thanks lion
----------------------------------------------------------------------------
r8727 | Zoey76 | 2012-03-11 03:28:51

BETA: Quest fixes:
* getRandom(..) fixes, thanks Tavo22 for report.
* Scripts cleanup.
----------------------------------------------------------------------------
r8726 | MELERIX | 2012-03-09 23:25:00
----------------------------------------------------------------------------
r8725 | MELERIX | 2012-03-09 23:15:44

BETA: Removed old npc spawns from region 22_19.
----------------------------------------------------------------------------
r8724 | Zoey76 | 2012-03-08 07:39:51

BETA: Fix for Mutated Elpy respawn, thanks baluu for report and Battlecruiser for fix.
----------------------------------------------------------------------------
r8723 | Zoey76 | 2012-03-07 19:03:00

BETA: AdminSiege fix:
* Fixed minor typo from [8669]
* Fixes ticket #5248
----------------------------------------------------------------------------
r8722 | Zoey76 | 2012-03-07 18:46:13

BETA: Jython part for [8709]:
* Fixes issues in [8713], [8714], [8717].
* Fixes ticket #5242

From Quest documentation:: If the Quest class had a function named "foo" and it expected an integer parameter, you could call this function from anywhere within the "class Quest" segment of your script, using the code self.foo(5)
----------------------------------------------------------------------------
r8721 | Zoey76 | 2012-03-06 19:35:35

BETA: Quest fixes by _Blade_:
* Exploration of the Giants' Cave - Part 1(376)
* Bypass fixes after quest name change.
* Typo fix onTalk(..) method.
* Exploration of the Giants' Cave - Part 2
* Bypass fixes after quest name change.
----------------------------------------------------------------------------
r8720 | UnAfraid | 2012-03-06 13:46:03

BETA: ;; => ;
----------------------------------------------------------------------------
r8719 | lion | 2012-03-05 20:27:27

BETA: remove extra tag for not have problem in future
----------------------------------------------------------------------------
r8718 | MELERIX | 2012-03-05 19:06:01

BETA: Proper tags for task lists in skills (no more <!-- guess --> related comments), now you will see FIXME or TODO messages in Eclipse Task List (if you have xml tools installed viewtopic.php?f=51&t=14539&#41;.
----------------------------------------------------------------------------
r8717 | UnAfraid | 2012-03-05 12:41:56

BETA: Typo fix thanks tukune
----------------------------------------------------------------------------
r8716 | Zoey76 | 2012-03-05 07:53:24

BETA: A Trap for Revenge (702) quest cleanup and format.
----------------------------------------------------------------------------
r8715 | Zoey76 | 2012-03-05 00:13:42

BETA: Cleanup and format of some java scripts.
----------------------------------------------------------------------------
r8714 | UnAfraid | 2012-03-04 17:34:06

BETA: Typo fix thanks jurchiks
----------------------------------------------------------------------------
r8713 | UnAfraid | 2012-03-04 16:44:59

BETA: Jython part for [8709]
----------------------------------------------------------------------------
r8712 | MELERIX | 2012-03-04 03:40:00

BETA: Cleanup for [L5180].
----------------------------------------------------------------------------
r8711 | Zoey76 | 2012-03-04 02:55:25

BETA: Typo fix in Olympiad Undefeated(553) by _Blade_
----------------------------------------------------------------------------
r8710 | Zoey76 | 2012-03-03 17:24:09

BETA: More AI fixes:
* Added missing authors to AIs, based on forums, changelogs and DevSVN.
* Fixed bug in EnergySeeds after [8602] ...
* Added package-info, for better JavaDoc generation.
* Quest's package-info will be added soon, after finishing update for Java scripts and missing documentation.
----------------------------------------------------------------------------
r8709 | Zoey76 | 2012-03-03 16:34:10

BETA: Datapack part for [L5214]:
* Cleanup of random related methods and imports.
* Fix for FairyTrees AI with wrong parameter type wouldn't override onKill(..) method.
----------------------------------------------------------------------------
r8708 | MELERIX | 2012-03-02 03:01:58

BETA: Cleanup for [L5209,5210].
----------------------------------------------------------------------------
r8707 | lion | 2012-03-01 12:23:51

BETA: fix typo in sql, thx DareStrike
----------------------------------------------------------------------------
r8706 | UnAfraid | 2012-03-01 04:37:59

BETA: DP-Part for [L5209]
----------------------------------------------------------------------------
r8705 | MELERIX | 2012-02-29 19:29:00

BETA: Two Missing sysmsg.
----------------------------------------------------------------------------
r8704 | MELERIX | 2012-02-29 18:51:41

BETA: XSD for items, also cleanup for the others XSD files.
----------------------------------------------------------------------------
r8703 | MELERIX | 2012-02-29 12:52:47

Removed [8702], Nightly Builds are working again.
----------------------------------------------------------------------------
r8702 | MELERIX | 2012-02-28 20:07:56

attempting to fix nightly builds with this hack, this changes will be removed later.
----------------------------------------------------------------------------
r8701 | Zoey76 | 2012-02-28 18:45:20

BETA: Adding command access right for give_all_clan_skills command.

'''Note:''' Commands require access command right to be used from links, otherwise they throw a warning.
----------------------------------------------------------------------------
r8700 | MELERIX | 2012-02-28 17:22:37

BETA: Missing Admin Menu Button for [8695].
----------------------------------------------------------------------------
r8699 | GodKratos | 2012-02-27 05:40:18

BETA: Help for telnet packetsend
----------------------------------------------------------------------------
r8698 | MELERIX | 2012-02-27 05:39:53

BETA: Removed isCrystal boolean from enchantData.xml, enough using successRate (thanks Starter).
----------------------------------------------------------------------------
r8697 | MELERIX | 2012-02-26 23:43:49

BETA: Missing Door Radius for H5 Olympiad Stadiums Doors, thanks VlLight.
----------------------------------------------------------------------------
r8696 | UnAfraid | 2012-02-26 19:48:29

BETA: Typo fix
----------------------------------------------------------------------------
r8695 | Zoey76 | 2012-02-26 18:55:24

BETA: AdminSkill update:
* Added give_all_clan_skills command, it will reward the target's clan will all available skills for that clan level.
* Added some JavaDocs.
* Rewritten some parts of previous code.
----------------------------------------------------------------------------
r8694 | Zoey76 | 2012-02-25 18:34:29

BETA: Fix for Path To Orc Shaman(416) quest by Tavo22.
* Missing from [8509].
----------------------------------------------------------------------------
r8693 | Zoey76 | 2012-02-24 07:08:29

BETA: Datapack part for [L5192]:
* Added gameMasterSkillTree.xml
* Added gameMasterAuraSkillTree.xml
* Added heroSkillTree.xml
* Added nobleSkillTree.xml

This unhardcodes this skill trees and allows easy update/customization.
----------------------------------------------------------------------------
r8692 | MELERIX | 2012-02-23 18:26:37

BETA: Removed duplicated spawns.
----------------------------------------------------------------------------
r8691 | Zoey76 | 2012-02-23 03:40:46

BETA: More Rainbow Springs Chateau fixes:
* RainbowSpringsChateau cleanup and fixes.
* Implemented Messenger's retail HTMLs and AI.
* Implemented Caretaker's retail HTMLs and AI.
* Datapack part for [L5190].

'''Note:''' Rainbow Springs Chateau clan hall siege is still unfinished, this is just some work to get it closer to retail and closer to be finished.
----------------------------------------------------------------------------
r8690 | Zoey76 | 2012-02-22 19:20:12

BETA: Removing Kasha Bear's duplicated spawn, thanks Loup_Solitaire.
----------------------------------------------------------------------------
r8689 | Zoey76 | 2012-02-22 19:14:47

BETA: Removing duplicated spawn for Yetti Messenger (35604), thanks tukune for report.
----------------------------------------------------------------------------
r8688 | Zoey76 | 2012-02-22 19:08:30

BETA: Adding all missing Territory Managers spawns.

Thanks malyelfik for report and first fix implementation.
----------------------------------------------------------------------------
r8687 | lion | 2012-02-22 16:28:22

BETA: fix PvP Dynasty Halberd (Critical Stun)
----------------------------------------------------------------------------
r8686 | UnAfraid | 2012-02-21 15:40:55

BETA: DP-Part for [L5185] That's just an example usage of the Listeners
----------------------------------------------------------------------------
r8685 | Zoey76 | 2012-02-21 15:28:19

BETA: More conquerable clan halls fixes:
* RainbowSpringsChateau _pendingItemToGet's key is L2Clan not Integer.
* When using replaceAll(..) is required to assign the returned object, otherwise it'll be ignored.
----------------------------------------------------------------------------
r8684 | Zoey76 | 2012-02-20 21:54:16

BETA: Datapack part for [L5184]
----------------------------------------------------------------------------
r8683 | Zoey76 | 2012-02-20 21:50:33

BETA: Datapack for [L5183]
----------------------------------------------------------------------------
r8682 | Zoey76 | 2012-02-20 14:44:08

BETA: Misc fixes:
* Fixed Scroll of Resurrection typo from [8679], thanks baluu for report.
* Fixed JavaDocs, removed non-JavaDocs comments and some @see JavaDocs.
* Formatted CancelDebuff class.
----------------------------------------------------------------------------
r8681 | MELERIX | 2012-02-18 19:16:39

BETA: Full Install DB should clean up character_item_reuse_save.sql.
----------------------------------------------------------------------------
r8680 | Zoey76 | 2012-02-18 15:56:46

BETA: Moving extractable skill handler to effects:
* Improved formatter a bit.
* Implemented RestorationRandom effect.
* Unhardcoded for target, now a player can extract items into it's target depending on skill's target type.
* Fixed some typos on AdminEventEngine HTML dynamic build.
* Removed debug messages from ItemSkillsTemplate.
* Removed extractable skill handler.
* Fixed OracleTeleport teleport.
* Replaced all skill types for extractable skills with DUMMY, and added RestorationRandom effect.
----------------------------------------------------------------------------
r8679 | Zoey76 | 2012-02-18 15:23:18

BETA: Datapack part for [L5180]:
* Wondrous Cubic - 1 time use should be consumed upon usage.
* Added more missing GPL notices.
* Implemented Calculator item handler.
* Moved some high time reuses from items skills to it's items, it's a temp fix for missing global skill reuse, since item reuse is global to all classes.
* Removed custom check based on skill type for Extractable skills with high reuse not being able to be used in sub-classes.
----------------------------------------------------------------------------
r8678 | GodKratos | 2012-02-18 09:47:57

Add telnet command to send packet data to players
(equivalent to using packet forge from telnet)
----------------------------------------------------------------------------
r8677 | MELERIX | 2012-02-16 02:48:02

BETA: Minor Improvements/Cleanup for '''database_installer.bat'''.
----------------------------------------------------------------------------
r8676 | UnAfraid | 2012-02-11 12:08:08

BETA: DP-Part for [L5173]
----------------------------------------------------------------------------
r8675 | MELERIX | 2012-02-10 00:08:26

BETA: Updated SQL Documentation a bit.
----------------------------------------------------------------------------
r8674 | MELERIX | 2012-02-09 23:26:25

BETA: More Indexes for [8337].
----------------------------------------------------------------------------
r8673 | MELERIX | 2012-02-09 05:56:32

BETA: Full Install DB should clean up mods_wedding.sql.
----------------------------------------------------------------------------
r8672 | MELERIX | 2012-02-09 05:50:13

BETA: Two more Indexes for [8337].
----------------------------------------------------------------------------
r8671 | MELERIX | 2012-02-09 02:49:59

BETA: Revert DebugHandler.java from [8670].
----------------------------------------------------------------------------
r8670 | UnAfraid | 2012-02-09 02:02:56

BETA: Organizing xsd's into data/xsd/ folder and Unifying multisell's data.
----------------------------------------------------------------------------
r8669 | UnAfraid | 2012-02-08 19:59:09

BETA: AdminSiege handler typo fix and source format
----------------------------------------------------------------------------
r8668 | Zoey76 | 2012-02-08 16:28:52

BETA: Minor fix for [8663], thanks UnAfraid for report.
----------------------------------------------------------------------------
r8667 | Zoey76 | 2012-02-07 13:31:51

BETA: Quests updates, thanks jurchiks for report.
* Into The Large Cavern (179) updated checks and htmls.
* New Recruits (182) updated checks and htmls.
----------------------------------------------------------------------------
r8666 | Zoey76 | 2012-02-06 03:16:23

BETA: Voiced commands update, format and cleanup.
----------------------------------------------------------------------------
r8665 | Zoey76 | 2012-02-06 01:46:43

BETA: Quests from Jython to Java by nonom:
* Exploration of the Giants' Cave - Part 1 (376)
* Exploration of the Giants' Cave - Part 2 (377)

'''Note 1:''' Quest name changed, require database update.
'''Note 2:''' Empty folder cleanup on next commits.
----------------------------------------------------------------------------
r8664 | Zoey76 | 2012-02-06 00:53:37

BETA: Quest Perfect Form (458) by centrio, code refactoring and improvements and tests by me.

'''Note:''' This quest require [L5166] !

Quest I Must Be a Genius (463) cleanup, format and minor refactor.
----------------------------------------------------------------------------
r8663 | Zoey76 | 2012-02-06 00:21:09

BETA: Fix for Sweeper, thanks VlLight.
----------------------------------------------------------------------------
r8662 | MELERIX | 2012-02-03 09:53:30
----------------------------------------------------------------------------
r8661 | MELERIX | 2012-02-03 09:39:48

BETA: Elcadia's Skills.
----------------------------------------------------------------------------
r8660 | MELERIX | 2012-02-01 22:34:11

BETA: More LF -> CRLF (this are probably the last files).
----------------------------------------------------------------------------
r8659 | lion | 2012-02-01 19:48:33

BETA: cleanup
----------------------------------------------------------------------------
r8658 | MELERIX | 2012-02-01 19:14:37

BETA: You will now be returned to Hunter's Village when you use a Scroll of Escape in Anthara's Lair.
----------------------------------------------------------------------------
r8657 | MELERIX | 2012-02-01 18:46:35

BETA: Few typo fixes from [8548].
----------------------------------------------------------------------------
r8656 | MELERIX | 2012-01-30 22:41:36

BETA: Wild Hog/Swoop Cannon Skills, also more LF -> CRLF.
----------------------------------------------------------------------------
r8655 | MELERIX | 2012-01-30 08:55:52

BETA: LF -> CRLF in few files.
----------------------------------------------------------------------------
r8654 | Zoey76 | 2012-01-30 07:58:39

BETA: Tutorial fixes by Sleek and me.

More empty folders cleanup.
----------------------------------------------------------------------------
r8653 | MELERIX | 2012-01-30 06:53:48

BETA: Cleanup.
----------------------------------------------------------------------------

[Zoey76]

SPOILER:

r8652 | Zoey76 | 2012-01-30 05:39:42

BETA: Quests in Java by nonom:
* Secret Meeting With Ketra Orcs (11)
* Secret Meeting With Varka Silenos (12)
* Parcel Delivery (13)
* Whereabouts of the Archaeologist (14)
* Sweet Whispers (15)
* The Coming Darkness (16)
* Light and Darkness (17)
* Meeting with the Golden Ram (18)
* Added SQL update queries for quests that changed it's name.

Review, tests and fixes by me, thanks jurchiks for suggestions for improvements and typos.
----------------------------------------------------------------------------
r8651 | MELERIX | 2012-01-27 23:15:45

BETA: Missing "H5 Item Change" from [8111], also minor fix for [8650] (the order).
----------------------------------------------------------------------------
r8650 | UnAfraid | 2012-01-27 22:34:40

BETA: Lets load [8649] thanks nonom.
----------------------------------------------------------------------------
r8649 | Zoey76 | 2012-01-27 09:36:50

BETA: Tired of Waiting (26) quest by corbin12, thanks.
----------------------------------------------------------------------------
r8648 | Zoey76 | 2012-01-25 22:22:09

BETA: Using new skill operative types, thanks UnAfraid.

'''Note:''' All new active skills will have "A1" as default value, later some of them will be changed/updated.
----------------------------------------------------------------------------
r8647 | MELERIX | 2012-01-25 19:46:15

BETA: Some H5 NPCs Stats.
----------------------------------------------------------------------------
r8646 | lion | 2012-01-25 10:48:18

quests tweak
----------------------------------------------------------------------------
r8645 | Zoey76 | 2012-01-25 09:56:12

BETA: Minor fixes for [8639], thanks jurchiks for report.
----------------------------------------------------------------------------
r8644 | Zoey76 | 2012-01-25 07:51:41

BETA: Datapack for [L5149].
----------------------------------------------------------------------------
r8643 | UnAfraid | 2012-01-24 15:04:20

BETA: Typo fix for [L5146] thanks nonom.
----------------------------------------------------------------------------
r8642 | Zoey76 | 2012-01-24 06:33:57

BETA: Datapack part for [L5146].
----------------------------------------------------------------------------
r8641 | MELERIX | 2012-01-22 23:59:32

BETA: Reverting [7703] it was confirmed in retail again and is not a bug.
----------------------------------------------------------------------------
r8640 | Zoey76 | 2012-01-22 19:38:15

BETA: Minor typo in [8639]
----------------------------------------------------------------------------
r8639 | Zoey76 | 2012-01-22 19:35:11

BETA: Java scripts review:
* Hellbound:
1. Engine shouldn't NPE if Trust Points XML is not valid.
* Quests:
1. Q10267_JourneyToGracia
1. Q10268_ToTheSeedOfInfinity
1. Q10269_ToTheSeedOfDestruction
1. Q10271_TheEnvelopingDarkness
1. Q10272_LightFragment
1. Q10273_GoodDayToFly
1. Q10274_CollectingInTheAir
1. Q10275_ContainingTheAttributePower
1. Q10276_MutatedKaneusGludio
1. Q10277_MutatedKaneusDion
1. Q10278_MutatedKaneusHeine
1. Q10279_MutatedKaneusOren
1. Q10280_MutatedKaneusSchuttgart
1. Q10281_MutatedKaneusRune
1. Q10282_ToTheSeedOfAnnihilation
1. Q10283_RequestOfIceMerchant
1. Q10288_SecretMission
1. Q10289_FadeToBlack
1. Q10290_LandDragonConqueror
1. Q10291_FireDragonDestroyer
1. Q132_MatrasCuriosity
1. Q146_TheZeroHour
1. Q147_PathtoBecominganEliteMercenary
1. Q148_PathtoBecominganExaltedMercenary
1. Q153_DeliverGoods
1. Q179_IntoTheLargeCavern
1. Q182_NewRecruits
1. Q19_GoToThePastureland
1. Q20_BringUpWithLove
1. Q249_PoisonedPlainsOfTheLizardmen
1. Q250_WatchWhatYouEat
1. Q278_HomeSecurity
1. Q279_TargetOfOpportunity
* Cleaned up 309_ForAGoodCause folder, thanks jurchiks for report.
----------------------------------------------------------------------------
r8638 | Zoey76 | 2012-01-20 19:58:21

BETA: Hunting Grounds teleport update by jurchiks, thanks
----------------------------------------------------------------------------
r8637 | Zoey76 | 2012-01-20 02:42:57

BETA: Minor XML update:
* Implemented item Wondrous Cubic - 1 time use(21106).
* Implemented skill Wondrous Cubic - 1 time use(22180).
* Updated skill name Wondrous Cubic(2510).
* Updated skills comment from H5 Skill to High Five Skill.
----------------------------------------------------------------------------
r8636 | MELERIX | 2012-01-19 22:38:09

BETA: DP-Part for [L5139].
----------------------------------------------------------------------------
r8635 | MELERIX | 2012-01-19 21:28:35

BETA: Removed few duplicated/unused Peace Zones.
----------------------------------------------------------------------------
r8634 | MELERIX | 2012-01-19 19:01:38

BETA: Uncommenting NoRestartZones in ssq_zones.xml.
----------------------------------------------------------------------------
r8633 | Zoey76 | 2012-01-19 13:17:51

BETA: Minor fix for [8613], let's restrict all items with Extractable Skills, not only the ones that consume an item, thanks UnAfraid and baluu for report.
----------------------------------------------------------------------------
r8632 | MELERIX | 2012-01-16 19:42:17
----------------------------------------------------------------------------
r8631 | MELERIX | 2012-01-16 19:36:08

BETA: Minor Improvement for '''Q10267''' by nonom, also minor fix for '''L2StaticObjectInstanceAction.java''' by jurchiks.
----------------------------------------------------------------------------

[Zoey76]

Some numbers:
Datapack commits:
TOTAL: 320
MELERIX: 167
Zoey76: 84
UnAfraid: 42
Adry_85: 12
Nik: 6
lion: 5
GodKratos: 4



Datapack reverts: 4

Datapack contributions and reports:
jurchiks: 15
nonom: 12
Tavo22: 8
UnAfraid: 7
Starter: 5
Battlecruiser: 4
baluu: 3
DareStrike: 3
VlLight: 3
tukune: 3
FullMetal: 2
_Blade_: 2
Copyleft: 2
badboy29: 2
corbin12: 1
Sleek: 1
malyelfik: 1
Loup_Solitaire: 1
lion: 1
MELERIX: 1
thecast: 1
Adry_85: 1
brutus: 1
Zoey76: 1
blacksea: 1
Arantir: 1
Katako: 1
d!g0: 1
FBIagent: 1
goncafa: 1
kostantinos: 1

[MELERIX]

uh! we have pvp ranking now xD

[jurchiks]

Huuuuh... is that weird or what?
Well, anyway, if I get my contribs committed there will be more.
So yeah...

[Zoey76]

Some numbers:
Core commits:
TOTAL: 308
Zoey76: 134
MELERIX: 73
UnAfraid: 71
Nik: 13
Adry_85: 10
GodKratos: 7



Core reverts: 13

Core contributions and reports:
Tavo22: 13
Zoey76: 13
MELERIX: 12
Starter: 12
jurchiks: 11
UnAfraid: 8
tukune: 7
nonom: 6
Battlecruiser: 5
Tryskell: 5
goncafa: 5
_Blade_: 4
BiggBoss: 2
Gnacik: 2
Adry_85: 2
FBIagent: 2
theone: 2
Vulcan: 2
u3games: 2
Micr0: 1
digunan: 1
FinalDestination: 1
DareStrike: 1
Edoo: 1
Lupu1: 1
franpisco: 1
kostantinos: 1
Drumatrix: 1
badboy29: 1
VlLight: 1
afk5min: 1
JMD: 1
lord_rex: 1
zatei: 1
fakoykas: 1
blacksea: 1
avatar7: 1
skyshadow: 1
burrito: 1
Sylar88: 1

[LasTravel]

Tukune for developer!

PS: Great work.

[Stake]

I thought, this is better.

[Zoey76]

New synchronization:

SPOILER:

r5521 | UnAfraid | 2012-07-19 10:26:16

BETA: Little typo fix after [5520] Reported by: Burner, powerfulguardian
----------------------------------------------------------------------------
r5520 | Zoey76 | 2012-07-18 17:59:26

BETA: Reworking Connection closing by using try-with-resource:
* Using Statement instead !PreparedStatement where parameters are not required.
* Minor change in formatter settings to give proper format to try-with-resource statement.
* Fixed many resource leaks.
----------------------------------------------------------------------------
r5519 | Zoey76 | 2012-07-17 22:45:16

BETA: Moving EnchantHPBonusData to extend !DocumentParser:
* Using Java's !HashMap instead of Trove's map.
* !JavaDocs and formatting.
* Fixed #5980, exception when Olympiad enchant limit is zero or less.
----------------------------------------------------------------------------
r5518 | UnAfraid | 2012-07-17 22:23:06

BETA: Little typo fix from [5517]
----------------------------------------------------------------------------
r5517 | UnAfraid | 2012-07-17 21:44:58

BETA: Improving account ip whitelist feature now it supports multiple ips also a type blacklisted ip or allowed ip.
----------------------------------------------------------------------------
r5516 | UnAfraid | 2012-07-17 19:39:14

BETA: Fixing DB Installers somehow SQLFilter wasn't included in ant build.
----------------------------------------------------------------------------
r5515 | Zoey76 | 2012-07-16 20:45:22

BETA: Misc fixes:
* Removing unused method at !LoginServerThread.
* Avoiding useless log from c3p0.
* Minor update for log at !L2PetInstance.
* Minor update for class JavaDoc at !EnchantGroupsData.
* Minor format for !HennaInfo.
* Minor improvement for !RaidBossSpawnManager.
----------------------------------------------------------------------------
r5514 | Zoey76 | 2012-07-16 17:53:54

BETA: Minor revert for hennas, from [5503-5505].
* Added class JavaDocs.

Reported By:
- franpisco
- Konstantinos
- u3games
----------------------------------------------------------------------------
r5513 | Zoey76 | 2012-07-14 22:54:18

BETA: Null pointer access vulnerability fix:
* Related to pet name change and control item.
* Closing #5318
* Probably from forced database item delete.
----------------------------------------------------------------------------
r5512 | Zoey76 | 2012-07-14 16:59:58

BETA: Fixing trade exploit that allows players to accept the trade when they are far from each other.
* Closing #6223
* Classes formatted.
* Minor typo in !SystemMessageId comment.
----------------------------------------------------------------------------
r5511 | Zoey76 | 2012-07-14 00:38:36

LIBRARY: Reverting [5508]:
* Even when the the version is 3.8.0 the internal build is slightly different for 3.x and 4.x branches.
* [http://download.eclipse.org/eclipse/dow ... 206081400/ Download JDT Core Batch Compiler]
Reported By: MELERIX
----------------------------------------------------------------------------
r5510 | Zoey76 | 2012-07-14 00:00:36

BETA: Fixing Auto-Equip Arrows/Bolts:
* They were equipped in left hand if weapon and arrow's grade matched.
* Closing #6255
* Arrows/Bolts was valid and fixed in this change-set.
* Beast Soulshot seems invalid.
* Pet ride was fixed in [5161], and currently working.

Reported By: vagabond
----------------------------------------------------------------------------
r5509 | Zoey76 | 2012-07-13 21:28:06

BETA: Updating Java Engine library.
* Updated build name to keep trac of versions.
* __Don't forget to remove old libraries.__
* This will avoid warning flood in server console, since there are hidden in Eclipse settings they should also be hidden in game server's logs.
----------------------------------------------------------------------------
r5508 | Zoey76 | 2012-07-13 21:12:15

LIBRARY: Updating ECJ's name from [5460]:
* There is no 4.2 version.
* The file name contains 3.8.1 version.
* The actual build version is 3.8.0.
* Can be checked using:
{{{
>java -jar ecj-3.8.1.jar -version
Eclipse Compiler for Java(TM) 0.C58, 3.8.0, Copyright IBM Corp 2000, 2012. All rights reserved.
}}}
----------------------------------------------------------------------------
r5506 | MELERIX | 2012-07-13 02:58:49

BETA: Missing recompile MMOCore Lib from [5497].
----------------------------------------------------------------------------
r5505 | UnAfraid | 2012-07-12 19:30:28

(You haven't seen this)
----------------------------------------------------------------------------
r5504 | UnAfraid | 2012-07-12 19:04:31

BETA: Fixing little NPE since [5503] Reported by: DareStrike
----------------------------------------------------------------------------
r5503 | UnAfraid | 2012-07-12 17:06:33

BETA: !ServerPackets rework dropping getType method since is completely useless using getClass().getSimpleName() instead.
* Formatted all packets
* Cleaned all crappy comments
* Added a lot of TODO/FIXME/XXX comments
* Trigger packets cached to static variable STATIC_PACKET (As ActionFailed?)
* Upper-case hexadecimal letters (Such as 0xFE)
* Added missing public/private/protected final declarations
* And god knows what more..
----------------------------------------------------------------------------
r5502 | MELERIX | 2012-07-11 03:40:27

BETA: Minor update for Diego Vargas vegdamage formula.
----------------------------------------------------------------------------
r5501 | Nik | 2012-07-08 17:54:33

Some flyType skills can be used while movement is disabled. (Warp, Blonk, Air Blink, etc.)
----------------------------------------------------------------------------
r5500 | UnAfraid | 2012-07-08 10:34:57

BETA: Fixing Polymorph issue (Packet wasnt updated to H5) Reported by: valdaron.
Also review of AbstractNpcInfo/UserInfo/CharInfo packets.
----------------------------------------------------------------------------
r5499 | UnAfraid | 2012-07-07 21:26:15

BETA: Typo fix in global on death listener..
----------------------------------------------------------------------------
r5498 | UnAfraid | 2012-07-07 21:12:38

BETA: Another NpcTable typo Patch By: Tavo22
----------------------------------------------------------------------------
r5495 | UnAfraid | 2012-07-07 15:33:05

BETA: Fixing Eclipse's default compiler compliance level Patch By: jurchiks
----------------------------------------------------------------------------
r5494 | MELERIX | 2012-07-07 13:57:16

BETA: Fixed encoding of some files.
----------------------------------------------------------------------------
r5493 | Zoey76 | 2012-07-06 21:07:01

BETA: Fixing shots related code:
* Closing #6251
* Please do not use ternary operators for '''explicit boolean''' values:
* return (EXP1) ? (EXP2) : false;
* Instead use:
* return (EXP1) && (EXP2);
* isSoulshotCharged and isSpiritshotCharged methods should both ask for Player, NPC and Summon.
* Fixed comments.

'''Note:''' ternary operators should be used for: EXP ? EXP1 : EXP2; for example.
----------------------------------------------------------------------------
r5492 | Zoey76 | 2012-07-06 20:48:55

BETA: Removing duplicated code at L2CubicInstance.
----------------------------------------------------------------------------
r5491 | UnAfraid | 2012-07-06 08:03:32

BETA: One more little typo in NpcTable
----------------------------------------------------------------------------
r5490 | UnAfraid | 2012-07-05 20:32:53

BETA: Little typo fix in NpcTable now custom npc's must be fine thanks DareStrike for report.
----------------------------------------------------------------------------
r5489 | Zoey76 | 2012-07-05 15:27:33

BETA: Minor cleanup by UnAfraid request.
----------------------------------------------------------------------------
r5488 | UnAfraid | 2012-07-05 12:41:20

BETA: A little more useful methods in StatsSet
----------------------------------------------------------------------------
r5487 | UnAfraid | 2012-07-05 12:40:03

BETA: DocumentParser support for recursive folder parsing.
----------------------------------------------------------------------------
r5486 | Nik | 2012-07-05 12:28:48

BETA: Fixing a wrong check regarding skills usable on doors. UNLOCK_SPECIAL skillhandler is now properly working.
Also ((L2DoorInstance) target).isOpenableBySkill() check is already done in the skill handler, so we dont need it here.
----------------------------------------------------------------------------
r5485 | Nik | 2012-07-05 12:18:00

BETA: Adding ssUncharge() method which is similar to spsUncharge(). Also cleaning-up the soulshot use of some skills.
Oh, and I removed the "shots on daggers dont affect skill damage" check, because its outdated and invalid.
----------------------------------------------------------------------------
r5484 | Nik | 2012-07-05 11:08:26

BETA: Fixing broken spiritshot behaviour in some skills. It turns out that in those skills, the sps charge is removed before the skill's effects are applied, thus the effects are executed without a sps charge.
Also reworked a bit the spiritshot uncharge method, no need to check the charge if its not NONE in order to change it to NONE.
----------------------------------------------------------------------------
r5483 | Zoey76 | 2012-07-04 19:48:39

BETA: Extensively use of try-with-resource:
* Using Statement instead PreparedStatement for queries with no parameters!
* Fixed many warning related to resource leaks.
* Rework of NpcTable to avoid duplicated code for retail and custom NPC data tables.
----------------------------------------------------------------------------
r5482 | MELERIX | 2012-07-04 17:31:21

BETA: Cleanup due [DP8969] (isHerbEffect check is redundant due already checked by isStatic).
----------------------------------------------------------------------------
r5481 | Adry_85 | 2012-07-04 16:11:38

BETA: Unhardcoded recharge AutoSoulShot and some cleanup in L2Character. Thanks '''Zoey76''' for help.

Thanks '''Tavo22''' for report fixed in [5458].
----------------------------------------------------------------------------
r5480 | MELERIX | 2012-07-04 11:31:58

BETA: Small typo fix in l2jmods.properties, thanks darknessneo.
----------------------------------------------------------------------------
r5479 | UnAfraid | 2012-07-04 10:20:59

BETA: Fixing ConcurrentModification in Siege
----------------------------------------------------------------------------
r5478 | nonom | 2012-07-04 10:14:40

BETA: LoginCrypt Optimization by FBIagent. Also a Javadoc update. Thanks.
----------------------------------------------------------------------------
r5477 | UnAfraid | 2012-07-04 10:02:28

BETA: ConditionTargetLevelRange support.
----------------------------------------------------------------------------
r5476 | Adry_85 | 2012-07-04 08:31:09

BETA: More cleanup for [5468].
----------------------------------------------------------------------------
r5475 | UnAfraid | 2012-07-04 08:27:42

BETA: Little cleanup of L2DoorInstance
----------------------------------------------------------------------------
r5474 | UnAfraid | 2012-07-04 08:17:28

BETA: Builders back to ant 1.8.2 i wont change my whole eclipse just the for stupid ant.
----------------------------------------------------------------------------
r5473 | MELERIX | 2012-07-04 03:00:04

BETA/COMMUNITY: MySQL Connector/J 5.1.21, Changelog here: http://dev.mysql.com/doc/refman/5.1/en/ ... -1-21.html
----------------------------------------------------------------------------
r5472 | Nik | 2012-07-03 22:03:18

BETA: Small fix for [5470] - this should't be there...
----------------------------------------------------------------------------
r5471 | MELERIX | 2012-07-03 21:56:13

BETA/COMMUNITY: Minor SVN prop changes.
----------------------------------------------------------------------------
r5470 | Nik | 2012-07-03 21:41:03

BETA: Fix for [5468]. getLevelMod() at L2Character should not return 1, but '''(100.0 - 11 + getLevel()) / 100.0; '''
----------------------------------------------------------------------------
r5469 | Zoey76 | 2012-07-03 21:38:54

BETA: JavaDocs for some classes.
----------------------------------------------------------------------------
r5468 | Adry_85 | 2012-07-02 16:47:44

BETA: Some base stats formula reworks.
- Fixed Magical Critical Rate with retail formula (WIT modifier * 10).
- Fixed Critical Rate with retail formula.
- Improved some code and cleanup.
- Moved getLevelMod() in L2Character.java and deleted in some other files.
- Fixed Magical Critical Rate values in Skills.
- Added pDef on FuncPDefMod.java when Underwear and Cloak Slots are empty.
- Fixed mAtk/pAtkSpd formula for skills ((time in milliseconds / current pAtk/mAtkSpd) * base pAtk/mAtkSpd).
- Cleanup char_templates.sql.

Thanks '''MELERIX''', '''UnAfraid''' and '''Zoey76''' for help.
----------------------------------------------------------------------------
r5467 | MELERIX | 2012-07-02 11:23:04

LIBS/COMMUNITY/BETA: Added the missing new lines for warnings introduced in E4.2.
----------------------------------------------------------------------------
r5466 | Zoey76 | 2012-07-01 15:33:58

BETA: ItemAuctionInstance resource leak fixes.
----------------------------------------------------------------------------
r5465 | Zoey76 | 2012-07-01 15:15:24

BETA: LoginController resource leak.
----------------------------------------------------------------------------
r5464 | Zoey76 | 2012-07-01 14:06:45

BETA: Resource leaks fixes.

[Zoey76]

New synchronization:

SPOILER:

------------------------------------------------------------------------
r8955 | Zoey76 | 2012-07-01 15:40:22 -0300 (Sun, 01 Jul 2012) | 1 line

BETA: FlagWar synthetic access fix.
------------------------------------------------------------------------
r8956 | MELERIX | 2012-07-02 11:23:15 -0300 (Mon, 02 Jul 2012) | 1 line

LIBS/COMMUNITY/BETA: Added the missing new lines for warnings introduced in E4.2.
------------------------------------------------------------------------
r8957 | Adry_85 | 2012-07-02 16:48:56 -0300 (Mon, 02 Jul 2012) | 1 line

BETA: DP-Part for ??[L5468].
------------------------------------------------------------------------
r8958 | MELERIX | 2012-07-03 05:12:45 -0300 (Tue, 03 Jul 2012) | 1 line

BETA: Fixed Missing skillRadius in "Shock Stomp" Skill (Thanks Tavo22 for report), also some more changes for pcBaseStats.xml file.
------------------------------------------------------------------------
r8959 | MELERIX | 2012-07-03 05:39:55 -0300 (Tue, 03 Jul 2012) | 1 line

BETA: Moved servertopdir.xsd to (community/data/xsd), some other minor changes included.
------------------------------------------------------------------------
r8960 | Adry_85 | 2012-07-03 10:18:39 -0300 (Tue, 03 Jul 2012) | 1 line

BETA: Fixed HTM links when you have ally with Ketra Orc.
------------------------------------------------------------------------
r8961 | MELERIX | 2012-07-03 21:42:07 -0300 (Tue, 03 Jul 2012) | 1 line

BETA: This part from [8585] is not needed with H5 Client.
------------------------------------------------------------------------
r8962 | MELERIX | 2012-07-03 21:45:43 -0300 (Tue, 03 Jul 2012) | 1 line

BETA: Support for Maestro's Key (Item and Skill only) by Kami and with some modifications from me, more info about this in: viewtopic.php?f=69&t=24040
------------------------------------------------------------------------
r8963 | MELERIX | 2012-07-04 00:45:55 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: DUMMY skillTypes are not only for players.
------------------------------------------------------------------------
r8964 | nonom | 2012-07-04 05:15:46 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Little fix for Olympiad Undefeated. Thanks jurchiks
------------------------------------------------------------------------
r8965 | UnAfraid | 2012-07-04 08:20:32 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Builders back to ant 1.8.2 i wont change my whole eclipse just the for stupid ant.
------------------------------------------------------------------------
r8966 | nonom | 2012-07-04 08:59:11 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Mutated Kaneus Quests improvements. Thanks jurchiks.
------------------------------------------------------------------------
r8967 | MELERIX | 2012-07-04 10:28:42 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Minor update for Maestro's Key Skill, due [L5477].
------------------------------------------------------------------------
r8968 | MELERIX | 2012-07-04 10:44:09 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Moved levelRange condition from [8967] to Item, also updated xsd for it.
------------------------------------------------------------------------
r8969 | MELERIX | 2012-07-04 17:29:55 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Herbs & Potions effects should be shared with Servitors, thanks u3games for report and Zoey76 for confirm it in retail.
------------------------------------------------------------------------
r8970 | Zoey76 | 2012-07-04 18:44:12 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Warning fix and cleanup, anyway this skill handler should be an effect and the code should be rewritten.
------------------------------------------------------------------------
r8971 | Zoey76 | 2012-07-04 20:06:01 -0300 (Wed, 04 Jul 2012) | 1 line

BETA: Missing default case warning fix for HandysBlockCheckerEvent, instead of using switch, I'll use a simple algorithm to get the same result.
------------------------------------------------------------------------
r8972 | Nik | 2012-07-05 11:13:15 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: DP Part for [L5484].
------------------------------------------------------------------------
r8973 | Nik | 2012-07-05 11:50:34 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: Shot checks on skillhandlers and effecthandlers cleanup.
------------------------------------------------------------------------
r8974 | Nik | 2012-07-05 12:23:43 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: DP Part for [L5485]. Also mobs now will get their skill damage increased when they use shots.
------------------------------------------------------------------------
r8975 | Nik | 2012-07-05 12:52:49 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: Deadly Strike - you should attack after you cast the skill.
------------------------------------------------------------------------
r8976 | Nik | 2012-07-05 13:15:55 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: Fixing Sticky Mushroom Skill.
------------------------------------------------------------------------
r8977 | Zoey76 | 2012-07-05 15:11:32 -0300 (Thu, 05 Jul 2012) | 2 lines

BETA: Admin command "admin_teleport_reload" cleanup by UnAfraid.
* Instead use the standard //reload teleport
------------------------------------------------------------------------
r8978 | Zoey76 | 2012-07-05 15:29:27 -0300 (Thu, 05 Jul 2012) | 2 lines

BETA: Datapack part for [5489].
* Note that reloading all would do lot of damage to the game server, for that reason it was never implemented.
------------------------------------------------------------------------
r8979 | MELERIX | 2012-07-05 19:00:50 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: Small typo fixes in database_installer.sh.
------------------------------------------------------------------------
r8980 | MELERIX | 2012-07-05 22:07:08 -0300 (Thu, 05 Jul 2012) | 1 line

BETA: Fixed [8976].
------------------------------------------------------------------------
r8981 | MELERIX | 2012-07-06 02:27:10 -0300 (Fri, 06 Jul 2012) | 1 line

BETA: Updated server_menu.htm (reloading part).
------------------------------------------------------------------------
r8982 | Zoey76 | 2012-07-06 15:16:50 -0300 (Fri, 06 Jul 2012) | 2 lines

BETA: Fix for Finding the Lost Soldiers (452), thanks Tavo22 for report and test.
* Thanks jurchiks for review.
------------------------------------------------------------------------
r8983 | Zoey76 | 2012-07-06 23:00:11 -0300 (Fri, 06 Jul 2012) | 1 line

BETA: Fixing some HTML typos.
------------------------------------------------------------------------
r8984 | MELERIX | 2012-07-07 13:55:42 -0300 (Sat, 07 Jul 2012) | 1 line

BETA: Fixed Town NPC Walkers initial positions and few other minor fixes related.
------------------------------------------------------------------------
r8985 | UnAfraid | 2012-07-07 15:33:08 -0300 (Sat, 07 Jul 2012) | 1 line

BETA: Fixing Eclipse's default compiler compliance level Patch By: jurchiks
------------------------------------------------------------------------
r8987 | Adry_85 | 2012-07-08 16:02:10 -0300 (Sun, 08 Jul 2012) | 7 lines

BETA: The Clan points reward for these Clan quests have been doubled:

- A Clan's Reputation
- A Clan's Prestige
- A Clan's Fame

http://legacy.lineage2.com/news/highfive_09.html
------------------------------------------------------------------------
r8988 | Zoey76 | 2012-07-09 01:07:08 -0300 (Mon, 09 Jul 2012) | 3 lines

BETA: Updating Guard's Kamaloka info.
* Note that the file names are retail like.
* Using Link action as retail does.
------------------------------------------------------------------------
r8989 | MELERIX | 2012-07-11 03:40:33 -0300 (Wed, 11 Jul 2012) | 1 line

BETA: Minor update for Diego Vargas vegdamage formula.
------------------------------------------------------------------------
r8990 | MELERIX | 2012-07-11 03:57:03 -0300 (Wed, 11 Jul 2012) | 1 line

BETA: Implemented Benom's Skills also fixed npcaidata for him.
------------------------------------------------------------------------
r8991 | UnAfraid | 2012-07-12 17:07:00 -0300 (Thu, 12 Jul 2012) | 1 line

BETA: DP-Part for [L5503]
------------------------------------------------------------------------
r8992 | MELERIX | 2012-07-12 19:56:37 -0300 (Thu, 12 Jul 2012) | 1 line

BETA: Missing from [8658].
------------------------------------------------------------------------
r8993 | MELERIX | 2012-07-13 03:31:25 -0300 (Fri, 13 Jul 2012) | 1 line

BETA: Updated Throwing Dagger Skill, thanks Nik for report about missing isDebuff boolean.
------------------------------------------------------------------------
r8994 | MELERIX | 2012-07-13 09:50:21 -0300 (Fri, 13 Jul 2012) | 1 line

BETA: Missing blowChance in [8993], thanks Konstantinos for report.
------------------------------------------------------------------------
r8995 | MELERIX | 2012-07-13 13:07:22 -0300 (Fri, 13 Jul 2012) | 1 line

BETA: The success rate of Mass Fear skill has significantly increased in H5.
------------------------------------------------------------------------
r8996 | MELERIX | 2012-07-13 13:24:22 -0300 (Fri, 13 Jul 2012) | 1 line

BETA: The success rate of Demonic Blade Dance skill were increased and MP consumption were decreased in H5.
------------------------------------------------------------------------
r8997 | MELERIX | 2012-07-13 13:39:19 -0300 (Fri, 13 Jul 2012) | 1 line

BETA: The success rate of Throne Root skill was increased in H5, also fixed dot/mdot effects.
------------------------------------------------------------------------
r8998 | nonom | 2012-07-15 10:01:07 -0300 (Sun, 15 Jul 2012) | 1 line

BETA: Html fixes for the Bandit Stronghold related NPCs.
------------------------------------------------------------------------
r8999 | Adry_85 | 2012-07-15 15:10:30 -0300 (Sun, 15 Jul 2012) | 7 lines

BETA: Ported some quests from Jython to Java and updated to H5:

- A Clan's Reputation (508).
- A Clan's Fame (509).
- A Clan's Prestige (510).

Thanks '''jurchiks''' and '''nonom''' for help.
------------------------------------------------------------------------
r9000 | nonom | 2012-07-15 19:46:04 -0300 (Sun, 15 Jul 2012) | 1 line

BETA: QuestState improvements for Q10273 & Q10274. Patch by: jurchiks
------------------------------------------------------------------------
r9001 | Adry_85 | 2012-07-16 18:44:59 -0300 (Mon, 16 Jul 2012) | 1 line

BETA: '''To the Primeval Isle''' Quest from Jython to Java.
------------------------------------------------------------------------
r9002 | Adry_85 | 2012-07-16 19:08:25 -0300 (Mon, 16 Jul 2012) | 5 lines

BETA: The starting level for the quest '''In Search of The Nest''' has been increased from 66 to 81 due to changes made to the Stakato Nest. ('''Source:''' http://legacy.lineage2.com/news/graciae ... 1.html&#41;
- Updated to H5.
- Ported from Jython to Java.

Thanks '''jurchiks''' and '''nonom''' for help.
------------------------------------------------------------------------
r9003 | UnAfraid | 2012-07-17 21:45:14 -0300 (Tue, 17 Jul 2012) | 1 line

BETA: DP-Part for [L5517]
------------------------------------------------------------------------
r9004 | UnAfraid | 2012-07-17 21:46:42 -0300 (Tue, 17 Jul 2012) | 1 line

BETA: Also dropping the old userIP field in accounts table.
------------------------------------------------------------------------
r9005 | UnAfraid | 2012-07-17 22:27:22 -0300 (Tue, 17 Jul 2012) | 1 line

BETA: More for [9004]
------------------------------------------------------------------------
r9006 | Zoey76 | 2012-07-18 15:56:00 -0300 (Wed, 18 Jul 2012) | 1 line

BETA: Datapack for [5519].
------------------------------------------------------------------------
r9007 | Zoey76 | 2012-07-18 18:02:27 -0300 (Wed, 18 Jul 2012) | 4 lines

BETA: Reworking Connection closing by using try-with-resource:
* Using Statement instead !PreparedStatement where parameters are not required.
* Minor change in formatter settings to give proper format to try-with-resource statement.
* Fixed many resource leaks.
------------------------------------------------------------------------

[Zoey76]

New synchronization (1):

SPOILER:

r5523 | Nik | 2012-07-24 14:51:38

BETA: Pets will no longer take party items without giving the chance to distribute them.

r5524 | Nik | 2012-07-24 15:46:39

BETA: Some useful utils. I hope you find them as useful as I did

r5526 | nBd | 2012-07-26 13:26:53

BETA: Extend Quest for ItemBypass (tnx JIV for it!)

r5527 | Nik | 2012-07-27 13:10:24

BETA: Currently, summons that are affected by effects which use weapon/armor conditions (such as Boost Morale, Angelic Icon, Spirit of Shilen etc.) pass those conditions only if their owner passes them. This is wrong. Summons dont have weapons nor armors, therefore effects that require weapon/armor condition shouldnt affect summons no matter if their owner meets the requirements or not.

If you somehow think that this change is wrong, that summons should get the bonuses if their owners met the requirements, make a post and prove me that im wrong.

r5528 | Nik | 2012-07-27 14:01:53

BETA: Fix for possible NPE in my last commit [5527]

r5529 | Zoey76 | 2012-07-27 19:06:29

BETA: Minor fix for Telnet:

Reported by: Tavo22

r5530 | UnAfraid | 2012-07-28 07:36:19

BETA: Core-part for [DP9027]

r5531 | UnAfraid | 2012-07-28 07:42:55

BETA: Adding some new listeners
* Dlg Answer listener
* Notify when client sent DlgAnswer packet.
* RequestBypassToServerListener
* Notify when client sent RequestBypassToServer packet.

r5532 | UnAfraid | 2012-07-28 08:17:08

BETA: More listeners
* Added char create/delete/restore/select listener
* Added some TODO tasks

r5533 | UnAfraid | 2012-07-28 09:15:06

BETA: Typo fix from [5530] and little javadocs typo

r5534 | Zoey76 | 2012-07-29 17:48:30

BETA: If configuration files aren't present server shouldn't crash:
* [#update Fixed typo in default IdFactory, Compaction is disabled and default in file is BitSet.]
* [#update Fixed missing default for GameserverHostname, now is *]
* [#update Removed useless exceptions throws.]
* [#update Fixed some logs messages.]
* [#update Capitalized all properties file names.]
* [#update The AcceptNewGameServer default value in file is now true, same as it's in Config.java]
* On server set up there is no need to register it anymore (hexid.txt).
* [#update The LoginHostname default value is now 127.0.0.1]
* After !AcceptNewGameServer is set to true it will accept any game server, so binding it to localhost is required.
* [#update Restored DatapackRoot for login server.]
* [#update Changed some log level from config to info.]
* [#update if ipconfig.xml is missing Game Server is binded to localhost.]
* Fixed some !JavaDocs.



r5535 | UnAfraid | 2012-07-29 18:23:24

BETA: Quest#getHtm() ArrayIndexOutOfBoundsException typo fix Reported by: DareStrike, thecast

r5536 | Ahmed | 2012-07-29 18:51:00

BETA:
* Rename getAttackStanceTask() method to hasAttackStanceTask()
* Epsilon approach for "TODO: (Zoey76) This is mathematically wrong." in L2Character
* Comment corrections in SystemMessage

r5537 | MELERIX | 2012-07-30 00:10:33

BETA/COMMUNITY/LIBS: Some minor updates/fixes.
* Minor Update for Builders javac task to prevent Ant from creating empty dummy classes.
* Updated Eclipse settings (same that core) for Libs Projects and Community Server.
* Removed -switchDefault from warn settings in ECJ due is already ignored by default.

r5538 | Zoey76 | 2012-07-30 21:52:28

BETA: Object oriented Zone settings:
* This should allow safe reloading.
* [viewtopic.php?f=69&t=25730 Forum thread: Safe zone reload]

Patch by: UnAfraid

r5539 | UnAfraid | 2012-07-31 18:34:04

BETA: Reverting some changes of [5537] please keep compatibility for the 1.8.2 version!

r5540 | UnAfraid | 2012-07-31 19:07:20

BETA: Core-Part for [DP9036] (Removing the terrible hack)

r5541 | UnAfraid | 2012-07-31 19:10:00

BETA: Fixing server stuck during zone reload.

r5542 | UnAfraid | 2012-08-01 12:48:38

BETA: Adding two useful methods to QuestState: isSet and getCond.
* Patch by: jurchiks

r5543 | UnAfraid | 2012-08-01 13:12:54

BETA: Moving wrong-placed listener.

r5544 | UnAfraid | 2012-08-02 14:13:02

BETA: Add Olympiad H5 Features:
* The new UI for match list will now appear.
* The new UI for match end will now appear.
* Added some TODO tasks
* Patch by: JIV


r5545 | UnAfraid | 2012-08-02 14:24:52

BETA: When you accept a quest, the game system examines your character's inventory and quest inventory to determine if your character has enough free inventory space for the quest item or items. Previously, if the combination of both inventories was 80% full, you could not accept the quest. This percentage has increased to 90%.

r5546 | UnAfraid | 2012-08-02 14:30:32

BETA: Cleanup of Olympiad classes and little typo fix.

r5547 | UnAfraid | 2012-08-02 15:11:14

BETA: Fixing Linux DB Installers Reported by: tukune

r5548 | UnAfraid | 2012-08-05 12:20:11

BETA: Olympiad config typo fix.
* Patch by: K4N4BS

r5549 | UnAfraid | 2012-08-05 12:51:34

BETA: Little Cleanup for [5548]

r5550 | UnAfraid | 2012-08-05 15:14:29

BETA: While player casting an it's target move behind a wall/door/etc.. cast must be aborted.
* Patch by: Tavo22

r5551 | UnAfraid | 2012-08-08 10:43:50

BETA: Removing flag unset when player die sometimes it can add karma if player had servitor alive and it was killed after the player.
* More Info: viewtopic.php?f=77&t=25668
* Reported by: Tavo22, facheme, blacksea

r5552 | nonom | 2012-08-09 21:19:18

BETA: Minor improvement for RaidBossSpawnManager.
* The respawn should be controlled by AI when minRespawn and maxRespawn both are equal to 0.
* Formatting and Cleaning.

r5553 | UnAfraid | 2012-08-10 10:11:22

BETA: Config for geodata directory location.
(If you have more then one server now you can share same geodata files)

r5554 | nonom | 2012-08-11 18:02:49

BETA: Config for pathnode directory location.

r5555 | nonom | 2012-08-11 19:33:30

BETA: Minor fix for L2AttackableAI and L2RaidBossInstance.
* Attackables shouldn't add Static Objects like possible targets.
* Unharcoding Gordon in L2RaidBossInstance.

r5556 | UnAfraid | 2012-08-12 09:42:27

BETA: Fixing Logistics Officer's missing htmls.
* Patch by: malyelfik

r5557 | Zoey76 | 2012-08-12 13:44:28

BETA: Minor changes to getHtm() method by UnAfraid, there will be examples of use later.

r5558 | UnAfraid | 2012-08-12 14:28:38

BETA: Handlers rework:
* Using generic interface to standardize current and future handlers.
* Added removeHandler method.
* Cleanup of all the package.

* Misc:
* Little cleanup of QuestManager.
* Added the new Say2 npc types (In h5 there is a filter for them)
* TODO: Use them.

r5559 | Zoey76 | 2012-08-12 16:25:34

BETA: Minor fix for Crating feature, extra from [5395].

Reported by:
u3games
valdaron
Tested by:
u3games

r5560 | UnAfraid | 2012-08-13 11:03:41

BETA: Fixing little typo with npc showName/targetable seems i swapped them in first implementation.

r5561 | UnAfraid | 2012-08-13 11:07:08

BETA: Fixing the method !addItemName(int) to support custom items as well.

r5562 | UnAfraid | 2012-08-13 12:52:25

BETA: Moving some npc instances to dp scripts:
* L2BirthdayCakeInstance
* L2CabaleBufferInstance
* L2TotemInstance

* And little some cleanup.

r5563 | Zoey76 | 2012-08-13 19:20:30

BETA: Addressing the problem with resource leaks.
* Using [http://en.wikipedia.org/wiki/Encapsulat ... ramming%29 encapsulation] to avoid the System.in input stream to get closed.
* build.xml changes to include it in tools by UnAfraid, thanks.
* Closing #6273


Tested by: UnAfraid

r5564 | UnAfraid | 2012-08-16 13:34:34

BETA: Fixing NPE for not existing child door.
* Reported by: Micr0

r5565 | Zoey76 | 2012-08-19 15:07:01

BETA: Replacing Trove4J with !Java/Javolution in some places:
* Replaced Trove from Config.
* Instead of returning !ArrayList or !FastList returning the superinterface List, this way we can change the underlying implementation without changing the whole code (same for Map and Set).
* Replaced Trove in Instance class, removed some synchronizations replaced with shared !FastList, require feedback.
* Added a new method to Quest class.
* public List<L2NpcTemplate> addKillId(Collection<Integer> killIds)
* Updated Trove to 3.0.3.
* Updated L2TIntObjectHashMap implementation to match the framework's implementation by [[Ahmed]].
* Using !DocumentParser for ipconfig.xml using a static class.

'''Note:''' Update your library folder properly!

r5566 | UnAfraid | 2012-08-19 17:54:39

BETA: SystemMessage packet update:
* Added Door Name type (id 11)
* Added some TODO tasks.
* Fixed some typos in localization method.
* Cleanup.

r5567 | UnAfraid | 2012-08-19 17:55:42

BETA: Updating L2FastList/L2FastMap to use IL2Procedure and drop of all unused custom maps in gameserver's util package.

r5568 | UnAfraid | 2012-08-19 18:26:53

BETA: Some reworks and cleanup:
* DoorTable:
* Trove -> HashMap migration.
* Removing hashCode usage its wrong please quit using it!
* Cleanup.
* Instance:
* _spawnLoc int[] -> Location by [[Zoey76]]'s request.
* Using IL2Procedure for the Packet broadcast and eject by [[Zoey76]]'s request.
* _doors List<L2DoorInstance> -> Map<Integer, L2DoorInstance> for faster doorId lookup.
* Cleanup.
* AbstractPlayerGroup:
* FastList -> ArrayList migration.
* Cleanup.
* StatsSet:
* Changing constructor to provide support for any kind of map (It can be used for example with TreeMap for alphabetical key order or HashMap for fifo = first in / first out order)
* And some misc code update/cleanup.

r5569 | Zoey76 | 2012-08-19 22:21:53

BETA: Misc fixes:
* Unhardcoding Territory Ids at !TerritoryWarManager.
* Moving and renaming gameserver/Territory to gameserver/datatables/TerritoryTable
* Renaming addFortId(int) to addCastleId(int), it manages the parameters for Castles, Halls, Fortress, Contestable Clan Halls, Territories, couldn't find a better world using client file name as reference.
* Fixing !JavaDoc at !SystemMessage#addCastleId(int)
* Unhardcoding all Castle names in Siege, thanks UnAfraid for the tip.

r5570 | UnAfraid | 2012-08-21 12:23:55

BETA: Fixing some NPE's that recently appeared.
* Patch by: malyelfik

r5571 | Ahmed | 2012-08-22 08:00:34

=== '''[BETA]''' ===

1. Within ''L2NpcAIData.java'':
- '''(Style)''' String.equals("") is now replaced with String.length() == 0.[[BR]]
(Avoid bad practice of returning true/false based on equating a String, instead use the strings length)

r5572 | Ahmed | 2012-08-22 17:23:06

=== '''[BETA]''' ===

1. Within ''L2NpcAIData.java'':
- '''(Style)''' String.length() == 0 changed to isEmpty() as suggested by UnAfraid and Zoey76. [[BR]]
(isEmpty() returns true if String.length() == 0, false if String.length() is not 0)

r5573 | UnAfraid | 2012-08-23 13:01:28

BETA: Some misc changes:
* Added source archive for javolution.
* Added custom HashMap - L2HashMap:
* Added IL2EntryProcedure support (Designed for internal iteration key and value)
* Added IL2Procedure support (Designed for internal iteration key only or value only)
* Added custom ArrayList - L2ArrayList:
* Added IL2Procedure support (Designed for internal iteration for value only)
* Simplify logic in DoorTable.
* Removing ejectPlayer method and moving it's content in EjectProcedure.
* Adding registerQuestItems(int... items) method in Quest.

r5574 | UnAfraid | 2012-08-24 11:12:53

BETA: Fixing little typo from 5565 also fix for ticket #6306
* Reported by: mjaniko, Micr0

r5575 | UnAfraid | 2012-08-25 13:50:27

BETA: Minor cleanup.

r5576 | UnAfraid | 2012-08-25 14:37:40

BETA: Fixing conflict in forget/watch ranges on attackable knownlist.
* Reported by: tukune
* Patch by: Tryskell

r5577 | UnAfraid | 2012-08-25 14:50:28

BETA: Misc fixes:
* Fixing little npe from [5565]
* Reported by: Nik
* Excluding GMs from flood protector checks.
* Adding useful method getPlayersCountInRadius() in Util.
* Patch by: Tryskell
* Removing 1 useless method in L2PcInstance.

r5578 | UnAfraid | 2012-08-25 15:14:18

BETA: Fixing some more NPEs.
* Reported by: Nik

r5579 | UnAfraid | 2012-08-25 15:35:30

BETA: Fixing some NPEs in Formulas.
* Reported by: Nik

r5580 | Zoey76 | 2012-08-25 19:03:41

BETA: Minor fixes:
* Fixing more NPE vulnerabilities from [5565].
* All changes in Config class has been review and some parts improved.
* In !CursedWeapon replaced hard-coded custom text with system message, it may still be custom, although I think is proper message.

r5581 | UnAfraid | 2012-08-25 21:22:10

BETA: Knownlists revise:
* Increasing distance to watch for walkers to 9000 from 8000.
* Considering vehicles as walkers.
* Allowing L2NpcInstance to see objects too.
* Cleanup.

r5582 | Zoey76 | 2012-08-26 17:46:05

BETA: Minor fix for configs.

Patch by: malyelfik

r5583 | Zoey76 | 2012-08-26 17:59:49

BETA: Cleanup.
* Removed WayPointNode class.
* Removed multiple duplicates of !ItemHolder class.
* Removed unused related properties.

Suggested by: UnAfraid

r5584 | Zoey76 | 2012-08-26 21:54:58

BETA: Reworking L2ClanMember related code:
* Fix for !Noblesse/Hero status for clanless characters. Patch by: Tavo22
* With minor changes.
* Removed useless constructors.
* Replaced L2ClanMember(L2Clan clan, String name, int level, int classId, int objectId, int pledgeType, int powerGrade, String title, boolean sex, int raceOrdinal) with L2ClanMember(L2Clan clan, !ResultSet clanMember).
* Added !JavaDocs to L2ClanMember.
* L2ClanMember#calculatePledgeClass(..) is now static.
* L2ClanMember class format and clan up.
* !ClanTable class format and clan up.
* Updated other related classes.

r5585 | UnAfraid | 2012-08-27 04:35:30

BETA: Using the new npc chat types.
* Say2.ALL -> Say2.NPC_ALL
* Say2.SHOUT -> Say2.NPC_SHOUT
* Continuing from [5558]

r5586 | Zoey76 | 2012-08-27 14:48:30

BETA: Minor fix for [5584] at L2ClanMember.
* L2Clan class format and cleanup (without code changes).


Reported by: Tavo22

r5587 | UnAfraid | 2012-08-27 20:38:51

BETA: Fixing possible NPE.

r5588 | nonom | 2012-08-28 18:13:37

BETA: Encapsulating quest sounds in an enum; saves some memory and CPU by reusing pre-constructed objects instead of creating new ones each time a script calls the playSound method. Read QuestSound comments for more info.
* Usage: st.playSound(QuestSound.ITEMSOUND_QUEST_MIDDLE) instead of st.playSound("ItemSound.quest_middle").
It doesn't require an import for QuestSound.
Patch by: jurchiks

r5589 | MELERIX | 2012-08-29 20:07:31

BETA: Support for PeaceZone in Boats.

r5590 | Ahmed | 2012-08-30 14:15:53

BETA: NPE Fix:
1. Within !Formulas.java:
- Thanks for reporting it valdaron
- Thanks for pointing it out UnAfraid

r5591 | UnAfraid | 2012-08-30 15:12:01

BETA: Fixing visual glitch when using Steer in Clan Airship it wasn't displaying properly the Airship helm.

r5592 | Ahmed | 2012-08-30 17:56:17

BETA: Optimization of Util.printData
- New Class: !HexUtils, contains static methods to convert bytes, integers and byte arrays to hexadecimal character presentation.
- It also has an optimized version of the hex editor like data dump of Util.printData(byte[], int) which is faster.
- Util.printData() modified to use the new !HexUtils.bArr2HexEdChars() method

by FBIagent, Thank You.

r5593 | UnAfraid | 2012-08-30 18:52:31

BETA: Quest class changes:
* _questInvolvedNpcs to Set and implementing getter.
* _allEventTimers to L2FastMap and implementing getter.

r5594 | MELERIX | 2012-08-30 21:55:03

BETA: CORE-Part for [DP9120].

r5595 | UnAfraid | 2012-08-31 11:07:47

BETA: RequestRestartPoint changes:
* When GM using fixed res he won't be teleported but just revived.
* Cleanup.

r5596 | UnAfraid | 2012-08-31 16:35:14

BETA: Fixing NPE in ItemsOnGroundManager related to non thread-safe list.
* Reported by: valdaron

r5597 | UnAfraid | 2012-08-31 16:59:00

BETA: Upon clan removal cancel any active clan hall bids.
* Reported by: valdaron

r5598 | MELERIX | 2012-08-31 18:51:26

BETA: Minor fix for [4771] "To Castle "& "To Clan Hall" buttons should be visible even if player is inside a respawn zone, except if player is jailed.

Reported by: facheme
Tested by: facheme

r5599 | UnAfraid | 2012-08-31 19:13:38

BETA: Fixing NPE Vulnerability please keep in mind Die server packet is not for players only but for monsters too using getActingPlayer will return null for monster!

r5600 | Zoey76 | 2012-08-31 20:44:44

BETA: Updating Multilingual system properties.

r5601 | Zoey76 | 2012-08-31 21:22:16

BETA: Spelling check for config properties.

r5602 | Zoey76 | 2012-08-31 21:25:54

BETA: Rest of [5601]

r5603 | Zoey76 | 2012-08-31 21:27:39

BETA: Rest of [5601]

r5604 | Ahmed | 2012-09-02 14:21:57

BETA: Updating !QuestSound enum.
* Patch by: jurchiks

r5605 | Ahmed | 2012-09-02 15:52:09

BETA: Some trivial spelling corrections.

r5606 | UnAfraid | 2012-09-03 08:09:16

BETA: Some cache classes review:
* HtmCache to javolution.
* Removing hashCode usage as i said many times its wrong.
* Cleanup.

r5607 | UnAfraid | 2012-09-03 10:47:12

BETA: L2PcInstance cleanup:
* bypass validation lists to Javolution.
* Using addItemId in SystemMessage where String was used for.
* Cleanup.

r5608 | UnAfraid | 2012-09-03 10:50:49

BETA: FrequentSkill to SkiillHolder instead of manual update after server load/reload skills.

r5609 | UnAfraid | 2012-09-03 10:52:36

BETA: Cleanup of L2PetInstance

r5610 | UnAfraid | 2012-09-03 11:54:09

BETA: Fixing NPE when Zone is null and banishForeigners is called().
* Also some minor cleanup.
* Reported by: valdaron

r5611 | UnAfraid | 2012-09-03 11:57:31

BETA: Fixing banishForeigners() method in some zone typs it could miss clanless players.
* Reported by: jurchiks

r5612 | UnAfraid | 2012-09-03 14:18:45

BETA: Minor typo fixes:
* NpcWalkerAI:
* Minor typo in delay warn.
* Reported by: drathir
* L2Object:
* Cleanup forgotten npc instances from [5562]
* Reported by: Ahmed

r5613 | UnAfraid | 2012-09-04 21:01:37

BETA: Some misc changes:
* Loggers review:
* Added getClass().getSimpleName() as prefix.
* Added some missing loggers.
* Removed useless spammy debug logs.
* !L2Manor:
* Moved to datatables as ManorData.
* XML Reading to DocumentParser.
* Other:
* Some trove -> Java maps or Javolution (When thread-safety is needed)

r5614 | UnAfraid | 2012-09-05 11:44:15

BETA: Item classes cleanup.

r5615 | UnAfraid | 2012-09-06 10:13:10

BETA: Some Quest related improvements.
* Patch by jurchiks

r5616 | MELERIX | 2012-09-06 16:19:01

BETA: Simplified Formulas for '''Curse Death Link''' & '''Fatal Counter''', also updated to match retail (98% at least).

Reported & Tested by: facheme

Thanks to:
* jurchiks (for some help).
* tans (for retail info with pictures about damage depending of HP's amounts).

More info: viewtopic.php?f=69&t=26128

r5617 | UnAfraid | 2012-09-06 18:49:16

BETA: Removing debug stacks.
* Reported in #6316

r5618 | Adry_85 | 2012-09-07 09:46:06

BETA: Moving Christmas Tree instance to dp scripts.

r5619 | UnAfraid | 2012-09-08 09:08:16

BETA: Core-Part for [DP9157]

r5620 | UnAfraid | 2012-09-08 09:08:33

BETA: Core-Part for [DP9157]

r5621 | UnAfraid | 2012-09-08 09:14:57

BETA: ManorData cleanup

r5622 | Zoey76 | 2012-09-08 13:58:34

BETA Quest class improvements.

Patch by: jurchiks
Reviewed by: Zoey76

r5623 | Ahmed | 2012-09-08 18:47:56

BETA: Some changes to visibility and some spelling corrections.

r5624 | Ahmed | 2012-09-08 19:28:17

BETA: Castle and Fort skils fix.
* Core-Part for [DP9160]

Patch by: Nik
Tested by: Tavo22
Reviewed by: Ahmed

r5625 | UnAfraid | 2012-09-09 08:10:09

BETA: Fixing minor NPE since [5622]
* Reported by: ivantotov, Adry_85

r5626 | UnAfraid | 2012-09-09 08:45:01

BETA: Your Pet won't be gone even when you don't feed it.

r5627 | Zoey76 | 2012-09-09 20:36:23

BETA: Fixes:
* Removing unneeded explicit "this" qualifier.
* Removing all invalid float/double comparisons, using Epsilon approach.
* Replacing str.startsWith("#") with str.charAt(0) == '#'
* Replacing try/catch with if statement in Quest when item count exceeds Long.MAX_VALUE, Suggested by: UnAfraid
* Replacing loop to copy arrays with System.arraycopy(..)
* Fixed typo in JavaDoc in SystemMessage, Reported by: UnAfraid
* Fixed Integer division for floats.
* Replaced (str.length() == 0) with str.isEmpty() and (str.length() != 0) with !str.isEmpty().
* Avoiding unnamed threads.
* Replacing End of Line character(s) with platform independent constant.
* Minor fixes to .properties files, keep the new line, so it will display correctly in the configuration tools.

r5628 | Zoey76 | 2012-09-10 19:15:52

BETA: Minor typo fix for [5627]:
* Cleanup for Geodata related classes.
* Replacing Trove4J with Java's map implementation.

Reported by: Lupu1, valdaron, Pain

* More cleanup and formatting, Suggested by: UnAfraid

r5629 | UnAfraid | 2012-09-10 20:05:47

BETA: Unhardcoding GM player condition.
(In another words you can turn off/on most of your special conditions with !//exceptions in order to test something just like player without loosing your powers as GM).

r5630 | UnAfraid | 2012-09-10 20:17:20

BETA: Adding auto network configuration method.
* When '''ipconfig.xml''' exists in config folder manual configuration method will be selected (What ipconfig.xml contains that would be it) otherwise your network configuration will be setup automatically.
* Patch by: mrTJO, UnAfraid

r5631 | MELERIX | 2012-09-11 05:43:53

BETA: Added License for Java Subnetting API missing from [5630].

r5632 | malyelfik | 2012-09-11 15:46:39

BETA: Minor fix for [5615]

r5633 | UnAfraid | 2012-09-13 16:21:00

BETA: Fixing typo that was preventing from sending clan updates to player when level up.
* Reported by: facheme, valdaron

r5634 | Zoey76 | 2012-09-13 18:23:38

BETA: Minor fix for [5552]:
* Cleanup and minor code refactoring.

Reported by: tukune

r5635 | UnAfraid | 2012-09-13 18:45:09

BETA: Fixing NPE that could occur if server delete a clan before it's completely loaded.
* Reported by: valdaron

r5636 | Zoey76 | 2012-09-13 21:17:21

BETA: Moving Zone Ids out of L2Character:
* Unhardcoded zone Ids count.
* Declared dummy isInsideZone(..) method in L2Object to avoid useless casting.
* Removed ZONE_ prefix from zone Ids.
* Removed "<BR><BR>" in !JavaDocs in L2PcInstance.
* Removed "this" qualifier in L2PcInstance where is not required.

r5637 | UnAfraid | 2012-09-13 22:20:06

BETA: Shots rework:
* Using inheritance to simplify code and reuse it.
* Implemented isPhyisical method to L2Skill to use properly soulshots.
* Keeping charged shots when unequip item to match retail behavior.

r5638 | Zoey76 | 2012-09-14 00:39:33

BETA: Rune of Crystal implementation:
* Support for bonus and penalty calculation using bonus.

r5639 | UnAfraid | 2012-09-14 10:38:04

BETA: Fixing sub-class certification it should require Quest [http://l2jdb.l2jdp.com/db_quest.php?id=136 More Than Meets the Eye].
* Reported by: facheme
* Patch by: Tavo22
* Reviewed by: Zoey76

r5640 | Zoey76 | 2012-09-15 19:12:10

BETA: Complete source formatting and cleanup.
* Many JavaDocs has been fixed, as well as many typos in comments.
* Removed old/out-dated/experimental commented out code in many places.
* Fixed minor typo in [5638], seems the patch applied wrongly, Reported by: St3eT, malyelfik, thorl2
* Closing #6322
* Added "On save actions" for the project.

'''Note: From now on all code committed must be formatted.'''

r5641 | UnAfraid | 2012-09-15 19:54:14

BETA: Unhardcoding isLethalable.

r5642 | Zoey76 | 2012-09-15 21:23:21

BETA: Minor typo fix.

Reported by: UnAfraid

r5643 | MELERIX | 2012-09-15 23:16:42

COMMUNITY/BETA: MySQL Connector/J 5.1.22, Changelog here: ?http://dev.mysql.com/doc/refman/5.1/en/ ... -1-22.html & JavaMail API 1.4.5, Changelog here: http://www.oracle.com/technetwork/java/ ... 62616.html

r5644 | Zoey76 | 2012-09-16 13:52:17

BETA: Continuing with [5483] and [5520]:
* Using Statement, !PreparedStatement and !ResultSet with try-with-resource.
* Replacing !PreparedStatement with Statement where no parameters are given.
* Minor cleanup.

r5645 | Zoey76 | 2012-09-16 14:34:00

BETA: Minor typo fix.

Reported by: VlLight

r5646 | UnAfraid | 2012-09-16 15:45:31

BETA: Fixing NPE when summoning Servitor (It should search for shots in Owner's inventory) Closing: #6324
* Reported by: thorl2

r5647 | MELERIX | 2012-09-17 10:42:40

BETA: "numCharges" is not longer used to generate charges due it was replaced by effect "IncreaseCharges" since [4312], so now is renamed to "chargeConsume", also removed "maxCharges" due now is handled by condition "player charges" from each skill.

r5648 | UnAfraid | 2012-09-17 12:25:16

BETA: Fixing little bug from [5637] since now on pets will be able to use shots even if they don't have a weapon.
* Reported by: Tryskell

r5649 | Zoey76 | 2012-09-17 15:50:54

BETA: Minor typo fix in ItemsOnGroundManager from [5644].

Reported by: valdaron

r5650 | MELERIX | 2012-09-17 18:39:52

BETA: Same Settings that "L2J Clean Up v0.2" for "On save actions".

r5651 | MELERIX | 2012-09-17 19:19:09

BETA: Reverted [5650].

r5652 | UnAfraid | 2012-09-18 20:28:37

BETA: Removing Bean Shell script engine.
* The only thing we used it for was Feanor but since [5299] we no longer use it.

r5653 | UnAfraid | 2012-09-20 12:23:45

BETA: Support for custom progressive enchanting.
* Note: To enable it check enchantData.xml for examples.
* Also when enchant scroll isn't loaded NPE wont be thrown.
* Reported by: baluu

r5654 | UnAfraid | 2012-09-20 22:05:42

BETA: Implementing enchant bonus options for some premium items (It's like an augment but only for few items, shirts mostly)
* Note: This is only visual implementation the stats aren't done yet!
* Reviewed by: Zoey76, MELERIX

r5655 | MELERIX | 2012-09-21 00:22:11

BETA: CORE-Part for [DP9206].

r5656 | UnAfraid | 2012-09-21 02:31:08

BETA: Fixing little NPE.

r5657 | UnAfraid | 2012-09-21 11:31:36

BETA: Moving some code in L2ItemInstance before listeners and overriding getActingPlayer to return the owner.

r5658 | UnAfraid | 2012-09-21 14:18:50

BETA: Fixing little typo from [5654].
* Reported by: St3eT

r5659 | MELERIX | 2012-09-22 14:24:00

BETA: Minor cleanup due [DP9214] (this things are already verified by <player souls="X" /> conditions in skills).

r5660 | MELERIX | 2012-09-22 16:09:03

BETA: Removed "soulConsumeCount" (is not longer used because was replaced by "soulMaxConsumeCount").

r5661 | Zoey76 | 2012-09-23 13:25:03

BETA: Implementation of reuse delay for items and item skills for pets.
* Independent reuse delay from masters (fix bug with shared reuse time).
* Implemented for items.
* Implemented for skills.
* It doesn't show system messages (retail like) when pet has reuse time for items or skills.
* Fixed bug with pets not getting herbs.
* Removed custom system messages.
* Unhardcoded some shop Ids.

Reported by: Tavo22, u3games, valdaron
Tested by: Zoey76, valdaron, MELERIX

r5663 | MELERIX | 2012-09-25 21:33:23

BETA: CORE-Part for [DP9222], also updated charges formula.

r5664 | Zoey76 | 2012-09-28 19:25:08

BETA: More quest sounds.

Reported by: valdaron
Patch by: jurchiks
Reviewed by: Zoey76

r5665 | MELERIX | 2012-09-28 20:54:25

BETA/LIB: ECJ Lib Update.

r5666 | MELERIX | 2012-09-29 15:10:50

BETA: Removed some redundant/custom checks for teleport/escape skills, no longer needed with [DP9223].

r5667 | MELERIX | 2012-10-02 00:43:50

BETA: CORE-Part for [DP9230]

r5668 | UnAfraid | 2012-10-10 09:37:02

BETA: Fixing little typo (In [5641] i've forget default value of lethalable variable which made every L2Character non lethalable)
* Reported by: St3eT

r5669 | UnAfraid | 2012-10-10 09:53:59

BETA: Updating a bit L2World OID Map error logs.

r5670 | UnAfraid | 2012-10-10 10:09:14

BETA: Misc Fixes:
* L2Character:
* Fixing HP Update when equip/un-equip item which gives/takes HP.
* L2World:
* Log cleanup.
* if (object instanceof L2PcInstance) => if (object.isPlayer())
* Cleanup comments.
* Stats:
* Comments typo fixes.
* FuncTemplate:
* Catching all exceptions at once instead catching every possible exception separately.

r5671 | UnAfraid | 2012-10-10 21:46:02

BETA: Fixing tickets: #6332 #6285 #6336
* Tested by: Micr0

r5672 | MELERIX | 2012-10-11 01:24:58

COMMUNITY/BETA: C3P0 Lib Update, also removed some unused skill parameters.

r5674 | MELERIX | 2012-10-11 15:56:44

BETA: Restored min/maxChance skill parameters, some servers use it to customize skills individually instead of globally by configs.

r5675 | MELERIX | 2012-10-11 19:23:55

BETA: Fixed some effects with chance not being affected by min/maxChances, like in: Shadow Step skill and others (Reported by: H4vok, facheme). Also renamed config for consistency.

r5676 | UnAfraid | 2012-10-12 19:19:36

BETA: Reworking doors:
* Removing StatsSet from L2DoorInstance's constructor.
* Possibility to override every single param of each door from instance xmls.
* Created getters for L2DoorTemplate no more public variables access.
* Added Missing credits to DoorTable

* Reviewed by: Zoey76
* Tested by: Micr0

r5677 | malyelfik | 2012-10-13 14:22:47

BETA: Core part for [DP9242]

r5678 | malyelfik | 2012-10-14 12:23:05

BETA: Fix for #6337

r5679 | UnAfraid | 2012-10-16 11:03:53

BETA: Fixing the issue with Decoy skill (Not working in instance).
* Reported by: St3eT, Adry_85

r5680 | malyelfik | 2012-10-16 17:59:19

BETA: !ExQuestNpcLogList packet
Patch by: !UnAfraid

r5681 | UnAfraid | 2012-10-17 08:01:24

BETA: Fixing calculation of bonus Exp.
* Reported by: netvirus, VlLight, MELERIX

r5682 | UnAfraid | 2012-10-18 23:13:20

BETA: Misc Fixes:
* Fixing lethal bug in L2GrandBossInstance.
* Reported by: St3eT
* Patch by: St3eT
* Fixing bug in Anti Feed Feature.
* Reported by: Lupu1, vampir
* Patch by: vampir
* L2DoorInstance:
* Fixing typo in broadcastInfo (If there's a GM in knownlist of the door other players may see the door targetable)
* Fixing reduceCurrentHp (Wall restriction will not work for instances)
* OnEventTrigger:
* Capitalization of static variable.
* PcStat:
* More from [5681]

r5683 | UnAfraid | 2012-10-19 18:55:43

BETA: Renaming ExBuySellListPacket to ExBuySellList and removing the tradelist param since it wasn't used anywhere.

r5684 | MELERIX | 2012-10-21 08:37:44

BETA: CORE-Part for [DP9258].

r5685 | UnAfraid | 2012-10-21 15:35:50

BETA: Fixing 2 rare NPEs.

r5686 | Nik | 2012-10-28 13:14:06

BETA: IdFactory extractUsedObjectIDTable method cleanup and optimized with UnAfraid's suggestion -> use 1 query/db connection instead of many.

r5687 | UnAfraid | 2012-10-29 16:05:47

BETA: Adding useful method in L2DatabaseFactory it's designed for simple db operations like INSERT, UPDATE, DELETE.

r5688 | Zoey76 | 2012-10-29 20:33:22

BETA: SSQ Missing feature Lord of the Manor's Certificate of Approval:
* Implemented method isMyLord(player), verify if the player is clan leader and own the NPC's assigned castle or fort.
* Added configuration for some parameters and unhardcoded other related to SSQ.
* Support for sold tickets reset after castle's owner change or SSQ event change.
* Refactored some old SSQ code.
* Removed bsh-engine.txt file.
* Fixed few JavaDocs.

Reported by: valdaron

'''Note:''' C3 feature.

r5689 | Zoey76 | 2012-10-31 15:34:13

BETA: Blood Alliance and Blood Oath implementation logic fix:
* Now this values for reward are stored in clan data instead of castle or fort data.
* Fix for #6352

Patch by: VlLight, Zoey76

r5690 | VlLight | 2012-11-01 16:09:05

BETA: * Fixing error in saving clan data to database
* Reported by: ntalinio

r5691 | MELERIX | 2012-11-02 16:36:21

BETA: Fixed an issue where Herbs/Potions (with instant effects) were not working when you are with full-buffs (Reported by: Tavo22). Also now the Herbs/Potions (with continuous effects) will remove the first-buff when you are with full-buffs (Confirmed by: Tans, Valdaron).

r5692 | UnAfraid | 2012-11-02 16:49:27

BETA: Core-part of [DP9274]

r5693 | Zoey76 | 2012-11-03 18:21:18

BETA: Continuing with RequestActionUse improvements:
* Cleanup of unnecessary code.
* Added/fixed JavaDocs.
* Removed custom check for summons not being able to use skills while master is in shop mode.
* Removed ''spammy'' log for missing skills in summons, it comes from skill shortcuts in shortcut bar from different summon that current one.
* Removed custom/hard-coded system messages.
* Added missing next action for player requesting a couple action while casting.
* System message is sent right away but action is performed after previous action is finished.
* Added missing next action for player requesting a couple action while moving.
* System message is sent right away but action is performed after previous action is finished.
* Ordered actions Ids.
* Validated all pet actions.
* Validated all servitors actions.
* Fixed typo in system message when trying to unsummon a servitor.
* Added missing system messages for pets and servitors.
* Removed more unnecessary code.
* Fixed exploit with passive summons using Attack action.
* Removed unnecessary methods.
* Added useful methods.
* Implemented Sin Eater NpcStrings for Ultimate Bombastic Buster.
* Renaming misleading getPet() method to getSummon(), since it returns the summon, which could be either a pet or a servitor.
* Renaming misleading hasPet() method to hasSummon(), since it returns the true, either the player has pet or a servitor.
* Replacing getPet() != null with hasSummon() and getPet() == null with !hasSummon().
* Added missing check that would allow players to exploit the rename pet feature.

Reported by: darknessneo, Opiam, Zoey76, valdaron

r5694 | Zoey76 | 2012-11-03 18:44:24

BETA: Support for Switch Stance.
* Now it performs all required checks.
* Still harcoded, since there is no retail effect for it.

r5695 | Zoey76 | 2012-11-03 20:56:08

BETA: Minor typo fixes in [5693].

Reported by: jurchiks

r5696 | Zoey76 | 2012-11-04 14:25:56

BETA: Implementing Summon Agathion effect:
* General cleanup.
* L2Effect shouldn't call onExit() right way if onActionTime() && _startConditionsCorrect yields true.
* Removed L2SkillAgathion hardcoded skill handler...
* Removed skill type AGATHION.

r5697 | MELERIX | 2012-11-04 16:28:56

BETA: Missing from [5691].

r5698 | MELERIX | 2012-11-04 21:57:28

BETA: Updated & Simplified Formula for '''Bows Ranged Damage'''.

'''Thanks to:'''
* UnAfraid (for retail info with pictures about damage results).
* Zoey76 (for some help in reducing the formula).

More info: viewtopic.php?f=91&t=16892&start=15#p156209

r5699 | Zoey76 | 2012-11-06 03:36:43

BETA: Minor typo fix for [5693].

Reported by: valdaron

r5700 | Zoey76 | 2012-11-06 15:37:42

BETA: Unifying NPC Id parameter in Skills.
* Cleanup, based in [5696].

r5701 | MELERIX | 2012-11-07 15:47:01

BETA: Some Improvements/Fixes for [5684].
* Fixed an issue (Reported by: facheme) that was causing "broken casting animation" in some skills (like: Hurricane, Veil, Trick, Switch) when the casting speed is really high (before, it was using 500ms, but is wrong, now is 550ms).
* Merged hitTime + coolTime in a single variable.
* Some improvements to reduce the code a bit.

Review by: Zoey76
Tested by: facheme

r5702 | MELERIX | 2012-11-07 15:53:35

BETA: Eclipse is a bad guy.

r5703 | Zoey76 | 2012-11-09 17:46:10

BETA: More fixes:
* Patch by: Zoey76
* Fixing summons unable to attack.
* Reported by: valdaron, arythea
* Fixing servitors unable to cast any skills.
* Reported by: arythea
* Fixing multiple pets not being able to cast specific skills.
* Patch by: UnAfraid
* PcFreight and L2Character cleanup.

r5704 | Zoey76 | 2012-11-10 23:50:28

BETA: Fixing issue with GM names and logs.
* Reported by: DareStrike

r5705 | Zoey76 | 2012-11-10 23:54:10

BETA: Minor typo in [5704].

r5706 | UnAfraid | 2012-11-12 23:06:45

BETA: Updating ShowBoard packet length in BaseBBManager.
* It must be 4096, 8192, 16384.

* Note: I tested with those values and it is working correctly it could be working with even higher!

r5707 | VlLight | 2012-11-17 15:44:22

BETA: Fixes for Olympiad Buffers
* Fixed: Olympiad Buffers did not disappear at battle start(reported by madrock)
* Added check for player pet's at Olympiad entrance

Review by: UnAfraid

r5708 | malyelfik | 2012-11-17 16:02:35

BETA: Core part for [DP9297]

r5709 | VlLight | 2012-11-18 06:18:58

BETA: Missed in [5707] - unused imports

r5710 | Adry_85 | 2012-11-20 14:26:38

BETA: Core part for [DP9301].

r5711 | MELERIX | 2012-11-20 18:41:10

BETA: Fix for Ticket #6384, Reported by: Nono.

r5712 | Nik | 2012-11-25 15:45:14

BETA: Memory leak fix: Since database connections are autoclosed via try/catch, the L2DatabaseFactory.close(con) is never called. Because of this, a memory leak occured -> the map is always filled with data, but never removed (it gets removed only when L2DatabaseFactory.close(con) is called).

r5713 | VlLight | 2012-11-27 17:51:50

BETA: New way for support long-continued events - for further refactoring.
* Reviewed by: UnAfraid

r5714 | VlLight | 2012-11-27 18:27:12

BETA: Support for "unequip_skill" parameter of items. Also fixes Ticket #6374
* Reviewed by: UnAfraid
* Tested by: djmouse

r5715 | Zoey76 | 2012-11-30 01:57:52

BETA: Misc fixes:
* Source format, please keep it that way.
* Avoid printStackTrace()
* Fixing warnings #6390

r5716 | UnAfraid | 2012-11-30 14:15:57

BETA: Fixing little typo in L2PcInstance.restore(int) introduced in [5715].
* Fixing retrieving logic there could be only one character with the same object id so while is not needed.

* Reported by: Adry_85

r5717 | Zoey76 | 2012-12-01 13:28:39

[Zoey76]

New synchronization (2):

SPOILER:

BETA: Minor cleanup.

r5718 | VlLight | 2012-12-08 17:27:28

BETA: Two new quest triggers was added.
ON_MOVE_FINISHED - invoked, when NPC stops after moving.
ON_EVENT_RECEIVED - invoked, when NPC receives an "event", sent via broadcastEvent() method.
* Reviewed by: UnAfraid

r5719 | Adry_85 | 2012-12-08 18:58:32

BETA: Fixed two warnings after [5718].

r5720 | MELERIX | 2012-12-09 16:21:17

BETA: Updated Initial ClanHall Auction Data.

r5721 | MELERIX | 2012-12-10 16:26:54

BETA: Minor update/format in few bat files, also removed unused/non-working power shell scripts.

r5722 | MELERIX | 2012-12-10 16:41:07

BETA: Oops wrong place ^^'

r5723 | Zoey76 | 2012-12-16 12:45:01

BETA: Minor rework in instances:
* teleToLocation(Location, int) now sets the player's instance as well.
* Use Location.setInstanceId(int instanceId) to set the instance which the player will be teleported.
* Minor cleanup.

r5724 | UnAfraid | 2012-12-19 12:10:55

BETA: Fixing shots for Monsters (Seems like i've never set their shots)
* Reported by: Tryskell

r5725 | UnAfraid | 2012-12-19 12:27:24

BETA: Fixing StackOverFlow in FuncShare (Probably happens when this Func is used on a Player instead of Summon)
* Reported by: Tavo22, DareStrike, Tryskell

r5726 | UnAfraid | 2012-12-19 12:52:53

BETA: Misc Changes:
* Moving Shots recharge in onSpawn in case of npc respawn it will have the remaining shots from previous death.
* Reported by: Tryskell
* Fixing potential NPEs in FuncShare.

r5727 | UnAfraid | 2012-12-19 13:43:57

BETA: Another shots fixes:
* Using useSoulShot() instead of isPhyisical() (Not all is_magic = 0 should use soulshots)


r5728 | UnAfraid | 2012-12-20 11:51:51

BETA: Adding more PlaySounds into QuestSound enum.
* Patch by lion

r5729 | UnAfraid | 2012-12-20 15:12:01

BETA: Fixing an issue which appears while moving and requesting some actions like private store or sit, looks like AI is still in MOVE_TO intention and it get's changed after 2.5 seconds and within this time the character is still moving no matter that it is sited down already.
* Patch by: Tryskell

r5730 | UnAfraid | 2012-12-22 12:34:23

BETA: Fixing transformation skill learning issue sometimes nothing happens when you click learn and you haven't learned Onyx Beast transformation (Added the missing message..)
* Reported by: lion

r5731 | VlLight | 2012-12-23 18:02:04

BETA: Minor rework in instances:
* Created group system for instance spawn. There should be one <group name="general"></group> group, which spawned at instance creation (as usual). Besides, it is possible to create other group(s) (with any different name) to spawn it manually in script in appropriate moment of time via Instance.spawnGroup(String groupName) method. A way to unhardcode conditional instance spawn.
* Reviewed by: UnAfraid
* Minor rework for [5723]. If _instanceId isn't initialized in Location, teleToLocation(Location, int) will port player into main world. It creates some inconvenience, when using teleToLocation(Location, int) for teleportation inside instance.
* Reported by: Konstantinos


r5732 | VlLight | 2012-12-23 18:03:55

Oops

r5733 | UnAfraid | 2012-12-24 20:51:26

BETA: Setting script value of L2Npc back to 0 while respawning the npc.
* Reported by: malyelfik

r5734 | malyelfik | 2012-12-30 18:41:54

BETA: Core part for [DP9355]
Reviewed by: UnAfraid

r5735 | Zoey76 | 2013-01-01 17:26:37

BETA: Refactoring !ExShowScreenMessage related code:
* Added position constants based on forum contributions, thanks.
* Added !JavaDocs.
* Added params parameter, now is possible to set all parameters at once.
* Changes in Quest class:
* Added method showOnScreenMsg(..) for !NpcStrings, !SystemMessages and text.
* Moved some variables at the beginning of the class and removed one TODO task since it was done in [5573].
* After all quest are in java the questItemIds variable should be private.

r5736 | Zoey76 | 2013-01-01 18:42:15

BETA: Fixing dialogs for Logistics Officer:
* Closing #6385

Reported by: blacksea

r5737 | Zoey76 | 2013-01-03 15:35:22

BETA: L2J Server's license update:
* Proper GPLv3 license.
* Updated all Java server files.
* The following files listed here will keep their license as is (minor cosmetic updates may be included):
* PrimeFinder
* BlowfishEngine
* SpringUtilities
* Updated Eclipse preferences for new files (header).

r5738 | UnAfraid | 2013-01-03 21:26:38

BETA: Adding some more quests.
* Patch by: lion

r5739 | UnAfraid | 2013-01-04 13:50:18

BETA: Fixing Util.formatAdena() method sometimes it misses some zero's.
* Reported by: lion

r5740 | UnAfraid | 2013-01-04 16:54:35

BETA: Removing unused npcs's hp limit implementation.
* Fixing player's visual hp issues with max hp increase skills.
* Reported by: burrito, MELERIX, valdaron, oscard
* Tested by: ivantotov
* Implemented new method in CharStat calcStat(Stats stat, double init)
* Handling client hp/mp/cp bar pixes in one place instead of all over the source.

r5741 | Adry_85 | 2013-01-04 19:31:32

BETA: Continuing with [5738].

r5742 | malyelfik | 2013-01-06 13:39:18

BETA: Fix for ticket #6373

r5743 | Adry_85 | 2013-01-08 17:57:20

BETA: Missing !SystemMessage for quest '''Seven Signs, Secret Ritual of the Priests'''.

r5744 | Zoey76 | 2013-01-08 18:13:09

BETA: Two useful methods for Quests:
* executeForEachPlayer(..) you can use this for onKill(..) when a reward or quest state is set for the killer's party and/or command channel.
* actionForEachPlayer(..) overridable method in quests where the action logic is placed.
* L2DoorInstance and Instance minor cleanup.
* L2J_Server_README.txt update.

r5745 | UnAfraid | 2013-01-08 22:17:19

BETA: Adding some useful methods to Quest class to prevent from copying same code in bunch of places:
* addSpawn(int npcId, int x, int y, int z, int heading, boolean randomOffset, long despawnDelay, boolean isSummonSpawn, int instanceId)
* openDoor(int doorId, int instanceId)
* closeDoor(int doorId, int instanceId)
* getDoor(int doorId, int instanceId)
* teleportPlayer(L2PcInstance player, Location loc, int instanceId)
* teleportPlayer(L2PcInstance player, Location loc, int instanceId, boolean allowRandomOffset)

* Also little cleanup in L2World its not necessary to remove object by object from knownlist when at the end all the knownlist will be cleared.

r5746 | malyelfik | 2013-01-09 14:05:38

BETA: Minor fix for [5744]

r5747 | Zoey76 | 2013-01-09 17:14:06

BETA: Misc changes.
* Javadoc typo fix.
* Avoiding custom message when auto learn skill is off.
* Reported by: St3eT

r5748 | UnAfraid | 2013-01-10 21:32:21

BETA: Fixing little typo in EffectTemplate (Now will throw exception when requesting non-existing effects)
* Reported by: Adry_85

r5749 | UnAfraid | 2013-01-10 22:09:28

BETA: Fixing minor problem with teleportPlayer seems like teleToLocation now set's instance id from the location since [5723]

r5750 | UnAfraid | 2013-01-10 22:16:07

BETA: Fixing more Olympiad teleporting instance id is set back to zero
* Reported by: baluu, Adry_85

r5751 | VlLight | 2013-01-11 19:09:01

BETA: NPC spawn-related changes
* Support for random respawn time
* Minor fix: if NPC's respawn time is set to 0 in spawn table - do not respawn it

* Reviewed by: UnAfraid, Zoey76, MELERIX
'''Note:''' Retail feature.

r5752 | VlLight | 2013-01-12 16:44:34

BETA: Continuing with [5751].
* Core support for [DP9390]
* Support for random respawn time into instance's spawn definition

r5753 | VlLight | 2013-01-12 17:04:26

BETA: Typo fix in [5751].

* Reported by: l2j@…


r5754 | Zoey76 | 2013-01-13 13:00:25

BETA: Removing Appearance skill implementation.

r5755 | VlLight | 2013-01-13 14:20:29

BETA: WalkingManager impovements, random respawn interval fix.
* Support for attaching certain route to certain NPC with certain spawn coordinates in Routes.xml
* onNodeArrive quest trigger, triggering, when NPC, which is controlled by Walking Manager, arrives next node
* proper handling for situation, when monster, which is controlled by Walking Manager, is attacked by player; handling for minions of Walking Manager controlled monsters.
* AI-disabled NPC's, having aggro_range parameter, which is controlled by Walking Manager, can track aggro range enter
* receiving debug information about walk using //debug command
* random respawn interval fix - _respawnMinDelay and _respawnMaxDelay are reverted to int.

* Reported by: UnAfraid (random respawn interval)
* Reviewed by: UnAfraid, Zoey76

r5756 | Zoey76 | 2013-01-13 16:59:24

BETA: One new method for quests hasAtLeastOneQuestItem(L2PcInstance player, int... itemIds)
* Return true if the player has at least one item in the array.
* Minor code formmat and cleanup.

r5757 | VlLight | 2013-01-13 17:09:25

BETA: Misc. fixes
* Support for personal random animation on/off switching.
* Fixed: raid minions ignored master's setUseRaidCurse(false) command.

r5758 | UnAfraid | 2013-01-19 10:56:01

BETA: Fixing missing conditions validation in triggered skills.
* Patch by: Gnacik

r5759 | UnAfraid | 2013-01-21 16:48:59

BETA: Adding two useful methods in Quest class:
* giveItems(L2PcInstance player, ItemHolder holder)
* takeItems(L2PcInstance player, ItemHolder holder)

r5760 | UnAfraid | 2013-01-21 18:10:01

BETA: Fixing potential multi-thread issue in Util.formatAdena()
* Reported by: Tukune

r5761 | malyelfik | 2013-01-23 14:45:07

BETA: Core part for [DP9399]
Reviewed by: !UnAfraid

r5762 | UnAfraid | 2013-01-25 15:09:47

BETA: Fixing NPEs since [5757] in L2MonsterInstance seems getLeader could be NPE
* Reported by: Lupu1

r5763 | UnAfraid | 2013-01-25 15:41:16

BETA: Fixing wrong chat types causing chat filter do not work.

r5764 | UnAfraid | 2013-01-25 15:46:46

BETA: Fixing auto skill learn issue causing server to execute ~600 mysql queries and broadcast 3 * 600 packets because of not optimized for batch methods.
* Implementing Interface ISkillsHolder on L2Character and creating new !PlayerSkillHolder that would replace L2PcInstance while skill learn batch is procede, in order to receive final skills that have to be added, stored and broadcasted.
* Reported by: Raspoutine, Arantir, Maylorian, Tryskell, laikeriz, MELERIX, CorriGaN, djmouse, CorriGaN, djmouse

r5765 | UnAfraid | 2013-01-25 15:49:38

BETA: Removing debug message of [5764]

r5766 | UnAfraid | 2013-01-26 07:09:48

BETA: Fixing possible problem with player's enchanted skills.
* Adding all player's skills to the map before start checking for new skills.

r5767 | VlLight | 2013-01-26 17:46:20

BETA: Fixed NPC's respawn in instance, that was broken in [5752]
* Reported by: IMBAL

r5768 | MELERIX | 2013-01-28 05:53:54

BETA: More stuff for [5701]
* Added one more check to skillTime, in order to avoid "broken casting animations" on physical skills, like: Shield Deflect Magic, Wild Shot, and few others.

Reported by: enki
Tested by: enki

r5769 | malyelfik | 2013-02-03 17:56:06

BETA: Core part for [DP9407]

r5770 | Zoey76 | 2013-02-05 18:32:54

BETA: Minor code refactor:
* getRandomPartyMember(L2PcInstance, String) to getRandomPartyMember(L2PcInstance, int).

r5771 | Zoey76 | 2013-02-05 19:10:54

BETA: Fixed issue with not providing the player name parameter to NpcStrings which have it.

Patch by: jurchiks
Reviewed by: Zoey76

r5772 | UnAfraid | 2013-02-07 00:38:29

BETA: Moving effect flags out of CharEffectList into EffectType enum.
* Reviewed by: Zoey76

r5773 | UnAfraid | 2013-02-07 01:09:18

BETA: Overriding getSummon() method in L2Summon class as well.


r5774 | MELERIX | 2013-02-07 12:52:39

BETA: Core-Part for [DP9419].

r5775 | UnAfraid | 2013-02-08 13:16:44

BETA: Fixing minor typo in !SystemMessageId SUBMITTED_A_BID'''_OF_S1''' (Missing param identifier)
* Reported by: K4N4BS

r5776 | UnAfraid | 2013-02-09 22:17:57

BETA: Fixing problems with walking monsters sometimes geodata doesn't allows to be exact position so +/- 10 x or y should solve the issue.
* Reported by: Konstantinos

r5777 | Zoey76 | 2013-02-10 00:40:40

BETA: Support for ejecting players upon death inside instance zones.
* Overridable from XML templates.
* Configurable in Character.properties.
* Default retail time 60 seconds.
* Removed custom message when ejecting players.
* Minor source format.

r5778 | Zoey76 | 2013-02-10 01:06:19

BETA: Reworking eject player support.
* onDeath(..) method moved to !InstanceWorld, now can be overridden in instance zone implementations.
* Do not forget to call super.onDeath(..) or eject task won't called.
* Allows you to manage player death inside instances.
* Added system message upon death.
Reported by: UnAfraid

r5779 | Zoey76 | 2013-02-10 14:34:20

BETA: High 5 party distribution:
* The experience point penalties for excessive differences in the level of party members has been changed. If the lowest and highest level party members are causing a level gap, the lowest-level member will receive a penalty according to how many levels of difference there are:

* If the level gap between the highest and lowest party members is 9 levels or less, they will gain 100% of the XP as they will have no penalty.
* If the level gap between the highest and lowest party members is 10 to 14 levels, the lowest party member will gain only 30% of the XP that others receive.
* If the level gap between the highest and lowest party members is 15 levels or more, the lowest party member will not receive any XP.

'''Note:''' Default system has changed.

r5780 | Zoey76 | 2013-02-10 15:39:00

BETA: Now is possible to set random walk to NPCs spawned into instance zones.
* Global parameter.
* Individual parameter for each spawn.

'''Note:''' Please refer to XDS for usage.

r5781 | Zoey76 | 2013-02-10 16:15:04

BETA: Moving some interfaces to the new package.

r5782 | Zoey76 | 2013-02-10 19:26:37

BETA: Minor typo fix.

r5783 | Zoey76 | 2013-02-10 20:28:54

BETA: Retail like support for:
* "Since the Clan Reputation Score has dropped to 0 or lower, your clan skill(s) will be de-activated."
* "Clan skills will now be activated since the clan's reputation score is 0 or higher."

r5784 | Zoey76 | 2013-02-11 10:50:29

BETA: Minor cleanup and improvements.

Patch by: jurchiks

r5785 | Zoey76 | 2013-02-11 16:25:52

BETA: Fixing typo, in Quest methods, the parameter should be isSummon instead of isPet.

r5786 | Zoey76 | 2013-02-11 17:50:08

BETA: Implementing onSeeCreature(..) method for Quests.
* Removing useless boolean return in notify...(..) methods.
* Moved AI tasks to own package.
* Fixed minor typos in comments.

Suggested by: nonom, Szponiasty

'''Note:''' Is '''really important''' to review all scripts that uses onAggroRangeEnter instead of onSeeCreature.

r5787 | Zoey76 | 2013-02-11 17:57:01

BETA: The rest of [5786].

r5788 | Zoey76 | 2013-02-11 18:47:24

BETA: Quest class cleanup:
* Within Id registering methods:
* Removed all loops except the one added in addEventId.
* Removed all method to add single Id.
* Removed all returns of !L2NpcTemplate.

r5789 | Zoey76 | 2013-02-11 21:09:52

BETA: Restoring some methods for Jython scripts.

Reported by: oscard

r5790 | Zoey76 | 2013-02-11 21:37:40

BETA: Stack trace improvement for Jython scripts.

Patch by: tukune

r5791 | Zoey76 | 2013-02-11 21:57:17

BETA: Minor typo fixes for [5779].
* Closing #6438

r5792 | Zoey76 | 2013-02-12 00:12:59

BETA: Minor code cleanup and refactoring.

r5793 | MELERIX | 2013-02-13 07:52:36

BETA: skill power shouldn't affect character base mAtk!

Reported by: VlLight

r5794 | MELERIX | 2013-02-14 00:11:56

LIBS/COMMUNITY/BETA: Improved the way how is generated the revision number in Ant Builder, now it will get the revision number of the last change made in the specific project, and not the last revision number from whole svn.

r5795 | Zoey76 | 2013-02-14 00:52:10

BETA: Fixing some bugs and logic from [5779].

r5796 | MELERIX | 2013-02-14 17:13:23

BETA: Same that [5793] but now for pet base mAtk!

Reported by: Copyleft

r5797 | Zoey76 | 2013-02-14 23:49:38

BETA: Fixing issue with monsters not giving XP.
* Attack shouldn't be scheduled.
* Problem is '''not''' related to High Five party cutoff system.
* Closing #6444

Reported by: Dev

r5798 | Adry_85 | 2013-02-16 16:55:49

BETA: Minor typo fixes and improvements.

r5799 | Zoey76 | 2013-02-17 12:47:53

BETA: Using accessors for eventMob field.

r5800 | Zoey76 | 2013-02-17 16:57:02

BETA: New implementation of SpawnTable.
* Performance greatly improved.

Suggested by: jurchiks
Patch by: Zoey76

r5801 | Zoey76 | 2013-02-17 18:12:29

BETA: Continuing with [5800]:
* Added all missing !JavaDocs.
* Now getSpawns(..) will return a parameterized, immutable empty set, no more null checks.
* Minor improvements to addSpawn(..) method.
* Added missing setCustom(..) while loading spawns.

Suggested by: UnAfraid, jurchiks

r5802 | Adry_85 | 2013-02-19 13:52:16

BETA: '''Fisherman's Potion''' and '''Caravan's Secret Medicine''' can be stolen.

Reported by: lion

r5803 | Adry_85 | 2013-02-19 14:18:08

BETA: Main func must be before all.

Reported by: lion
Patch by: JIV

r5804 | MELERIX | 2013-02-20 08:54:41

BETA: When a players is under the effect '''Seal of Blockade''' skill, it should blocks ordinary attacks only, not all the physical skills.

Reported by: AriesT
Patch by: GodKratos

NOTE: Fixed after 5 years, lol.

r5805 | Adry_85 | 2013-02-22 18:23:10

BETA: Players cannot see party member's toggle and heal potion buffs.

Reported by: lion
Patch by: lion, Adry_85

r5806 | UnAfraid | 2013-02-23 15:28:33

BETA: Fixing minor NPE in auto network configure method.
* Reported by: Drathir

r5807 | Adry_85 | 2013-02-24 15:20:25

BETA: Core-Part for [DP9460].

r5809 | Zoey76 | 2013-02-24 17:09:40

BETA: Action improvements.
* Removed custom system message.
* Code cleanup and improvements.
* Reviewed player distance for couple actions.
* Reported by: oscard, Konstantinos, u3games
* AnswerCoupleAction Patch by: _Blade_
* Removed "You carefully nock an arrow." system message, not used anymore.
* Reported by: lion
* Retail like behaviour for bow and skill casting.
* Reported by: Kingzor

r5810 | MELERIX | 2013-02-24 18:16:51

BETA: Added support for CubicPower, also fixed Cubics MDAM Formula.

r5811 | Zoey76 | 2013-02-24 18:44:57

BETA: Continuing with Balance Life rework.

r5812 | Zoey76 | 2013-02-24 20:49:45

BETA: Fixing NPE vulnerability from [5802].

Reported by: thecast

r5813 | UnAfraid | 2013-02-24 21:14:06

BETA: Fixing NPEs caused by [5802] (Missing check if player has summon).
* Moving hasSummon() to L2Character from L2PcInstance.
* Note: Using OOP approach getSummon() is overridden in L2Summon.

r5814 | Zoey76 | 2013-02-24 21:26:03

BETA: Continuing with [5812]/[5813].

r5815 | UnAfraid | 2013-02-25 00:32:10

BETA: Fixing title length (client supports 21).
* Also fixing little typo inside L2Script.

r5816 | UnAfraid | 2013-02-25 00:38:39

BETA: Fixing little issue causing other players to do not receive title update when using !/resetname command.

r5817 | MELERIX | 2013-02-25 03:49:12

BETA: Typo fix for [5810].

Reported by: Tavo22

r5818 | UnAfraid | 2013-02-25 13:56:27

BETA: Fixing minor issues causing creation of useless packets to be sent on a non player.
* Also when using broadcastPacket is not needed explicitly to use sendPacket if its a player broadcastPacket does it for you otherwise its not needed.

r5819 | UnAfraid | 2013-02-25 13:57:28

BETA: Ignoring launchers folder to prevent from accidently committing debug scripts.

r5820 | UnAfraid | 2013-02-25 17:12:38

BETA: Fixing wrong startup order:
* CastleManager must be loaded before territory war, otherwise problems can occur like request for door manage before they are actually loaded up.
* Also caching Castle if castle id is above 0.

r5821 | UnAfraid | 2013-02-25 18:29:05

BETA: Removing DoorStat level should not be overridden to 1.

r5822 | Zoey76 | 2013-02-25 22:33:43

BETA: Fixing problems with Expertise skill.

Reported by: Arantir, lion

'''Note:''' Patch in collaboration with lion.

r5823 | MELERIX | 2013-02-27 02:22:30

BETA: Reverted [5356] is useless and is doing nothing, this will be fixed properly later and in a different way.

For now look this post: viewtopic.php?f=91&t=20257 and help to test it if you have time.

r5824 | Adry_85 | 2013-02-27 19:15:34

BETA: Minor fixes from [5805].

Patch by: lion

r5827 | Zoey76 | 2013-02-28 18:17:25

BETA: Misc fixes:
* On first login 20 recommendations must be given.
* Patch by: St3eT
* Minor logic fix for [5809], isAttackingNow() is overridden in L2Summon changing it's behavior.
* Patch by: Tavo22
* In L2Attackable avoiding iterating over keys to get values inside the loop.
* Added set(String, int) method to !QuestState to avoid casting to String on every script.
* Minor refactoring on player creation.

r5828 | nBd | 2013-03-01 20:08:43

Lets test if commiting works.

r5830 | UnAfraid | 2013-03-03 16:11:08

BETA: Implementing ability to plug any object to any L2Object:
* You could attach any object and retrieve it later when you need it, that would help a lot while creating some customs or even implementing retail like features without messing with L2PcInstance or L2Character.
* By default it comes with new implementation of !PlayerVariables which gives you ability to store any key,value for each player anywhere, anytime!
* !PlayerVariables is basically !StatsSet so u could use all of its features.
* Example usage of !PlayerVariables:
{{{
PlayerVariables vars = player.getScript(PlayerVariables.class);
if (vars == null)
{
vars = player.addScript(new PlayerVariables());
}
vars.set("some key name", "some value here");
}}}

* NOTE: '''Be careful when using addScript/getScript there is known issue with DP classes if you use same datapack class in two others to add/get it may result into Class Cast Exception because of ECJ (Eclipse Java Compiler) issues while compiling the code it recreates every class that's imported out of core, until its fixed avoid doing that'''.

r5831 | MELERIX | 2013-03-03 16:17:37

BETA: Added basic support for "for_npc" on items, also fixed Boats & AirShips Restrictions.

Reported by: lion

r5832 | Zoey76 | 2013-03-03 20:23:31

BETA: Improvements for party/command channel implementations.

Patch by: jurchiks
Reviewed by: Zoey76

r5833 | UnAfraid | 2013-03-03 20:26:47

BETA: Core-part for [DP9476]
* Including one new method inside GrandBossManager to get grand boss zone by specific id.
* Patch by: Tryskell

r5834 | Zoey76 | 2013-03-03 20:36:16

BETA: Improvements to system messages related to skill learning process.

Reported by: MELERIX, lion
Patch by: UnAfraid
Reviewed by: Zoey76

r5835 | UnAfraid | 2013-03-03 23:28:26

BETA: Reworking pet summoning system:
* Dropped SummonItemsData.
* Split of PetData.xml into xml for each pet.
* Using itemId reference from L2PetData
* Implemented pet level synchronization (Some pet's are following player's level)
* Added retail-like message when summoning a pet.
* Fixed bug which prevents you from canceling (ESC) the skill that summon a pet while casting.
* Reported by: Tryskell

* Reviewed by: Zoey76, MELERIX

r5836 | UnAfraid | 2013-03-03 23:43:02

BETA: Removing L2SummonItem its no longer needed since [5737]

r5837 | MELERIX | 2013-03-04 06:37:48

BETA: Renamed ("lvlDepend" -> "lvlBonusRate") and ("skillRadius" -> "affectRange").

r5838 | MELERIX | 2013-03-05 04:18:04

BETA: Reworked Cancel/Steal Formulas...
* The Steal Divinity success rate has been reduced. It is also now susceptible to resistance against buff-canceling attacks (H5 Changes).
* Cancel is now properly affected by Cancel Resistances.
* Cancel is now properly affected by Cancel MagicLevel vs Target Buffs MagicLevel.
* and some others improvements.

Tested by: oscard, Tavo22, _Blade_
Reviewed by: UnAfraid
Thanks to: UnAfraid (for help moving some things to formulas class), Adry_85 (for some suggestions)

'''NOTE: Require [DP9485].'''

r5839 | Adry_85 | 2013-03-05 16:25:31

BETA: Core-part for ?[DP9486].

r5840 | MELERIX | 2013-03-05 17:36:02

BETA: Minor fix for [5323] (ValakasVuln/Prof should be applied as modifier to damage in %).

r5841 | MELERIX | 2013-03-05 18:13:32

BETA: Removed [2985] is no longer needed after [4992].

Suggested by: Adry_85

r5842 | Zoey76 | 2013-03-05 19:21:43

BETA: Libraries update:
* C3P0 0.9.2 from C3P0 0.9.2-pre5.
* Tested by: UnAfraid, MELERIX, Zoey76
* JNA 3.5.1 from JNA 3.3.0.
* Tested by: Zoey76
* MySQL Connector 5.1.23 from MySQL Connector 5.1.22.
* Tested by: MELERIX, Zoey76
* JavaMail 1.4.6 from JavaMail 1.4.5.
* Tested by: Zoey76
* JDT Core Batch Compiler 4.2.2 from JDT Core Batch Compiler 4.2.1.
* Tested by: MELERIX, Zoey76
* Updated Subnet library name with version.

r5843 | Zoey76 | 2013-03-05 20:22:06

BETA: Restoring Jython library in class path.

r5844 | MELERIX | 2013-03-06 21:59:43

BETA: Small Improvement for [5838].

r5845 | MELERIX | 2013-03-07 17:24:47

BETA: Fixed '''!LeveBonusMod''' Formula (old !LvlDepend formula),

Reviewed by: Zoey76

and thanks for help me to solve some things with variables

'''More info about this here:''' viewtopic.php?f=91&t=10532&start=15#p160586

Also...
* Removed unused !__calcHitMiss boolean.
* Reeplaced some if else with Math.min.
* Cleanup.
Patch by: Zoey76

r5846 | MELERIX | 2013-03-07 18:11:05

BETA: Minor typo fixes for [5845].

Reported by: jurchiks, UnAfraid

r5847 | Adry_85 | 2013-03-07 20:10:27

BETA: Core-part for [DP9490].

r5848 | MELERIX | 2013-03-07 22:35:38

BETA: Fixed '''!SkillStatMod''' Formula (old !SkillStatModifier formula).

r5849 | Zoey76 | 2013-03-08 00:41:30

BETA: Canceling summon life task in merchant summons.
* Closing #6459

Patch by: TK
Reviewed by: Zoey76

'''Note:''' A different approach using hierarchy could be implemented, without breaking encapsulation.

r5850 | Zoey76 | 2013-03-08 00:45:02

BETA: Minor typos in configuration parsing.
* Closing #6423

r5851 | MELERIX | 2013-03-08 02:43:26

BETA: Fixed '''!ResMod''' Formula.

r5852 | UnAfraid | 2013-03-08 13:07:51

BETA: Implementing retail-like clan leader changes:
* Note: In retail clan leader change requests are applied during maintenance here we'll schedule this to Tuesday (Or any other day you set in config).
* Instant clan leader changes are still possible but disabled by default.
* You can apply pending clan leader changes before Tuesday via admin command: '''!//clan_show_pending''' .

* Reviewed by: Zoey76, Tryskell
* Requires: [DP9492]

r5853 | MELERIX | 2013-03-08 17:08:33

BETA: Missing from [5838].
Patch by: d!g0
Reported by: d!g0
Reviewed by: UnAfraid
Tested by: d!g0

r5854 | MELERIX | 2013-03-08 23:17:50

BETA: Added back part of code removed in [5848], due is still needed for some effects like Spoil.
Reported by: Arantir
Tested by: Arantir

r5855 | malyelfik | 2013-03-10 07:21:47

BETA: BETA: Core-part for [DP9494]
Reviewed by: MELERIX, !UnAfraid, Adry_85

r5856 | malyelfik | 2013-03-10 07:30:14

BETA: Cleanup after [5855]

r5857 | UnAfraid | 2013-03-10 08:12:37

BETA: Misc changes:
* Fixing minor typo in trigger skill system reflected damage must be considered as damage for the reflected character.
* Reported by Nik
* Patch by: Nik
* Making Env's _value variable volatile.
* New method in L2Skill: hasEffectTypes()
* Returns '''true''' if at '''least one''' of specified L2EffectType types present on the current skill's effects, '''false''' otherwise.

r5858 | Adry_85 | 2013-03-10 16:42:27

BETA: Skill related improvements and fixes.

* Removed useless SkillType.
* Removed isStaticHeal boolean, now using isStatic() check.

Reviewed by: MELERIX, UnAfraid, Zoey76

r5859 | MELERIX | 2013-03-11 04:28:17

BETA: Reduced some calculations.

r5860 | MELERIX | 2013-03-11 04:33:52

BETA: Accidentally committed, it will be cleaned up later and more complete.

r5861 | Adry_85 | 2013-03-11 21:13:17

BETA: Continuing with [5858]:

* Removed !SkillTypes CANCEL, CANCEL_DEBUFF, NEGATE and FAKE_DEATH.

Patch by: MELERIX, UnAfraid
Tested by: Adry_85

r5862 | UnAfraid | 2013-03-12 10:38:47

BETA: Fixing minor NPEs in L2Skill caused by [5857]
* Reported by: JMD, Adry_85

r5863 | UnAfraid | 2013-03-12 10:43:55

BETA: Ignoring condition checking for hasEffectType method.

r5864 | UnAfraid | 2013-03-12 10:45:21

BETA: Fixing minor typo from [5863]

r5865 | Zoey76 | 2013-03-12 15:18:30

BETA: Minor cleanup in Quest class after [DP9036].

r5866 | Zoey76 | 2013-03-12 19:07:42

BETA: Minor cleanup for skill fields.

r5867 | Zoey76 | 2013-03-13 16:06:03

BETA: Reworking Sweeper to use retail like effects.
* Unhardcoded Max Sweeper Time value.
* Removed !RewardItem class, replaced with !ItemHolder.
* Removed SWEEP skill type.
* Added method addItem(String, !ItemHolder, L2Object, boolean) to work with !ItemHolder.
* Removed L2SkillSweeper class.
* Changed name and logic for method checkCorpseTime(..).
* Removed L2SkillElemental class, not used anywhere.

r5868 | Zoey76 | 2013-03-13 17:43:06

BETA: More skills cleanup:
* Removing L2SkillMount skill implementation and MOUNT skill type.
* Removing L2SkillChangeWeapon skill implementation and CHANGEWEAPON skill type.

r5869 | UnAfraid | 2013-03-13 18:20:16

BETA: Fixing minor NPEs happens when effected is null.
* Reported by: oscard, MELERIX

r5870 | Zoey76 | 2013-03-13 18:43:32

BETA: Using effect instead of skill level for Divine Inspiration skill.

r5871 | UnAfraid | 2013-03-14 11:38:27

BETA: Reworking GameTimeController (Now's less CPU Hungry, no more synchronizations, no more time diff)
* Patch by: Forsaiken
* Thanks to: nBd

r5872 | UnAfraid | 2013-03-14 11:49:20

BETA: Minor changes (javadocs/method re-arrange/loggers..) for [5871]

r5873 | Zoey76 | 2013-03-14 19:20:46

BETA: Rewriting NpcBufferTable bit more OOP:
* Using proper DTO NpcBufferData and one map, instead of 4 maps.
* Implemented using Java instead of Trove.
* Minor rewrite of L2NpcBufferInstance.

r5874 | MELERIX | 2013-03-14 20:22:45

BETA: Fixed [4610] properly.

r5875 | Zoey76 | 2013-03-15 16:05:46

BETA: Implementation of UI Key mapping using XML.
* Implemented using !DocumentParser.

r5876 | UnAfraid | 2013-03-15 18:12:29

BETA: Fixing minor typo in GameTimeController since the [5871]
* Reported by: JMD, Zoey76
* Tested by: JMD, Arantir

r5877 | UnAfraid | 2013-03-16 00:07:05

BETA: Partial revert of [5857] changes seems it may cause deadlocks.
* Reported by: nBd

r5878 | malyelfik | 2013-03-16 11:49:44

BETA: Core-part for [DP9519]


r5879 | UnAfraid | 2013-03-16 12:46:17

BETA: Implementing new config to allow augmenting pvp items.

r5880 | UnAfraid | 2013-03-16 17:40:55

BETA: Fixing minor NPE vulnerability.
* Reported by: nBd

r5881 | Zoey76 | 2013-03-16 18:50:56

BETA: Unhardcoding warrior fishing monsters.

r5882 | UnAfraid | 2013-03-16 19:34:17

BETA: Fixing really rare OID map bug which appears when is night according to game time controller and server is starting up at that time it spawns twice Eilhalder von Hellmann and causing him to be like a ghost (Non target-able, but attacking you at the same time)

r5883 | UnAfraid | 2013-03-16 21:25:55

BETA: Fixing minor bug which causing some skills to be stored in database when they should not (Like Armor / Weapon grade penalty).
* Reported by: oscard, Zoey76, Arantir

r5884 | malyelfik | 2013-03-17 06:40:10

BETA: Core-part for [DP9524]


r5885 | Zoey76 | 2013-03-17 15:58:37

BETA: Minor fixes for Sweeper (42) skill.

Patch by: MELERIX, Zoey76

r5886 | MELERIX | 2013-03-18 03:08:29

BETA: Some more for [5859] and few improvements in FuncMAtkMod.

r5887 | Zoey76 | 2013-03-18 04:11:50

BETA: Reworking skills (cleanup):
* No more...
* "neutral" skills, all skills are "neutral" by default.
* dynamic skill/effect type dependent "offensive" checks.
* dynamic skill/effect type dependent "pvp" checks.
* null names, default is empty string.
* dynamic seven sings skill checks, is cached in boolean until is finally unhardcoded.
* CPDAM skill type, not used anywhere.
* skills "pvp" and "offensive" at the same time.
* Spoil skill handler!
* !CpDam skill handler!
* _effectSkillType in L2Effect.
* effectType in !EffectTemplate.
* effectType in skill XMLs.
* effectPower=-1 lands always!
* Fixing Sweeper effect typos!
* Reported by: Decad, Torvitas

Reviewed by: Adry_85, MELERIX, UnAfriad

r5888 | Zoey76 | 2013-03-18 14:45:04

BETA: More skill related cleanup:
* Removed custom skill Id restrictions.
* Fixed minor typo in variable name.
* Reported by: jurchiks
* Now clan skills are differenced if they belong to a pledge or sub-pledge skill tree, no more custom paramter.
* Fixed some !JavaDocs.

r5889 | Zoey76 | 2013-03-18 15:58:23

BETA: Misc fixes.

r5890 | UnAfraid | 2013-03-18 19:55:44

BETA: Fixing name/title when changed not updating until relogin.
* Thanks to: Whoever open ticket #6538
* Reported by: MELERIX, nBd

r5891 | Adry_85 | 2013-03-18 20:58:36

BETA: Core-part for ?[DP9534].

r5892 | Zoey76 | 2013-03-18 21:22:41

BETA: Effect fixes:
* Now is possible to find the first passive effect with certain effect type.
* Support for Lucky effect (Lucky skill).
* Support for Enlarge Abnormal Slot effect (Divine Inspiration skill).

r5893 | MELERIX | 2013-03-19 00:25:51

BETA: Few Improvements for formulas.

r5894 | UnAfraid | 2013-03-19 19:17:29

BETA: From now on all dances and songs will not be stored upon logout!
* '''Note:''' We keep configuration to reverse it as it was until now.
* Reported by: FinalDestination, St3eT

r5895 | Zoey76 | 2013-03-19 22:53:51

BETA: Skill fixes!
* Fixed heal (and alike) casted on flagged player didn't set flag on caster.
* Fixed PVP skills set flag on caster when used on monsters.
* PVP skills are offensive as well!
* Tiny typo in config description.
* Reported by: St3eT

r5896 | UnAfraid | 2013-03-19 23:12:04

BETA: Fixing NPE vulnerability in ExShowScreenMessage.
* Reported by: oscard

r5897 | UnAfraid | 2013-03-20 00:03:13

BETA: Improving hasEffectType method to do not cause such over-heat (Creating lots of new L2Effect objects just to check their EffectType)
* Reviewed by: Zoey76, DrHouse

r5898 | UnAfraid | 2013-03-20 14:40:11

BETA: Changing L2GameClientPacket, L2GameServerPacket loggers to static to prevent from creating logger for each packet created.
* Reported by: nBd

r5899 | UnAfraid | 2013-03-20 23:01:18

BETA: Fixing bug causing item skills to be stored in database.
* Reported by: nBd

* '''NOTE:''' Please enable skill checker to cleanup all the skills that should not be stored in database (You can find it in General.properties).

r5900 | Zoey76 | 2013-03-21 09:51:49

BETA: Removing unhardcoded despawn time for fishing monsters.

Reported by: lion

r5901 | Adry_85 | 2013-03-22 12:27:07

BETA: Skill fixes:

* Added support for affect limit parameter (only for TARGET_AREA_FRIENDLY)
* Removed COMBATPOINTHEAL and CHAIN_HEAL SkillTypes
* Added TARGET_AREA_FRIENDLY TargetType

Reviewed by: lion, MELERIX, UnAfraid, Zoey76

r5902 | Adry_85 | 2013-03-23 21:58:37

BETA: Fixing skills behaviour after [5901].

Reported by: takhs7
Tested by: MELERIX

r5903 | MELERIX | 2013-03-24 00:10:03

BETA: CORE-Part for [DP9553].

r5904 | malyelfik | 2013-03-24 07:17:40

BETA: Moving some npc instances to DP:
* L2CastleBlacksmithInstance
* L2CastleTeleporterInstance
* L2CastleWarehouseInstance
* L2TownPetInstance

* Added onRouteFinished quest trigger
* Thanks to Zoey76 for suggestion

Reviewed by: UnAfraid


r5905 | nBd | 2013-03-24 17:22:46

BETA: If we have a Config and use it to decrease rep, why not check for it..

r5906 | Zoey76 | 2013-03-24 21:20:58

BETA: Fixing memory leak:
* Custom skills are used only by players, not by every L2Character!
* Improved !RequestMagicSkillUse to retrieve skills with less map calls (OOP).
* Using lazy initialization, even if map is for player only, players with no custom skills shouldn't instantiate it.
* Removed deprecated method related to class name.
* Using hierarchy in !PcItemTemplate to inherit !ItemHolder fields and methods.
* Using !ArrayList instead of !FastList in !SkillList, there is no need for concurrent or thread safe operations.
* Removed removeSkill(L2Skill) from L2Character.
* Overridden addSkill(L2Skill) in L2PcInstance to keep player related code in player class.
* Fixing issue with custom skills not being displayed by client when skill level doesn't exist in client.
* Using custom display level to properly display custom skills.
* XML skill parameter: displayLevel (same use as displayId).
* Video: http://youtu.be/9wHGkqd5PPc

r5907 | UnAfraid | 2013-03-25 15:36:06

BETA: Fixing client critical error when creating character (Sending two times CharSelectionInfo causes critical error sometimes).
* Reported by: lion, nBd