Saving Player buffs to give them later

[HappyLDE]

Hello i want to store the character buffs and when needed give them back:

Code: Select all

Map<Integer, BuffInfo> buffs = activeChar.getEffectList().getBuffs();            activeChar.sendMessage("buffs count "+buffs.size());                        activeChar.stopAllEffects();                        activeChar.sendMessage("buffs count "+buffs.size());             for (Entry<Integer, BuffInfo> entry : buffs.entrySet())            {                try                {                    SkillData.getInstance().getSkill(entry.getValue().getSkill().getId(), entry.getValue().getSkill().getLevel()).applyEffects(activeChar, activeChar);                } catch (RuntimeException e) { }            }

But after stopAllEffects(), buffs.size() gets to zero, therefore no buffs in my list to give back, what should i do?

[UnAfraid]

Map<Integer, BuffInfo> buffs = activeChar.getEffectList().getBuffs();
its not a copy its reference

[HappyLDE]

How to make a copy instead of references? Thank you very much for answer

[Starter]

Add player buffs to a list like this:

Code: Select all

        for (L2Effect effect : playerInstance.getAllEffects())        {            if (effect == null)                continue;                        playerInstance._buffs.addIfAbsent(effect);        } 

?

[UnAfraid]

Add player buffs to a list like this:

Code: Select all

        for (L2Effect effect : playerInstance.getAllEffects())        {            if (effect == null)                continue;                        playerInstance._buffs.addIfAbsent(effect);        } 

?

Hell no!
If you need it a list: List<BuffInfo> buffs = new ArrayList<>(activeChar.getEffectList().getBuffs().values());
if you need it as map: Map<Integer, BuffInfo> buffs = new HashMap<>(activeChar.getEffectList().getBuffs());

[Starter]

Add player buffs to a list like this:

Code: Select all

        for (L2Effect effect : playerInstance.getAllEffects())        {            if (effect == null)                continue;                        playerInstance._buffs.addIfAbsent(effect);        } 

?

Hell no!
List<BuffInfo> buffs = new ArrayList<>(activeChar.getEffectList().getBuffs().values());

What about:

public final CopyOnWriteArrayList<L2Effect> _buffs = new CopyOnWriteArrayList<L2Effect>();

Added in l2pcinstance. Dont remember atm why I did it that way in the past but I think it was the best solution avoiding several bad situations.

[UnAfraid]

Not needed to be thread safe since hes going to use it right away.
BTW xban1x made an effect that restores canceled effects after some time u may want to check it

[Starter]

Cant, I have a ban allergy.

[HappyLDE]

Thank you guys that did it and now works!!

[Starter]

Thank you guys that did it and now works!!

like

[HappyLDE]

Not needed to be thread safe since hes going to use it right away.
BTW xban1x made an effect that restores canceled effects after some time u may want to check it

What if i don't give them back right away but in 10 hours, is that bad?

[Zoey76]

Check StealAbnormal, that's a perfect example.