Non-Stackable Item Drops

[GodKratos]

OK, Here's a question....

What happens on retail when you get more than one non-stackable item given to you?
Do you get a system message saying you have received 4 items and get 4 separate items in your inv or do you get 4 system messages saying you have received an item?

What brings this up is the Change class alterations for healers.
When you get the 4 Holy Pomanders currently on L2J you only receive one of them, even though the system message says you have earned 4.
This is because they are not stackable and our current addItems method does not handle giving multiple non-stackable items.

So do we put a loop in the givePomanders() method to give the item 4 times, or do we fix the addItems() method to handle non-stackable items?

I don't know how it is on retail so I went with the easy fix for now:

Code: Select all

Index: data/scripts/custom/SkillTransfer/SkillTransfer.java===================================================================--- data/scripts/custom/SkillTransfer/SkillTransfer.java	(revision 289)+++ data/scripts/custom/SkillTransfer/SkillTransfer.java	(working copy)@@ -322,7 +322,8 @@ 				if (st.getGlobalQuestVar(name).isEmpty()) 				{ 					st.saveGlobalQuestVar(name, "1");-					player.addItem(qn, PORMANDERS[index][0], PORMANDERS[index][1], npc, true);+					for (int i = 0; i < PORMANDERS[index][1]; i++)+						player.addItem(qn, PORMANDERS[index][0], 1, npc, true); 				} 			} 		}

[_DS_]

Last time i checked it 4 pormanders given. Worksforme ?

[Probe]

nope it gives just 1, and on retail I was SE on pts and it gave me 4 messages of acquired 1 item

[devo]

Last time i checked it 4 pormanders given. Worksforme ?

I reported that first day after GE was public, a lot of reports from SE that they get 1 Pomander, also in item log.

[gigiikun]

Sorry than. This bug seems a little bit random. Example I have no reports from our players, and I got 4 pomanders .

[devo]

Yes because its random, I created new char, and get 4 pomanders, then created the same again, and got 1. Temp fix for players was, "go and delete your current transfer skill, you should get 4 pomanders", and yes sometimes they get 4, sometimes not.

[janiii]

what about using st.giveItem() method ? what about Config.MULTIPLE_ITEM_DROP ?

[devo]

I had MultipleItemDrop = True on when this happen.