L2Multisell.java

[jurchiks]

There exists a boolean inventoryOnly, and according to it's description, it's the same as
%objectId%_exc_multisell.
Deprecated?

[wasabi2k]

i think this type is still used, so you should be fine using "exec" (also core still supports this type)

[jurchiks]

umm...
I wasn't asking about _exc_multisell...

[_DS_]

%objectId%_multisell - multisell trade
%objectId%_exc_multisell - multisell exchange

They are absolutely different.

[wasabi2k]

oh you meant the boolean.... i dunno my advice would be to just use exec ....

after looking at the multisell parser i could find NO reference to your boolean "inventoryOnly"

[jurchiks]

nvm then...
also, about line 199-209, maybe this would be better:

Code: Select all

			if (ing.getItemId() == 57			{				if ing.isTaxIngredient()				{					if (applyTaxes)						adenaAmount += Math.round(ing.getItemCount() * taxRate);					continue; // do not adena yet, as non-taxIngredient adena entries might occur next (order not guaranteed)				}				else				{					adenaAmount += ing.getItemCount();					continue; // do not adena yet, as taxIngredient adena entries might occur next (order not guaranteed)				}			}

[wasabi2k]

nvm then...
also, about line 199-209, maybe this would be better:

Code: Select all

			if (ing.getItemId() == 57)			{				if( ing.isTaxIngredient())				{					if (applyTaxes)						adenaAmount += Math.round(ing.getItemCount() * taxRate);					continue; // do not adena yet, as non-taxIngredient adena entries might occur next (order not guaranteed)				}				else				{					adenaAmount += ing.getItemCount();					continue; // do not adena yet, as taxIngredient adena entries might occur next (order not guaranteed)				}			}

looks good yea. (corrected a little)

[momo61]

%objectId%_multisell - multisell trade
%objectId%_exc_multisell - multisell exchange

They are absolutely different.

exc_multisell is to exchange an armor part for an other ? or a weapon for an other ?

If yes, is it also possible to add ingredients + armor part for a new armor part ?
What happens if the player wears the armor before trading it ?

[wasabi2k]

an exec_multisell is a multisell which only shows the options of which you have all the needed items in your inventory.

[Mayhem]

C'mon guys! Read the documentation.txt!

Code: Select all

Multisell lists can be shown by linking them from an html using: 	<a action="bypass -h npc_%objectId%_exc_multisell 123456">OR	<a action="bypass -h npc_%objectId%_multisell 123456">where 123456 is the id of the multisell (this would show the contents of file "123456.xml")The difference between these two links is as follows:npc_%objectId%_multisell displays a FULL multisell.  That is, all of the entries of the xml are shown exactly as defined.npc_%objectId%_exc_multisell displays an "inventory only" multisell.  That is, it looks through the player's inventory for weapons and armors (not equipped) and it only shows multisell entries that have these weaponsand armors as ingredients!

[jurchiks]

so that's what the inventoryOnly is used...
well that answers my question then

[_DS_]

boolean control from xml and exc - from html.