[VERY RARE] Some dropped items by players get bugged

Post by **janiii** » Tue Apr 20, 2010 9:48 am

so.. is there a testing scenario how this bug with non-pickable items can be reproduced and tested?

Post by **JIV** » Tue Apr 20, 2010 11:00 am

isnt it client bug like item is already deleted wit item auto destroy?

denser · Post by **denser** » Tue Apr 20, 2010 11:02 am

no, JIV, when i hot-on config to save items to db, save it, and restart server - you can login and pick it up. so item stays on ground..may be geo bug? i use geo all the time..

Post by **JIV** » Tue Apr 20, 2010 11:16 am

possible, i dont see geo check there.

Pere · Post by **Pere** » Tue Apr 20, 2010 2:33 pm

denser wrote:no, JIV, when i hot-on config to save items to db, save it, and restart server - you can login and pick it up. so item stays on ground..may be geo bug? i use geo all the time..

JIV wrote:possible, i dont see geo check there.

Lol, I already told you what happens

No geo bug!

2 possibilities:
- Item is not saved in L2World._allObjects (during drop it isn't saved, because it should be from the beginning. To add a security check there fixed the problem for me). When this happens, players can click it and nothing happens.
- Item's location is ItemLocation.INVENTORY instead ItemLocation.NONE. On L2CharacterAI.onPickup() (or something like that), the item's location is checked before picking up the item. If it is not NONE, the function returns (I've fixed that checking if the item is in the character's knownlist and if so, setting the item's location to VOID. If it was really inside an inventory like its location said, it wouldn't be in the picker's knownlist). When this happens, players who click on it don't receive the ACTIONFAILED packet and to move again have to restart or target theirselves.

I repeat, on my server this is "fixed", doesn't happen anymore (and I've posted a patch for the second case in the first post), but the way to fix that isn't correct. We should know why the dropped items sometimes are not in L2World's allObjects list or their location isn't set to VOID.

EDIT: Nice one JIV!! This sync can be our salvation

(http://www.l2jserver.com/trac/changeset/4093)

Post by **_DS_** » Tue Apr 20, 2010 4:55 pm

Such way (with knownlist check) is highly not recommended - all those checks are done on purpose.

I suspect dupe attempts from players.

Pere · Post by **Pere** » Tue Apr 20, 2010 8:14 pm

That's why I posted this, my fix is only temporal...

Post by **JIV** » Tue Apr 20, 2010 9:51 pm

dont think so that 4093 fix it (if there was bug),, also that geocheck should be added cause right now you can drop anywhere in 150 range

L2J Server

[VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged

Re: [VERY RARE] Some dropped items by players get bugged