Page 1 of 3

Momo's Question Section ^_^

Posted: Sun Mar 07, 2010 9:51 pm
by momo61
l2j Core: 3981
l2j DP: 7143

Very interesting rework. Some questions:

1)Why did you do this ? :)
2)There's no necessary database update for running servers?
3)Can someone do this kind of SQL query for this update >_>: ?

http://www.pastebin.cz/33616

Re: Enchant Skill Tree rework

Posted: Sun Mar 07, 2010 9:56 pm
by gigiikun
Sorry, did not write in commit comment that it REQUIRES DP change!

The only real change is that now enchant skill tree is generated from xml, so no need a huge and redundant enchant_skill_trees table.

It is easy to add this:
- stop server
- apply enchant_skill_groups.sql
- update data/stats/skills/XXXX-XXXX.xml files
- update server jar file
- start server

Re: Enchant Skill Tree rework

Posted: Sun Mar 07, 2010 9:58 pm
by gigiikun
3.
Create your own Enchant skill Group and in xml definition change default groups to that.

Re: Enchant Skill Tree rework

Posted: Sun Mar 07, 2010 10:20 pm
by momo61
gigiikun wrote:3.
Create your own Enchant skill Group and in xml definition change default groups to that.
why ? ... that means everytime I decide to update the server I need to modify XMLs... it's a pain in the ass ...

isnt there some other way? like simple SQL queries ?

Re: Enchant Skill Tree rework

Posted: Sun Mar 07, 2010 10:37 pm
by gigiikun
Than change only group table. We use now 1,2 group id.

Re: Enchant Skill Tree rework

Posted: Sun Mar 07, 2010 10:42 pm
by momo61
gigiikun wrote:Than change only group table. We use now 1,2 group id.
guess I need to write new SQL queries for this >_>

we dont need to modify anything on existing character_skills ?

Re: Enchant Skill Tree rework

Posted: Wed Mar 17, 2010 12:13 pm
by momo61
I dont want to open a new topic, so I'll post here:

http://www.l2jserver.com/trac/changeset/4007

Pet critical mod. What is it for? I don't really understand it's function

Re: Enchant Skill Tree rework

Posted: Wed Mar 17, 2010 12:23 pm
by Gnacik
Try cast some buffs on pet which are increasing critical rate (focus and similar) without that changeset and you understand ;)
ps. you should rename that topic to 'momo's questions' or smth ;)

Re: Enchant Skill Tree rework

Posted: Wed Mar 17, 2010 2:19 pm
by momo61
Gnacik wrote:Try cast some buffs on pet which are increasing critical rate (focus and similar) without that changeset and you understand ;)
ps. you should rename that topic to 'momo's questions' or smth ;)
good idea ^^

let me see what happens if i cast those buffs on my pet.

Edit: Tested it. Seems like the pets don't get any stats change with those buffs..

Re: Momo's Question Section ^_^

Posted: Wed Mar 17, 2010 5:06 pm
by Gnacik
yes. right. and that problem is fixed in JiV's patch. :)

Re: Enchant Skill Tree rework

Posted: Wed Mar 17, 2010 6:59 pm
by Pere
momo61 wrote:isnt there some other way? like simple SQL queries ?
On EnchantSkillGroups.java:

Code: Select all

public L2EnchantSkillGroup getEnchantSkillGroupById(int id){	if (Config.USE_OLD_SKILL_GROUP) //add this line		return _enchantSkillGroups.get(30); //and this ;)	return _enchantSkillGroups.get(id);}
I hope you know how to create configs...

Re: Enchant Skill Tree rework

Posted: Wed Mar 17, 2010 7:45 pm
by momo61
Migi wrote:
momo61 wrote:isnt there some other way? like simple SQL queries ?
On EnchantSkillGroups.java:

Code: Select all

public L2EnchantSkillGroup getEnchantSkillGroupById(int id){	if (Config.USE_OLD_SKILL_GROUP) //add this line		return _enchantSkillGroups.get(30); //and this ;)	return _enchantSkillGroups.get(id);}
I hope you know how to create configs...
I already did SQL queries

Re: Momo's Question Section ^_^

Posted: Wed Mar 24, 2010 6:03 am
by momo61
http://www.l2jserver.com/trac/changeset/4016

what was wrong with the castle warehouses before that?

Re: Momo's Question Section ^_^

Posted: Wed Mar 24, 2010 6:24 am
by lion
may be they not work? and this patch fix a bug :mrgreen:

Re: Momo's Question Section ^_^

Posted: Thu Mar 25, 2010 10:03 pm
by momo61
Is there a reason why Doombringers do extreme high crit damage with bows on practically anyone ? They even outdamage archers by 2-3k damage (fully buffed).

what's a way to lower their bow-damage-power?