try{} catch{} finally{} statement

[VlLight]

Please explain to me.. if I have next statement:

private void doSomeThing()
{
try
{
Connection con = L2DatabaseFactory.getInstance().getConnection();
return;
}
catch {}
finally {L2DatabaseFactory.close(con);}
}

will connection close?

[LasTravel]

http://www.l2jserver.com/wiki/index.php ... n_a_script

PS: Also wrong section..

[VlLight]

Thanks But I interested, if i return from try{} block
Offtopic is wrong section? Sorry

[jurchiks]

you shouldn't do that, it will most probably result in an unclosed connection.

[LasTravel]

You can try something like this:

Code: Select all

private void doSomeThing(){    try    {        Connection con = L2DatabaseFactory.getInstance().getConnection();        return;        _log.warning("Return don't work here!")    }    catch {}    finally     {        L2DatabaseFactory.close(con);        _log.warning("DB connection was closed!")    }}

Just need check the console XD

[VlLight]

Are you quite sure?

[VlLight]

LasTravel, thanks, nice trick. I'll try

[jurchiks]

there's nothing to try, everybody knows that return is the end, it won't go past it.

[VlLight]

There's much of that code in LoginController... I hate code in holiday, but chek it in weekdays
Big thanks to all

[_DS_]

No such unreachable code in LoginController.

[VlLight]

loginValid() try{} block.

[JIV]

nothing wrong with that method.