Olympiad Token reward

[Gries]

I saw there are a configs in Olympiad.properties files about the Olympiad Tokens given once the period ends. However i cannot recognize what these numbers stand for.

That's the part i am talking about:

Code: Select all

# Rate to exchange points to reward item.# Default: 1000AltOlyGPPerPoint = 1000 # Noblesse points awarded to Heros.# Default: 200AltOlyHeroPoints = 200 # Noblesse points awarded to Rank 1 members.# Default: 100AltOlyRank1Points = 100 # Noblesse points awarded to Rank 2 members.# Default: 75AltOlyRank2Points = 75 # Noblesse points awarded to Rank 3 members.# Default: 55AltOlyRank3Points = 55 # Noblesse points awarded to Rank 4 members.# Default: 40AltOlyRank4Points = 40 # Noblesse points awarded to Rank 5 members.# Default: 30AltOlyRank5Points = 30

Also, little typo in the line n.5 (Heros -> Heroes)

[Zoey76]

Fixed the typo few commits ago, about the configs, I recommend you to follow them inside the core and check what they do, maybe we can improve it's documentation.

[Gries]

Code: Select all

		final int rank = _noblesRank.get(objId);
		int points = (player.isHero() ? Config.ALT_OLY_HERO_POINTS : 0);
		switch (rank)
		{
			case 1:
				points += Config.ALT_OLY_RANK1_POINTS;
				break;
			case 2:
				points += Config.ALT_OLY_RANK2_POINTS;
				break;
			case 3:
				points += Config.ALT_OLY_RANK3_POINTS;
				break;
			case 4:
				points += Config.ALT_OLY_RANK4_POINTS;
				break;
			default:
				points += Config.ALT_OLY_RANK5_POINTS;
		}
		
		if (clear)
		{
			noble.set(POINTS, 0);
		}
		points *= Config.ALT_OLY_GP_PER_POINT;
		return points;
	}

Basicly,
Olympiad Points + Config.ALT_OLY_RANK1_POINTS1/2/3/4/5.
The result * AltOlyGPPerPoint = Olympiad Tokens awarded

Is this correct?